Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp2078590pxb; Fri, 25 Mar 2022 10:41:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJymgNQNgBOPoPCVyYLRVFvO8kAJTVJSm13tbvlXBIglaH7KTqtyTRnkd2vnT4HampO41O39 X-Received: by 2002:a17:903:1104:b0:154:c628:e7c2 with SMTP id n4-20020a170903110400b00154c628e7c2mr11113006plh.54.1648230103190; Fri, 25 Mar 2022 10:41:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648230103; cv=none; d=google.com; s=arc-20160816; b=jZmfkg/atwClAJ7NmL/KNCyTD5aFzBooI8rKDnn0Xk2GWBmQHLnPjNvMTTIfHBg9JJ U73pqPIrWXY9rsLb0b0KMRyddtKzKp8O9mR2vdh2w074x1N2rp26ask5+smv+UaPRbSU WK1FHSu6tla8mpFUnkLFywI9gfMpXfTxqR9pB+Xy2DyUsw5byk84k2GlDzscZJ6R8mat Z0Obn/PMkMaWHE2h7Hls9ggUfm7woUj+GK+F5eKSo0C/cUYek/orRr1JYYH3hHZ+BgGS PS/50Qgg04pxYKFiE1+LUoaWqtBgx97c0HAECWi9RXhksb+zLHFY36s10LoJoln3i7kr tyEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:to:content-language:subject:user-agent:mime-version:date :message-id; bh=HZwsIhjtgSAmnia0/qaT3RxixpuiveiXDCzTc8KKHGA=; b=Igeu4kD1knfPnXdWWqeKY9X8bdEaDAPaq1AweVmrRS+wdpdKJJ6Dmv4b9K9mpo3KSd G69piHIsMx7Wgy3Bc0jkIe9cLb7/QLNTcoSVMbjs2ia7yz4ZoWjaXCo3oCIeqArxG1+f Hyne5XJ2FGpdJMePp+LIEv/AZDbsMzTGjNQjTmGBBHGDGGYU5Mn9Rlg5H0WIW9X4t8tp pufS/jHZm83vGNR0jhzxn6Xo2ykvA1yxCC8ZBe6crg2RaqicEzms7fKhda6UWBOtmuIa BkqHy+RTk324Sgy0pX0uHLww+wiKu4Wo4hlhm/zy9Vy8VNdz86NNy+f9Ieh+gFyIX4u1 mlXg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id c15-20020a62e80f000000b004fa662b24c0si3023733pfi.330.2022.03.25.10.41.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Mar 2022 10:41:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 5B04264BE5; Fri, 25 Mar 2022 10:28:54 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350282AbiCXMq1 (ORCPT + 99 others); Thu, 24 Mar 2022 08:46:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46790 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350305AbiCXMqP (ORCPT ); Thu, 24 Mar 2022 08:46:15 -0400 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0E8B93A5C1; Thu, 24 Mar 2022 05:44:37 -0700 (PDT) Received: by mail-pj1-f53.google.com with SMTP id bx5so4617842pjb.3; Thu, 24 Mar 2022 05:44:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=HZwsIhjtgSAmnia0/qaT3RxixpuiveiXDCzTc8KKHGA=; b=rUjQxZuaozbndvZ/yS5THFwiW+bZ5QuG4Lqq5dvYjTeIduF31GN/HtKtoOSvObcGAo dxEDvdqjRyvhT1gZZWnc79Cj9RfBY0uI6KyokvKyiG3iN0auNRSlBsU7+SKiwnoiIunr 6Z+Ke0kANGP9QVeoDOs4FGtloXeTEzsSPX0DiHdRUz4rs7H4HLbUwGf3Ne0H2qMCePGY 0TVItaZALuzobzeh+LLYhJUxofsJN9eJ//Ym9SjF1Y6lhU5+COo3KrZ7itFmZFiUCo2T sDgeuRYQmEToy3hS7qa6YZPfr9JXizPhQgSyT0bYUReW80Joq7hC+zDMlrOdZ7aQyHDx Q/+w== X-Gm-Message-State: AOAM531mhgGtLCssF6BmxMR0PqtWKk4vPE8ZqSgmOJgYPLmd2R0Kl1rR TZYgyP+/AkSPNyH+cHgEmEA= X-Received: by 2002:a17:903:3091:b0:153:9dcf:de71 with SMTP id u17-20020a170903309100b001539dcfde71mr5671611plc.7.1648125876217; Thu, 24 Mar 2022 05:44:36 -0700 (PDT) Received: from ?IPV6:2601:647:4000:d7:feaa:14ff:fe9d:6dbd? ([2601:647:4000:d7:feaa:14ff:fe9d:6dbd]) by smtp.gmail.com with ESMTPSA id 204-20020a6302d5000000b00385f29b02b2sm2669252pgc.50.2022.03.24.05.44.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Mar 2022 05:44:35 -0700 (PDT) Message-ID: <0034b2f8-0eba-f700-6fff-03cf5b8c8332@acm.org> Date: Thu, 24 Mar 2022 05:44:33 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] scsi: ufs: core: Remove unused field in struct ufs_hba Content-Language: en-US To: keosung.park@samsung.com, ALIM AKHTAR , "avri.altman@wdc.com" , "jejb@linux.ibm.com" , "martin.petersen@oracle.com" , "beanhuo@micron.com" , Daejun Park , "adrian.hunter@intel.com" , "cang@codeaurora.org" , "asutoshd@codeaurora.org" , "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <413601558.101648105683746.JavaMail.epsvc@epcpadp4> From: Bart Van Assche In-Reply-To: <413601558.101648105683746.JavaMail.epsvc@epcpadp4> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/24/22 00:01, Keoseong Park wrote: > Remove unused field "rpm_lvl_attr" and "spm_lvl_attr" in struct ufs_hba. > Commit cbb6813ee771 ("scsi: ufs: sysfs: attribute group for existing > sysfs entries.") removed all code using that field. > > Signed-off-by: Keoseong Park > --- > drivers/scsi/ufs/ufshcd.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h > index 88c20f3608c2..94f545be183a 100644 > --- a/drivers/scsi/ufs/ufshcd.h > +++ b/drivers/scsi/ufs/ufshcd.h > @@ -820,8 +820,6 @@ struct ufs_hba { > enum ufs_pm_level rpm_lvl; > /* Desired UFS power management level during system PM */ > enum ufs_pm_level spm_lvl; > - struct device_attribute rpm_lvl_attr; > - struct device_attribute spm_lvl_attr; > int pm_op_in_progress; > > /* Auto-Hibernate Idle Timer register value */ Reviewed-by: Bart Van Assche