Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20220321231548.14276-4-ansuelsmth@gmail.com>
References: <20220321231548.14276-1-ansuelsmth@gmail.com> <20220321231548.14276-4-ansuelsmth@gmail.com>
Subject: Re: [PATCH v6 03/18] clk: qcom: gcc-ipq806x: add PXO_SRC in clk table
From:   Stephen Boyd <sboyd@kernel.org>
To:     Andy Gross <agross@kernel.org>,
        Ansuel Smith <ansuelsmth@gmail.com>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Rob Herring <robh+dt@kernel.org>, devicetree@vger.kernel.org,
        linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date:   Thu, 24 Mar 2022 18:10:35 -0700
User-Agent: alot/0.10
Message-Id: <20220325011037.03173C340EC@smtp.kernel.org>
Precedence: bulk

Quoting Ansuel Smith (2022-03-21 16:15:33)
> PXO_SRC is currently defined in the gcc include and referenced in the
> ipq8064 DTSI. Correctly provide a clk after gcc probe to fix kernel
> panic if a driver starts to actually use it.
>=20
> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> ---

What is this patch about? clk providers shouldn't be calling clk_get().

>  drivers/clk/qcom/gcc-ipq806x.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>=20
> diff --git a/drivers/clk/qcom/gcc-ipq806x.c b/drivers/clk/qcom/gcc-ipq806=
x.c
> index 27f6d7626abb..7271d3afdc89 100644
> --- a/drivers/clk/qcom/gcc-ipq806x.c
> +++ b/drivers/clk/qcom/gcc-ipq806x.c
> @@ -26,6 +26,8 @@
>  #include "clk-hfpll.h"
>  #include "reset.h"
> =20
> +static struct clk_regmap pxo =3D { };
> +
>  static struct clk_pll pll0 =3D {
>         .l_reg =3D 0x30c4,
>         .m_reg =3D 0x30c8,
> @@ -2754,6 +2756,7 @@ static struct clk_dyn_rcg ubi32_core2_src_clk =3D {
>  };
> =20
>  static struct clk_regmap *gcc_ipq806x_clks[] =3D {
> +       [PXO_SRC] =3D NULL,
>         [PLL0] =3D &pll0.clkr,
>         [PLL0_VOTE] =3D &pll0_vote,
>         [PLL3] =3D &pll3.clkr,
> @@ -3083,6 +3086,10 @@ static int gcc_ipq806x_probe(struct platform_devic=
e *pdev)
>         if (ret)
>                 return ret;
> =20
> +       clk =3D clk_get(dev, "pxo");
> +       pxo.hw =3D *__clk_get_hw(clk);
> +       gcc_ipq806x_clks[PXO_SRC] =3D &pxo;
> +
>         regmap =3D dev_get_regmap(dev, NULL);
>         if (!regmap)
>                 return -ENODEV;
> --=20
> 2.34.1
>