Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <Yj1x5hJEKVL71JZ1@Red>
References: <20220321200739.3572792-1-clabbe@baylibre.com> <20220321200739.3572792-18-clabbe@baylibre.com> <20220325004125.C80FDC340EC@smtp.kernel.org> <Yj1x5hJEKVL71JZ1@Red>
Subject: Re: [PATCH v3 17/26] clk: rk3399: use proper crypto0 name
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     heiko@sntech.de, herbert@gondor.apana.org.au, krzk+dt@kernel.org,
        mturquette@baylibre.com, robh+dt@kernel.org,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-clk@vger.kernel.org, linux-crypto@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org
To:     LABBE Corentin <clabbe@baylibre.com>
Date:   Fri, 25 Mar 2022 09:52:38 -0700
User-Agent: alot/0.10
Message-Id: <20220325165240.C9A6DC2BBE4@smtp.kernel.org>
Precedence: bulk

Quoting LABBE Corentin (2022-03-25 00:40:22)
> Le Thu, Mar 24, 2022 at 05:41:23PM -0700, Stephen Boyd a =C3=A9crit :
> > Quoting Corentin Labbe (2022-03-21 13:07:30)
> >=20
> > $ git grep SRST_CRYPTO
> > Documentation/devicetree/bindings/crypto/rockchip-crypto.txt:          =
 resets =3D <&cru SRST_CRYPTO>;
> > arch/arm/boot/dts/rk3288.dtsi:          resets =3D <&cru SRST_CRYPTO>;
> >=20
> > Uh oh. Just don't change it and think about something else when it
> > starts to feel inconsistent.
>=20
> This is on rk3288, so not related to rk3399.
> Even on the RK3399 TRM, all crypto clocks are called either crypto0 or cr=
ypto1 (neither just crypto)
>=20

Ok. Please add a note in the commit text why it's OK to change the
define names.