Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Thu, 24 Mar 2022 17:46:18 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc:     Namjae Jeon <linkinjeon@kernel.org>,
        Sergey Senozhatsky <senozhatsky@chromium.org>,
        Steve French <sfrench@samba.org>,
        Hyunchul Lee <hyc.lee@gmail.com>, linux-kernel@vger.kernel.org,
        kernel-janitors@vger.kernel.org, linux-cifs@vger.kernel.org
Subject: Re: [PATCH v2] ksmbd: Remove a redundant zeroing of memory
Message-ID: <20220324144618.GQ3293@kadam>
References: <577b4601aa5d62d222fa9387c5036f2504f40318.1648017112.git.christophe.jaillet@wanadoo.fr>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <577b4601aa5d62d222fa9387c5036f2504f40318.1648017112.git.christophe.jaillet@wanadoo.fr>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?xtAmEosDKPAFhhSEdV7JX4WNMX/go8b82TFYxZ9HakLBuSB90x5pMwQ29c0A?=
 =?us-ascii?Q?pi/mqqoCiCzKpAcKgEiGs/RSzL6Qd/HsOhsoiuMzbqCA+rHoCY4/buok01cB?=
 =?us-ascii?Q?RsDfXhTH/r5yEtJMJ56fPI7r4Z1UD8VPXJblCKTqweG/05kfsF1D/keLk8NV?=
 =?us-ascii?Q?8x8MoeEAEuG5wR2mUcl4Mm6I/snMt+apTWO1KKxGJiKk8SUfxWA/015bkazn?=
 =?us-ascii?Q?M7w0fUr02CyXaZnF6qq3soCSAmkF+fZLDf2d+5XzRQT1S/GOCPXkvtXTH5Ux?=
 =?us-ascii?Q?u9SNqyglqCBu8+6tF8zzJ1sc00ksh/P8wmhYUezQDC6POtwcS0uqRCtRy8e8?=
 =?us-ascii?Q?kT/R1CrouTyU2qmJ4Sh2EsrIeI46TH/0Sj9R91Hi7+J29S0AiYaysx6AkvB1?=
 =?us-ascii?Q?z5ivamwgGITJ/jnVLhCnuuqjxRegsmYOI4rIGJS3Vo82zUcN+rTuu6RRLWoF?=
 =?us-ascii?Q?uvOLpQM+ujm2LcnURFUtWYInXWE1ZfVrMoPQyIfBfuPCnOc8kSBsDUWzZR0A?=
 =?us-ascii?Q?Y6Q8l01SsP0WBx2XWoHhN3bfMgukIR063UZ8+d7JFZ0UGAfQY+ZPUQvETyNm?=
 =?us-ascii?Q?xcm9qnPEFgzRaexzRvKKOM8jkW+kmUkosmT2hwjzRD+UU+eeFJvUyjgM7XhF?=
 =?us-ascii?Q?IoXHDFnF4OsiAnMksxu7j5LK7RqwSaO8K4R9NBqZkTi6gmyLfyaIM0z5FN4U?=
 =?us-ascii?Q?pgKxPnGsceI0BBeIqgIGRpxOZGindAnQSaEFpyccg7BWNxyKv5A3XCOw+99V?=
 =?us-ascii?Q?NU9aKu+7++sr+e4TUWv1cvA9VL1a2s6sGnEs+2GxbPxGJIy8ePS75ITE2yVW?=
 =?us-ascii?Q?zFAMDcfDqEP6DFsjHrFD3d36AYF1lDBvPJsmBfimjuzb5YREzk9DMu4/fgMC?=
 =?us-ascii?Q?Wo+oAS80j+g6wyZwRymE5x2yDwOl/Wg5NTqj3KgT7aDfSU7d6FKVlbHCaMKw?=
 =?us-ascii?Q?FOQ2JLiSzih/qKDFcusEQJsmsRsF3yWhjgFbc2Sr1EujLmhJbIhF4FD9Z5IT?=
 =?us-ascii?Q?aYgY0LCun6B+VlVheAlD59++wh1DbGQSCxivp+T77lofiaD7vzCmED+Rnqix?=
 =?us-ascii?Q?0TUBb7kTA3pngCE3W6wz9haFtbmFPhxOGhMGjaOilJYrhobR5Q5o24pmsJsT?=
 =?us-ascii?Q?FshS8zMAUDFKc2aN0WbkmybqHlmmlmJIAEO717eNlNRkPi7dXRqkKEnYN/Zu?=
 =?us-ascii?Q?iEVZau2XP8ZxNaJl6H7VU8naiw2v47vJjBVn/8TV0sdEGHR+P1enAYgUmDsm?=
 =?us-ascii?Q?Y2WS3S5x8MYqCADzmaa7HDeXhNy/UvamgnNwvLqLYIznLMK7tZ3f4OrvHN0b?=
 =?us-ascii?Q?pM10T2/62yCJtHVsv+HmrVS5/+NDyA97vmenZF3BOhxjyCqo0NOIOMtpwr5e?=
 =?us-ascii?Q?8uIwR9Nk5dmIIOcGUiH19JPLvXxe9TDxdvXIPC91S/v1UWzGcoLYygqsYVud?=
 =?us-ascii?Q?/ImdiFysJxfdL8E8oM3adhhsb8uNKoen7fymfVPxJ4+XbD7bib2MKQ=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b2e4790c-9100-4e70-eae8-08da0da519f2
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2022 14:46:38.4805
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bKy3/X1ZZUJv12lXlLQpWw57O8cM3iAZnf2V0Z9nGqYCXHpDnXQ6lWbjpFziY0PrFUI3fqq4TjlF9clCKguLv7UeAYW0PagNcZlqBQaHx40=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3557
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10295 signatures=694973
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 phishscore=0
 mlxlogscore=748 adultscore=0 suspectscore=0 malwarescore=0 spamscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2203240084
X-Proofpoint-GUID: Wod73xKs0CalmrldyXG0VJYi2Y60RDQh
X-Proofpoint-ORIG-GUID: Wod73xKs0CalmrldyXG0VJYi2Y60RDQh
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Mar 23, 2022 at 07:32:05AM +0100, Christophe JAILLET wrote:
> fill_transform_hdr() has only one caller that already clears tr_buf (it is
> kzalloc'ed).
> 
> So there is no need to clear it another time here.
> 
> Remove the superfluous memset() and add a comment to remind that the caller
> must clear the buffer.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> v2: keep kzalloc in the caller and remove the memset here

I kind of prefered v1.  I misread the code and was looking at the wrong
fill_transform_hdr() function from the other driver.

regards,
dan carpenter