Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp2106671pxb; Fri, 25 Mar 2022 11:11:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwOrUnjJHLFSCf18Tbz/EJ8Er1XQ5+7mcd3FRmuTbxk52P9TkDL6B/X7wu5JGX3mZZj7IZC X-Received: by 2002:a17:90b:4c08:b0:1c7:61ce:b707 with SMTP id na8-20020a17090b4c0800b001c761ceb707mr14204710pjb.16.1648231915700; Fri, 25 Mar 2022 11:11:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648231915; cv=none; d=google.com; s=arc-20160816; b=f7oJDxeX+Oc3WeargLbsW+wBf44mdf1ZUdAizMMdD3urZlAGKB0w6bHv0dZcCEwCG2 tbpCW9cFk1xq1vaFgf3c2vrUDCjIFYCL5x6qkgMXdCqbWs0Y4zVYuGycqMPyIQZz6MeJ zWuYdyd3j/odDeJrUNMP7FXt002my7c+QuKoZwnHZyrxx6KM8M4hvRLRHd5Vhftv0ipK ecEoljmdvxnBa75zPwFd10/Ke7HsLtGeNNJwjmALkL6z2VqeI9y4mCI47UiodDcKa9z+ EFJR09hT0O6prWcBAHJnHw2m6hZAmFOd/UmXum4emtWHFfE2KBBGYtCN2tZxoFC50Hqz r9GQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=cA9NIwi2i9i243BvwY18uG4zJ77cV824LqyzTeSEWVk=; b=ztwYg6SQa7qrE+LhcqfxYxYoD3KUGDyc/RFyz3naaXrbLZh4I/Blb8cFh+JnZq6LEg t/Iig0p5cTo1V137QVc2lmYqM1+SziWjfJipeMwh5VgUekwZSuL50ibrMUc/ToFNbGPs /nvSycWbYx23jxX/Yrkkl26PB0dhf9LU0iHQn4DmxmytvtxJ/yTaiVXJFEDkfiysaTAx RQ8yh+8JSNOUHRI2NGtzBkZJulXHJnheo5Z3lZfr2dA2RvnC1qPfwEyI3V+aqwAPWMWl f5DHX7phXZQWfspuITGmM7/dU1LY8d7dKoJwhHlLZj8DYN1lLvaPSz9XOVN9OcNZrWTS gUmw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="fq/QMjkv"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id q7-20020a17090311c700b001544764a235si3342777plh.522.2022.03.25.11.11.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Mar 2022 11:11:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="fq/QMjkv"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 557C5EB4; Fri, 25 Mar 2022 10:43:36 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244214AbiCXM1p (ORCPT + 99 others); Thu, 24 Mar 2022 08:27:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50744 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235644AbiCXM1o (ORCPT ); Thu, 24 Mar 2022 08:27:44 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2DA318CCE9; Thu, 24 Mar 2022 05:26:12 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id CAEA2B82258; Thu, 24 Mar 2022 12:26:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E3F45C340EC; Thu, 24 Mar 2022 12:26:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1648124769; bh=I2cvejvvU5c4WuedgFx5yUyKh6RW99LNnSTXQFJ3M5o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fq/QMjkvfFoV+2nA0jKO67K94gmzicWcevUnKx3Dv8c5YHCL7g9tUkFU0VuY0YehP 8O0Hbqgf0HvG71RI51LZ4w5Wso+eaEWRXt6czhu6KdR2E4zwHqphxCWM0d8du3T6Wc R4Psi9HYaEAGarxFh4FlFJqxj4WZClaB7ctMlNHI= Date: Thu, 24 Mar 2022 13:26:06 +0100 From: Greg Kroah-Hartman To: Mao Jinlong Cc: Mathieu Poirier , Suzuki K Poulose , Alexander Shishkin , Mike Leach , Leo Yan , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Tingwei Zhang , Yuanfang Zhang , Tao Zhang , Trilok Soni , Hao Zhang , linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v4 01/10] Use IDR to maintain all the enabled sources' paths. Message-ID: References: <20220324121734.21531-1-quic_jinlmao@quicinc.com> <20220324121734.21531-2-quic_jinlmao@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220324121734.21531-2-quic_jinlmao@quicinc.com> X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 24, 2022 at 08:17:25PM +0800, Mao Jinlong wrote: > Use hash length of the source's device name to map to the pointer > of the enabled path. Using IDR will be more efficient than using > the list. And there could be other sources except STM and CPU etms > in the new HWs. It is better to maintain all the paths together. > > Signed-off-by: Mao Jinlong > --- > drivers/hwtracing/coresight/coresight-core.c | 75 +++++++------------- > 1 file changed, 26 insertions(+), 49 deletions(-) Your subject line is odd. Please put back the driver subsystem in the subject line so that it makes more sense. And how have you measured "more efficient"? thanks, greg k-h