Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp2109598pxb; Fri, 25 Mar 2022 11:15:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyAf1uDNhdbBeVOP2bmT5xe6HHABjxlE3UvPKMzoCJpZAUsCcNKAV2L+dWOnFIRbXpaHVmX X-Received: by 2002:a17:903:32ce:b0:154:4a39:294d with SMTP id i14-20020a17090332ce00b001544a39294dmr12875401plr.48.1648232103079; Fri, 25 Mar 2022 11:15:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648232103; cv=none; d=google.com; s=arc-20160816; b=MmA038RE9AeUMuS4dld3q+VKi6/qANLBvLDyA9qBaOIS/hRMsSzFceOighKKOzqLzV 0Axvk0SN2gnIzReOPck59tArdep21FdxA4VdyTWfgrnyusu/04PHO3hXiWOFxaSA69lm kA4V3jXsmCGcDP+3MQhnjENsPrJoKNRYX5CHAILMI/CPvTbe5tVY2RWr5U6CIetBXSw/ knjLnbLmXau2a5KCjwvJLdTdxX4KDbzTPuVRryxWWxJltly1Qv1QoVre+WSNY+OcrbtI WCBbJ8wj34XIgr7YMlgkPeyZ9iztjT+JGpfKuKAFVkXSPUDflTuRRIc/p+Rg6WIhv2+c bPuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=dt8vhtKiPbsbCcDg8xMi/AmQ4OjbxYDQR91N6G2Nv8U=; b=0bDxQA/jcBIzVadJzn8lq12qFqpKsM0Q/YetQDVC1LjAJO96blJL6kmAkGhTRM6U+u OKac/4hLhJJwgZB9MRI41PEeDPBA71m1TQPnCROHxkLXvqZgcM04iA5aGvNdCPgukAOp AKZ/arQC7aAJAZzXJ1qitJYthyD/MV3OTa0iWZ+Z7iK4WGeQ5KVIBSFEORJD1hMFIuRJ nubqvaKvfd+yxfTmoNewd5KVz0rvnX03fCc14eV1zZ1ybftHBhLwHxdlk1GG/FUysWD2 teif7ydycrg3P37KV9NgH7lLpigLsBHkmCOifQVjlLRpTqghUMwzTCLB+chNYnL2384D fzOg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=eP8Y1tjZ; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id d125-20020a633683000000b00382b76401ecsi2882530pga.268.2022.03.25.11.15.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Mar 2022 11:15:03 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=eP8Y1tjZ; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 5595D14D7A8; Fri, 25 Mar 2022 10:44:28 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231443AbiCYQDx (ORCPT + 99 others); Fri, 25 Mar 2022 12:03:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57554 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1376725AbiCYQDs (ORCPT ); Fri, 25 Mar 2022 12:03:48 -0400 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA7E5A0BE0 for ; Fri, 25 Mar 2022 09:02:13 -0700 (PDT) Received: by mail-ej1-x631.google.com with SMTP id qx21so16219827ejb.13 for ; Fri, 25 Mar 2022 09:02:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dt8vhtKiPbsbCcDg8xMi/AmQ4OjbxYDQR91N6G2Nv8U=; b=eP8Y1tjZ6Fdx7y7CstaqPOR2P+1OEINFk5F6Bwa9lUeoWBBkhaHuJtY6k8zbPtWyCg f7XoErNmsZauAx5rC9HMwlTYgDfa3BqTJA0Cv1TAsGrAi8mQsFjLR08Enal2k/SCXm5B aUCn20OP1arKyyd9nvLs9BSAsuWvEvzBmoP06jeVWquGZvlVHOfV2RjVYj2xx8jyp/JN 3Unv+3DTQsp3tzz0yV2O26ZTcjFz1Q5zv0HXS3E2N071d3WYozi3OD12Dobq3GBagrAH JlDoZBVgf8+uvzc8H5aGLis/dw8UzksD2rlTlEq19nCuo+U20FfMPH6sO+7D7qq2QMqy incw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dt8vhtKiPbsbCcDg8xMi/AmQ4OjbxYDQR91N6G2Nv8U=; b=nQZuAW7Z+k9ORlk6twVmbxJFzJeGRcO3QqBIK5OirZvxFxo0NJRReDPEa3waNY+wA6 OoC0ho50C4l0+8fU5WgskH0l9B2jrit68Mqf88qP54QCQtzZzW8CtbAuiTuo22jeSVus QkhDUDCYjdSzYnSGeajLfphWaQ/BJpa9HwkNG2NIRqzA8746A3D5o/jHn/wMqxg006jh WwqXvmhl63mNMQ58Kj12dTMKsPaw44JnVeqe2QpG7ty/HDh/OT4ehsebRzIOF934j6P8 P422Pw3UNtGxFHcqXVtSRwFYfp4dhOeZ/dFivKL6YdWhQzuoQErkG9Emy3yeJvy4y9Yu U9pg== X-Gm-Message-State: AOAM532gACZzFUY/SbjS4Ose+16vqkjQwnbLhViUisLA2f08O0oh4JQl LiNxQ+EzqSm5uVYPoE4fZxJMjUh8xTqTmlEu2bwAIw== X-Received: by 2002:a17:906:7307:b0:6da:92db:c78f with SMTP id di7-20020a170906730700b006da92dbc78fmr12327012ejc.35.1648224132413; Fri, 25 Mar 2022 09:02:12 -0700 (PDT) MIME-Version: 1.0 References: <20220308065754.3355-1-peng.fan@oss.nxp.com> <20220324151132.GA3514576@p14s> In-Reply-To: From: Mathieu Poirier Date: Fri, 25 Mar 2022 10:02:00 -0600 Message-ID: Subject: Re: [PATCH V2] remoteproc: imx_rproc: Ignore create mem entry for resource table To: Peng Fan Cc: "Peng Fan (OSS)" , "bjorn.andersson@linaro.org" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "kernel@pengutronix.de" , "festevam@gmail.com" , dl-linux-imx , "linux-remoteproc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 24 Mar 2022 at 20:02, Peng Fan wrote: > > Hi Mathieu, > > > Subject: Re: [PATCH V2] remoteproc: imx_rproc: Ignore create mem entry for > > resource table > > > > On Tue, Mar 08, 2022 at 02:57:54PM +0800, Peng Fan (OSS) wrote: > > > From: Peng Fan > > > > > > Resource table will not be used for memory allocation, no need to > > > create rproc mem entry. > > > > > > Fixes: b29b4249f8f0c ("remoteproc: imx_rproc: add i.MX specific parse > > > fw hook") > > > > > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Felixir.b > > ootlin.com%2Flinux%2Fv5.17%2Fsource%2FDocumentation%2Fprocess%2Fsu > > bmitting-patches.rst&data=04%7C01%7Cpeng.fan%40nxp.com%7Cae62 > > e633010048f972db08da0da89836%7C686ea1d3bc2b4c6fa92cd99c5c301635 > > %7C0%7C1%7C637837315009092474%7CUnknown%7CTWFpbGZsb3d8eyJW > > IjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C > > 3000&sdata=Xod3YxSRW8h2WXdnpu1WX4DzRpCTnYE9gVlt9HXMlnU%3 > > D&reserved=0 > > Sorry, I could not get your point of which part conflicts with the patch rules. > Please clarify and I'll improve. The commitID in the "Fixes" tag should be 12 characters rather than 13 as you have above. > > Thanks, > Peng. > > > > > > > > > Signed-off-by: Peng Fan > > > --- > > > > > > V2: > > > Add Fixes tag > > > Separate the patch from > > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatc > > > > > hwork.kernel.org%2Fproject%2Flinux-remoteproc%2Fpatch%2F20220111033 > > 333 > > > .403448-7-peng.fan%40oss.nxp.com%2F&data=04%7C01%7Cpeng.fan > > %40nxp. > > > > > com%7Cae62e633010048f972db08da0da89836%7C686ea1d3bc2b4c6fa92cd > > 99c5c301 > > > > > 635%7C0%7C1%7C637837315009092474%7CUnknown%7CTWFpbGZsb3d8e > > yJWIjoiMC4wL > > > > > jAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&am > > p;sdata > > > > > =CYL9grwXHpUud4qpzFAEijOWv%2BehvefwyZ4aU02wJnw%3D&reserv > > ed=0 > > > Address typo > > > > > > drivers/remoteproc/imx_rproc.c | 3 +++ > > > 1 file changed, 3 insertions(+) > > > > > > diff --git a/drivers/remoteproc/imx_rproc.c > > > b/drivers/remoteproc/imx_rproc.c index 7a096f1891e6..f2bfc9077c19 > > > 100644 > > > --- a/drivers/remoteproc/imx_rproc.c > > > +++ b/drivers/remoteproc/imx_rproc.c > > > @@ -423,6 +423,9 @@ static int imx_rproc_prepare(struct rproc *rproc) > > > if (!strcmp(it.node->name, "vdev0buffer")) > > > continue; > > > > > > + if (!strncmp(it.node->name, "rsc-table", strlen("rsc-table"))) > > > + continue; > > > + > > > rmem = of_reserved_mem_lookup(it.node); > > > if (!rmem) { > > > dev_err(priv->dev, "unable to acquire memory-region\n"); > > > -- > > > 2.30.0 > > >