Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Wed, 23 Mar 2022 08:37:49 +0530
From:   Pavan Kondeti <quic_pkondeti@quicinc.com>
To:     Mathias Nyman <mathias.nyman@linux.intel.com>
CC:     "Sandeep Maheswaram (Temp)" <quic_c_sanm@quicinc.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Mathias Nyman <mathias.nyman@intel.com>,
        Felipe Balbi <balbi@kernel.org>,
        Stephen Boyd <swboyd@chromium.org>,
        "Doug Anderson" <dianders@chromium.org>,
        Matthias Kaehlcke <mka@chromium.org>,
        "Pawel Laszczak" <pawell@cadence.com>,
        Peter Chen <peter.chen@kernel.org>,
        "Roger Quadros" <rogerq@kernel.org>,
        Aswath Govindraju <a-govindraju@ti.com>,
        <linux-arm-msm@vger.kernel.org>, <linux-usb@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <quic_pkondeti@quicinc.com>,
        <quic_ppratap@quicinc.com>
Subject: Re: [PATCH v2 0/3] Refactor xhci quirks and plat private data
Message-ID: <20220323030749.GO23316@hu-pkondeti-hyd.qualcomm.com>
References: <1646130507-26796-1-git-send-email-quic_c_sanm@quicinc.com>
 <ddc86a4f-8d1c-c02c-5600-4fa851568557@quicinc.com>
 <YjR0Ne3BDxxMfrxt@kroah.com>
 <b38ddfcc-68c3-d99f-816b-8b9f788aa88a@quicinc.com>
 <29ba84fb-1db2-1d84-cf9e-191e9bcbf739@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <29ba84fb-1db2-1d84-cf9e-191e9bcbf739@linux.intel.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Precedence: bulk

Hi Mathias,

On Tue, Mar 22, 2022 at 05:53:42PM +0200, Mathias Nyman wrote:
> On 21.3.2022 8.21, Sandeep Maheswaram (Temp) wrote:
> > Hi Mathias,
> > 
> > On 3/18/2022 5:29 PM, Greg Kroah-Hartman wrote:
> >> On Thu, Mar 17, 2022 at 11:17:17AM +0530, Sandeep Maheswaram (Temp) wrote:
> >>> Hi Greg,
> >>>
> >>> On 3/1/2022 3:58 PM, Sandeep Maheswaram wrote:
> >>>> changes in v2:
> >>>> Added a PATCH 2/3 to remove unwanted header inclusion.
> >>>> Fixed minor nitpicks in PATCH 3/3.
> >>>>
> >>>> Pavankumar Kondeti (1):
> >>>> ??? usb: xhci: refactor quirks and plat private data
> >>>>
> >>>> Sandeep Maheswaram (2):
> >>>> ??? usb: xhci: Remove unwanted header inclusion
> >>>> ??? usb: dwc: host: add xhci_plat_priv quirk XHCI_SKIP_PHY_INIT
> >>>>
> >>>> ?? drivers/usb/cdns3/host.c??????? |? 2 +-
> >>>> ?? drivers/usb/dwc3/host.c???????? | 13 ++++++++
> >>>> ?? drivers/usb/host/xhci-plat.c??? |? 3 +-
> >>>> ?? drivers/usb/host/xhci-plat.h??? | 24 ---------------
> >>>> ?? drivers/usb/host/xhci-rcar.c??? |? 3 +-
> >>>> ?? drivers/usb/host/xhci.h???????? | 60 ++++--------------------------------
> >>>> ?? include/linux/usb/xhci-plat.h?? | 24 +++++++++++++++
> >>>> ?? include/linux/usb/xhci-quirks.h | 67 +++++++++++++++++++++++++++++++++++++++++
> >>>> ?? 8 files changed, 115 insertions(+), 81 deletions(-)
> >>>> ?? delete mode 100644 drivers/usb/host/xhci-plat.h
> >>>> ?? create mode 100644 include/linux/usb/xhci-plat.h
> >>>> ?? create mode 100644 include/linux/usb/xhci-quirks.h
> >>> Please let me know your opinion about this patch series.
> >> I need the xhci maintainer to review it...
> >>
> >> thanks,
> >>
> >> greg k-h
> > 
> > 
> > Can you please review this patch series.
> > 
> 
> I don't have a better solution than this.
> 
> So neither devicetree or ACPI entries exists for the xHC part of this dwc3 controller?
> 
> A pure platform device is created, and it matches and binds to xhci-plat driver by "xhci-hcd" name.
> I guess we have no way to identify this dwc3 xhci controller in xhci-plat.c, and set quirks there,
> like all those devicetree xhci devices that we set quirks based on .compatibility. 
> 
Thanks for the review. Yes, xhci-plat platform device is created by the DWC3
driver for the controllers that needs to be operated in the host.

Thanks,
Pavan