Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030419AbXBZSaZ (ORCPT ); Mon, 26 Feb 2007 13:30:25 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030417AbXBZSaZ (ORCPT ); Mon, 26 Feb 2007 13:30:25 -0500 Received: from agminet01.oracle.com ([141.146.126.228]:36825 "EHLO agminet01.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030419AbXBZSaY (ORCPT ); Mon, 26 Feb 2007 13:30:24 -0500 Date: Mon, 26 Feb 2007 09:26:44 -0800 From: Randy Dunlap To: Sergei Shtylyov Cc: linux-pci@atrey.karlin.mff.cuni.cz, Adrian Bunk , Andrew Morton , Jeff Garzik , linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: 2.6.20-rc4-mm1: PCI=n: drivers/net/3c59x.c compile error Message-Id: <20070226092644.aea76b37.randy.dunlap@oracle.com> In-Reply-To: <45E2DF13.9010200@ru.mvista.com> References: <20070111222627.66bb75ab.akpm@osdl.org> <20070124135354.GI17836@stusta.de> <45B76946.1070009@ru.mvista.com> <45D756D7.4060106@ru.mvista.com> <45D75853.1060607@ru.mvista.com> <45E2DF13.9010200@ru.mvista.com> Organization: Oracle Linux Eng. X-Mailer: Sylpheed 2.3.1 (GTK+ 2.8.10; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Whitelist: TRUE X-Whitelist: TRUE X-Brightmail-Tracker: AAAAAQAAAAI= Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2365 Lines: 55 On Mon, 26 Feb 2007 16:22:27 +0300 Sergei Shtylyov wrote: > Hello, I wrote: > > >>>> 3x59x-fix-pci-resource-management.patch causes the following compile > >>>> error with CONFIG_PCI=n: > > >>>> <-- snip --> > > >>>> ... > >>>> CC drivers/net/3c59x.o > >>>> /home/bunk/linux/kernel-2.6/linux-2.6.20-rc4-mm1/drivers/net/3c59x.c: > >>>> In function 'vortex_init_one': > >>>> /home/bunk/linux/kernel-2.6/linux-2.6.20-rc4-mm1/drivers/net/3c59x.c:961: > >>>> error: implicit declaration of function 'pci_request_regions' > >>>> /home/bunk/linux/kernel-2.6/linux-2.6.20-rc4-mm1/drivers/net/3c59x.c:985: > >>>> error: implicit declaration of function 'pci_release_regions' > >>>> make[3]: *** [drivers/net/3c59x.o] Error 1 > > >>> Grr, at at the same time it's happy with pci_enable_device(). > >>> I'd say the problem is in , not in the patch. > > >> Has there been any patch to fix the "unbalanced" > >> pci_{request|release}_regions() declarations? Am I suposed to create > >> such? > > > Alternatively, vortex_{init|remove_one() and struct pci_driver there > > could have been put under #ifdef CONFIG_PCI (good idea anyway -- should > > reduce driver size on non-PCI systems)... > > I wonder if I may count on any feedback on this -- asking linux-pci now... > The issue is as follows: with my patch pci_{request|release}_regions() may > be called with CONFIG_PCI=n (probably, this never has been a issue before) but > don't have them declared in this case -- unlike > pci_enable_device() which is just empty for CONFIG_PCI=n. > Now, what kind of approach do I take: > > - a "fair one", so that pci_{request|release}_regions() get "balanced" > declarations in the header like pci_enable_device(); > > - a "local one" (and even saving non-PCI kernel from needless bloat), i.e. > #ifdef out functions that are only meaningful with CONFIG_PCI=y)? > > I'm leaning to the second now... I'd prefer the fair one -- add stubs to include/linux/pci.h. --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/