Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp2135523pxb; Fri, 25 Mar 2022 11:43:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwUkCnOAqAjYotRgwe0f9pNfCag9XZALs+mFXtrNcIHGXJp/bzQTYFfYLj81ob11JVs1QSB X-Received: by 2002:a17:902:b185:b0:14f:2d94:184 with SMTP id s5-20020a170902b18500b0014f2d940184mr13216406plr.56.1648233786600; Fri, 25 Mar 2022 11:43:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648233786; cv=none; d=google.com; s=arc-20160816; b=bzuGp7C/DZ9TjGIuSQdii1jLH5L7ELy6lcDKctivUGjRisUd+ZvSQmEEl/jMLjXJdf 5Ub3Qzesw7IF9UPHLd3gf/zwp2RJLwU1MQ2BJLMI8/U7fATYgqiUhlAZfONUgC5WuqOt Xzu9LCJ6d2tbacqmc5M2YcB5cb6+/10evvit7hyXOl7A8z9NUPUReqQ05XUsFjj6zH/+ ixX91dt5ff9OFiaSbc8O4kdq/m4cgd8jXuHjoEdvF6X4PM94fiooGZIu3FqX4jh9vvj2 ysUZLnIX7BrmNprw+Yx0NPEq2jbrjrNFRJxZDvu8XMP20eBpqw84tK/9gbWklufXz1hZ Bh3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Q+wJi6qwvOm1r3gx4t9QFKOneXZsav/Fvj23R1aQp1A=; b=OMnn60e9Y9DAC24erXSaGilRfoZY//4ZhmI5YAJo/QZ3KQGfQeYGcnzijTuRqAfWrL U4xD5uzNNLJnkYpOMI4uS+Maflk/pISctsMe//krH3n7+MmaGxf8nPWHujSZ0h+UrPwk cLmtVtWYyOpZeZ+otD7u43UsZQLAN547x7Ot2/EmYgyFvdTZTkK4AHmeUMem/fJUVCxk VC6avt/tcY3QIKHMc3TYVcUtEY6yxopQjrcrsmxfxkN5wF8nQuBbXkQNaVI9aE3aanjp t9NvyGKye4ps3JMSgYTxR38R+M5uAUdMHLd+jaueYEFRUvsvpsxL878sp1f1R3aXXcqx s+Tg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=desiato.20200630 header.b=Cb9OzTZs; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id j9-20020a170902758900b00153b2d1647asi3058046pll.130.2022.03.25.11.43.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Mar 2022 11:43:06 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=desiato.20200630 header.b=Cb9OzTZs; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9C35519F444; Fri, 25 Mar 2022 10:59:35 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354975AbiCYIa4 (ORCPT + 99 others); Fri, 25 Mar 2022 04:30:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32774 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1355049AbiCYIau (ORCPT ); Fri, 25 Mar 2022 04:30:50 -0400 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6494417E14 for ; Fri, 25 Mar 2022 01:29:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Q+wJi6qwvOm1r3gx4t9QFKOneXZsav/Fvj23R1aQp1A=; b=Cb9OzTZsoQFeB0Qh57eumaahAN UsWCGhjolARqgAGvSrwVVQlUkb/kxCyMWCXU9X0AFcbgLFo6bYhrWT4X1+/U08cEiWQ+blRQGz2o2 8GPd55VmAOqLxleQ6EPox6CgPeItPDH+WAAbS2t98Zp++vaLh647UmcuXq+ZUsWexBwYG/9UAhg8C uooivwsK5TS9E9zWP+qL6yJSObiBbII4gv8ci38iiiMPyLvbyL3aBkVq0OvQT/bFQRj9wGhvvKwqn 6h3L3Ue6cFrasGf1AtHHVLhQrcjODGLevcdVamB5MxeJBNw7Ch3SaUTsPFaKCEtKdT3cEHFWWHGOR xyLG0DbQ==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=worktop.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nXfJZ-004K0e-6l; Fri, 25 Mar 2022 08:28:57 +0000 Received: by worktop.programming.kicks-ass.net (Postfix, from userid 1000) id 7843D9862A6; Fri, 25 Mar 2022 09:28:55 +0100 (CET) Date: Fri, 25 Mar 2022 09:28:55 +0100 From: Peter Zijlstra To: Stephane Eranian Cc: linux-kernel@vger.kernel.org, kim.phillips@amd.com, acme@redhat.com, jolsa@redhat.com, songliubraving@fb.com, rafael@kernel.org, ravi.bangoria@amd.com, Sandipan.Das@amd.com Subject: Re: [PATCH v7 00/13] perf/x86/amd: Add AMD Fam19h Branch Sampling support Message-ID: <20220325082855.GL8939@worktop.programming.kicks-ass.net> References: <20220322221517.2510440-1-eranian@google.com> <20220324145902.GG8939@worktop.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 24, 2022 at 10:31:38PM -0700, Stephane Eranian wrote: > On Thu, Mar 24, 2022 at 7:59 AM Peter Zijlstra wrote: > > > > On Tue, Mar 22, 2022 at 03:15:04PM -0700, Stephane Eranian wrote: > > > V7 makes the following changes: > > > - rebased to 5.17-rc8 > > > - Restrict BRS to be used only with RETIRED_TAKEN_BRANCH event in order to > > > avoid adding more skid to other events in case that are monitored > > > concurrently > > > - fixed bugs in the perf tool enhanced error handling for IBS and BRS > > > > But afaict you failed to pick up the build fixes I did in my tree :/ Let > > me try and be careful preserving those while munging this in. > > Sorry. I missed that. I can resubmit if you prefer. Nah, fixed it up again.. Even converted to static_call() this time. Could you please test this branch? https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git/log/?h=perf/amd I've since done more Changelog edits, and I should do a comment with the static_call_mod() usage, but I think this ought to work. At least it now actually builds...