Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <3cfc4346d314dbb297841a9caf4e68661013016c.camel@pengutronix.de>
Subject: Re: [PATCH 2/2] reset: add support for fwnode
From:   Philipp Zabel <p.zabel@pengutronix.de>
To:     =?ISO-8859-1?Q?Cl=E9ment_L=E9ger?= <clement.leger@bootlin.com>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Frank Rowand <frowand.list@gmail.com>,
        Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Allan Nielsen <allan.nielsen@microchip.com>,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Date:   Thu, 24 Mar 2022 10:39:47 +0100
In-Reply-To: <20220324101929.00f51f01@fixe.home>
References: <20220323095022.453708-1-clement.leger@bootlin.com>
         <20220323095022.453708-3-clement.leger@bootlin.com>
         <ba95a3fec9c726e2cd61665ac5d7f89d16232d60.camel@pengutronix.de>
         <20220323172121.220a26e9@fixe.home> <20220324101929.00f51f01@fixe.home>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
User-Agent: Evolution 3.38.3-1 
MIME-Version: 1.0
Precedence: bulk

Hi Clément,

On Do, 2022-03-24 at 10:19 +0100, Clément Léger wrote:
> Le Wed, 23 Mar 2022 17:21:21 +0100,
> Clément Léger <clement.leger@bootlin.com> a écrit :
> 
> > > >         if (id) {
> > > > -               index = of_property_match_string(node,
> > > > -                                                "reset-names",
> > > > id);
> > > > +               index = fwnode_property_match_string(fwnode,
> > > > "reset-names", id);
> > > >                 if (index == -EILSEQ)
> > > >                         return ERR_PTR(index);    
> > > 
> > > I don't think this is good enough any more. At least -ENOMEM is added
> > > as a possible error return code by this change.  
> > 
> > Yes indeed, errors are clearly not correctly handled anymore. At least
> > -EILSEQ won't be triggered.
> > > 
> 
> By the way, even after looking at this more carefully, I'm not sure to
> understand why there is a special handling for -EILSEQ ? From what I
> understand, EILSEQ is returned in case the device tree is malformed
> (string longer than returned property length) but why is it handled
> differently in this case ?

of_property_match_string() can return four error codes:

  -EINVAL (no reset-names property in node)
  -EILSEQ (real error)
  -ENODATA (id is not found in reset-names)
  -ENOSYS (CONFIG_OF is not set)

-EINVAL, -ENODATA and -ENOSYS map to -ENOENT (no reset control
corresponding to id found), or no error if it is optional.

regards
Philipp