Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <31759627-1754-8d5d-6d6a-df3010d3e8e0@amd.com>
Date:   Wed, 23 Mar 2022 20:54:20 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.1.0
Subject: Re: [PATCH 1/1] x86/amd_nb: unexport amd_cache_northbridges()
Content-Language: en-US
To:     Borislav Petkov <bp@alien8.de>
Cc:     x86@kernel.org, linux-kernel@vger.kernel.org,
        linux-edac@vger.kernel.org, mingo@redhat.com, mchehab@kernel.org,
        airlied@linux.ie, Muralidhara M K <muralimk@amd.com>
References: <20220228161154.54539-1-nchatrad@amd.com>
 <YjDMvYOh8Vizq4xv@zn.tnic>
From:   "Chatradhi, Naveen Krishna" <nchatrad@amd.com>
In-Reply-To: <YjDMvYOh8Vizq4xv@zn.tnic>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bEdRZGNVQ0dDQkRSUDFuUmZhOTZOdUZwTkh4YmMwMjJwUGNGdTRtZUpyNit0?=
 =?utf-8?B?TExKaXY3ZktCSjh5dHZKNDVvK1pnZUFtenZNemdtRVJhbCtCS2RXUVA2YlN0?=
 =?utf-8?B?N1A1U0ZydGp1OTVucGk5WG4yVjBreGVHZ2FYalVqWG4zM3k1aSsrV09CSzB0?=
 =?utf-8?B?TlRWYWMwODlYMms0TXdadkZuTWg0OE92UmM2RFJmMU5QRmRQdktmQTN2Vjg1?=
 =?utf-8?B?cDB2c1gwa1FrWmFnSXpTMGsxc0N4Zjc1Y2hIMVVRZVpzRWkvaHZRWTRVTzVD?=
 =?utf-8?B?V1lKZU1YTnpXaGdmQ05VN3VZbk02VkM2SHJoQ0JueTdLU29uTkdPdmV5Sldw?=
 =?utf-8?B?SjJ0cUo5Sks3TzVCMlE3Zkg3aUhUSUtWSklxUi80WEI1WVJNZFVuYy96TjRy?=
 =?utf-8?B?NHR1QjZVZkNsVWMrUVltUEFJMG9hemFzMDk2WEZSekd0ZXNHSGRTR29EWnJQ?=
 =?utf-8?B?OG85UDMzWnNUNThaMmNjMXBpcDgwQno3N2ZKZUVodm1LTXNndEJYaWJhQk5i?=
 =?utf-8?B?a2k1NkIvUjBWOERuWTdnUHljSVdJcTg5cXZpR0F1Ri8zZVUydE5TUlJNaTdJ?=
 =?utf-8?B?NnIzU2pPNlVubHljYTRaeW9jVk9HVEZHei9Ub3hhZnBGSmVaWkd0Y2thbFIx?=
 =?utf-8?B?YmE0MUhBUXZjc0F0WGRCWEJzSHQxeVNnYVVBeEtObGpFMlNHd3lSNEVWSXhj?=
 =?utf-8?B?TDlPRVZzNUVUWUJIU3ZxK1U4emxmb2VTcHRWZmVQMThwMEtOS1p0RmF0VERL?=
 =?utf-8?B?MkZrMmxLdlIyTmlKbUVybjFjSTh1MkhWR2JlNTR3c3pTMjlmNUlHa1VadUUr?=
 =?utf-8?B?dTRUOW5vK01xeFJTZnN0Ny8yNyttbllOOE9PcGhZYlc2bE8rTC81T2lyZUZL?=
 =?utf-8?B?dEhuY01najZ6dE1BcnFyVk1YVnRvMkFlNVZ0OXJqY1dRL0tMa0ZhTTB1WE5X?=
 =?utf-8?B?L0JkRWp1cWhCSWF2M2J5cmIrdkhPZjY4NTRzeXF6U2V0UFpaVlBKNllUcU0v?=
 =?utf-8?B?em9OT2EyaHhQcmM4OW8yTDR1WGZDcHB4VWpQR2hBRUpmaG45Z1hxeDdLZWlY?=
 =?utf-8?B?SkNidWFpYThUUisvTU1Yc2pDOFFOSzFxaVZRVGw5aUZ0WEVseUhrQ3FhNEZo?=
 =?utf-8?B?YjVET0NFVGVDRmJrd21LQm1SWjlvL3RZNjllcXN3QWVkNmtnRjgvUXI5V0xI?=
 =?utf-8?B?VllEQ2R0Y0ZLL1hyR0d3cDJHQ1lpRWFsMEFxcEVRWkNRWGZaemo5Vml6Umkv?=
 =?utf-8?B?OVdOMFhmaXJqMGt5MkRMMnpybWN6L0FydW5vL0RxLyszVm9RQ0lBNE56RHBX?=
 =?utf-8?B?N3NYT0ZGM09IcjJ3SHl0emNwNHJtRkNpbHUrNVFhQ3BLZFduTmpkVXRBZTM0?=
 =?utf-8?B?VlZVUTdzK2pHMWN6L01NdUxqS1Z6L1VOYkwzNlZ1bzhBNGdHbmF6S0srejR6?=
 =?utf-8?B?WkJBSnJBYUJUSzlFQ1haOE5sMmZZZ3R2Rmc5QVc3SFRXdFZuK2ZxTjV4aVZ0?=
 =?utf-8?B?SnRsOEU5a055clkyWnVCZm5JMlVYWG43U0ZINlNFMjZwS1JzVHVKd2F3dzlO?=
 =?utf-8?B?M2t0bFhGcStCY1JuOHZlS0RGQnNMYzh5Nlg0QXdjS2Q4S1R2NTBHTG91amE1?=
 =?utf-8?B?OER3UWRFVmhqcWpqWHlLSDNwTWlPY1RLd2dvZ0xCeVA4V2NNdkdvUVZaMzFU?=
 =?utf-8?B?UzlpbWx1c2dSREpBd1VMN2lFc2Y2cXl0M0taSGhHQUZMNDdzTDRxTWplNUFR?=
 =?utf-8?B?azNDcFdNNjBBR2tGdElzNSs4L1N3bWsxeFY4eWVONWs2WWNCb3d4QkRjS05W?=
 =?utf-8?B?Rk8wT09lWFo5RVExVGFpVHlYcFpYNlYxSnNwMGppU2tWOWpQK3RPcnNiMjFt?=
 =?utf-8?B?aGdkUUl4RDFCRmR3RW45akZvTGF3RnRWWDZJMHV3QUV1dEI2SWMyYWZJbDEr?=
 =?utf-8?Q?H8lZNKSa5SjcvOHlp1s15gbPtcIzcGYt?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 51b64bec-47e2-42aa-7fbb-08da0ce13c22
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5286.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2022 15:24:34.5227
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vTRvw9urVgpbFeIlTvOGJko//NPWnyXCo58lnxeXdORZabCV/gOz0ytbdEepz/TYwlD5p0D5RMAAXlWb5HZLkA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1860
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Boris,

On 3/15/2022 10:58 PM, Borislav Petkov wrote:
> [CAUTION: External Email]
>
> On Mon, Feb 28, 2022 at 09:41:54PM +0530, Naveen Krishna Chatradhi wrote:
>> From: Muralidhara M K <muralimk@amd.com>
>>
>> amd_cache_northbridges() is called from init_amd_nbs(), during
>> fs_initcall() and need not be called explicitly. Kernel components
>> can directly call amd_nb_num() to get the initialized number of
>> north bridges.
>>
>> unexport amd_cache_northbridges(), update dependent modules to
>> call amd_nb_num() instead. While at it, simplify the while checks
>> in amd_cache_northbridges().
Apologies for the late reply.
> What I am missing in this commit message is why is it ok to do that?
>
> AFAIR, previously, amd_cache_northbridges() wasn't an initcall so the
> module or builtin - which came first - was forcing the NB caching
> through the explicit call to amd_cache_northbridges().
>
> fs_inicall() does that now unconditionally so the question is, why can
> the module init functions assume that the northbridges have been cached
> already and can simply get the NB number?

Modules that are using this API comes after the fs_initcall() is called.

This patch is prepared based on a previous discussion

https://lore.kernel.org/lkml/bcf5e86c-d3f1-0dab-2bed-505b1eb95f17@amd.com/

quoting from the thread

 > I'm going to venture a pretty sure guess that the initcall runs first
 > and that amd_cache_northbridges() call in amd64_edac_init() is probably

 > not even needed anymore...

and i've confirmed the call flow.

>
> Thx.
>
> --
> Regards/Gruss,
>      Boris.
>
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpeople.kernel.org%2Ftglx%2Fnotes-about-netiquette%3Awq&amp;data=04%7C01%7CNaveenKrishna.Chatradhi%40amd.com%7Cf178536c5a264e5bd9ca08da06a98c6f%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637829622545040298%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=iRnHksY7p4nd4pALbDNp11Y7%2FSMAou9X0XrV%2FC7K8Xk%3D&amp;reserved=0

Regards,

Naveenk