Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp2145123pxb; Fri, 25 Mar 2022 11:54:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz/UHu6e1uVYBOheCPbZIWphRpHVw3Bbru0BTyLR995ZMMxVwUgXlhFbaM6yL+vhmKt69w0 X-Received: by 2002:a17:90b:380d:b0:1c7:223:c0d with SMTP id mq13-20020a17090b380d00b001c702230c0dmr26959317pjb.94.1648234444626; Fri, 25 Mar 2022 11:54:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648234444; cv=none; d=google.com; s=arc-20160816; b=mSdPRPdhybNMfRBt64tFk15MISQSFXQFLmP8oE5wT//JpgBFlzbPNZBNmSR04XmzAz 3zW5i2VSfM0PFC9hu4as+as3LwK/jaLfPqZNtYEHo5pV1eOZojgDjSFM49qImweMi7Zn 3i+58novEpeLs8d3w+RwgrLOjY1pw/DKJ0xqGjf+MBhO1dxRxFTgW4/ppO38Wgrz4UEZ adAT72IbHLGYYCV4gniLpTzDaGCreBFySAmD57Ec0LKI96gp+mKhhatBuuH5rnRtF9Kk XYR4deRdZaLLOx2A3cFaV0/jzRSi4F1ToKQpSpYqWXaiWgMBZGQbbM+mJJ0xS5w3exyj t7ZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=q25spFCj2OPBzQfCV+Da/CWuMLQodxbTw+TkS6+i2hU=; b=hppQpCznPCEvI0OShYT/W36uxK5x1Gz1prLLkfm7+zxZ9RiCHJU1ghk1OsYhUlMO8o 9Yz9stceZSu7Zn1tUlhecNq7DkdRwB2QT9Daajb9ReaLAUedK4w4l9zuA+PRjjkdG2+G zM3eWLHiVSOx1ztAhsZafHDnmf98ZyoFVn1SK+U0hGCNq3ZC55BpFbsvMo6owDby4CiM VQGxMCCJqQcLnHBqEh3BrRvn4SJ4/T0YOBXJXPdQSvs+jH+lX4VpcwpgnX4A4cvFBL9p 9wVwSGe1zmwHIybBEe288OiHUs5ny1QvVEIDW58oBHj9eM0hM1WuQZ38z26gC3a3cbPh jspg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id k2-20020a17090a9d8200b001c7532e6d3fsi3224092pjp.72.2022.03.25.11.54.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Mar 2022 11:54:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id C9B032C7; Fri, 25 Mar 2022 11:06:29 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353632AbiCXVFD (ORCPT + 99 others); Thu, 24 Mar 2022 17:05:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42408 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347111AbiCXVE5 (ORCPT ); Thu, 24 Mar 2022 17:04:57 -0400 Received: from mail-oi1-f171.google.com (mail-oi1-f171.google.com [209.85.167.171]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 44FD92E9FF; Thu, 24 Mar 2022 14:03:23 -0700 (PDT) Received: by mail-oi1-f171.google.com with SMTP id 12so6157921oix.12; Thu, 24 Mar 2022 14:03:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=q25spFCj2OPBzQfCV+Da/CWuMLQodxbTw+TkS6+i2hU=; b=XtVDAk2Q0RmKFIsJHKCpPJHygtgl6UsSECM0WtKrTNIa2wf6uCcGCSUXHffmHfKVQL Jnwl4jwKoABLp0R8Ut3Q8K0IbiWFnQMw3q4TD2MgEKRngCVJtyxN5P54JflUJcQgI1+Y 5b8BN4lCvwaF3rgVRfQcncU4OVQLiFRR8VFk+fPiW88Z3UXII9q/XuELKZLsj2q1PZaJ BLGOR+VYyz9PgNwqeWSyEIIB6wGj7yJI+p32Jikb3VovSWkHNed2rlnzdXvfDU9ErvrT 0FQ/0jqp+fe2BG9ndFC4sRRSrPlS/I/NEiqASs15JHXAR5gagHYfd+MtrAxfNIYg7pwW Wkhw== X-Gm-Message-State: AOAM530T7VMzgkrOcH9Cw7Di2IWwnvI4ixpvegIOtHR7CpBnBFeur9kf lcu82EbSOG9LN+nSR66Y+A== X-Received: by 2002:a05:6808:1a9b:b0:2ec:9c38:185 with SMTP id bm27-20020a0568081a9b00b002ec9c380185mr8323647oib.165.1648155802614; Thu, 24 Mar 2022 14:03:22 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id 2-20020a056870124200b000dd9ac0d61esm1812407oao.24.2022.03.24.14.03.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Mar 2022 14:03:21 -0700 (PDT) Received: (nullmailer pid 2568899 invoked by uid 1000); Thu, 24 Mar 2022 21:03:20 -0000 Date: Thu, 24 Mar 2022 16:03:20 -0500 From: Rob Herring To: Miaoqian Lin Cc: Ryder Lee , Jianjun Wang , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , Matthias Brugger , Chuanjia Liu , linux-pci@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] PCI: mediatek: Fix refcount leak in mtk_pcie_subsys_powerup Message-ID: References: <20220309091953.5630-1-linmq006@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220309091953.5630-1-linmq006@gmail.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,MAILING_LIST_MULTI, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 09, 2022 at 09:19:52AM +0000, Miaoqian Lin wrote: > The of_find_compatible_node() function returns a node pointer with > refcount incremented, We should use of_node_put() on it when done > Add the missing of_node_put() to release the refcount. > > Fixes: 87e8657ba99c ("PCI: mediatek: Add new method to get shared pcie-cfg base address") > Signed-off-by: Miaoqian Lin > --- > drivers/pci/controller/pcie-mediatek.c | 1 + > 1 file changed, 1 insertion(+) Acked-by: Rob Herring