Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Thu, 24 Mar 2022 18:34:01 +0100
From:   Heiko Carstens <hca@linux.ibm.com>
To:     Yu Liao <liaoyu15@huawei.com>
Cc:     gor@linux.ibm.com, agordeev@linux.ibm.com,
        linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
        liwei391@huawei.com
Subject: Re: [PATCH] s390: cleanup timer API use
Message-ID: <YjyriSRJY1mw04Jt@osiris>
References: <20220322030057.1243196-1-liaoyu15@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220322030057.1243196-1-liaoyu15@huawei.com>
Precedence: bulk

On Tue, Mar 22, 2022 at 11:00:57AM +0800, Yu Liao wrote:
> cleanup the s390's use of the timer API
> - del_timer() contains timer_pending() condition
> - mod_timer(timer, expires) is equivalent to:
> 
> 	del_timer(timer);
> 	timer->expires = expires;
> 	add_timer(timer);
> 
> If the timer is inactive it will be activated, using add_timer() on
> condition !timer_pending(&private->timer) is redundant.
> 
> Just cleanup, no logic change.
> 
> Signed-off-by: Yu Liao <liaoyu15@huawei.com>
> ---
>  drivers/s390/char/sclp.c       |  4 +---
>  drivers/s390/char/sclp_con.c   |  3 +--
>  drivers/s390/char/sclp_vt220.c |  6 ++----
>  drivers/s390/cio/device_fsm.c  | 12 +++---------
>  drivers/s390/cio/eadm_sch.c    | 12 +++---------
>  5 files changed, 10 insertions(+), 27 deletions(-)

Applied, thanks.