Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp2153964pxb; Fri, 25 Mar 2022 12:03:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzb9KHeklVv9xBs+pK6p5PbrqFSoD7fUrbzfVyyAGTwu2KOyNe613aXeV7APvVPtjoZqMIo X-Received: by 2002:a05:6a00:21c6:b0:4fa:914c:2c2b with SMTP id t6-20020a056a0021c600b004fa914c2c2bmr11578034pfj.56.1648235009996; Fri, 25 Mar 2022 12:03:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648235009; cv=none; d=google.com; s=arc-20160816; b=KRXeCEbhgPHswjI26BNBoc+qvFDzjZV1C49XSMe5RVQesxV14reGWJQpIZ4ARyBsAU UqoIGdy/GdyAXvKx8D/ptnP5bfeLFlDnUwcVUxiLxr1WrolTOR6Xs31uFptWM6YCVZo1 8XyjrY9XXibbpmKIT7OFRZahFCG6tlxHNeFc16PnkB+HeInQwZKmowiwDIVAT02i5PzV rYiO8m7DBC7rejuZrO6z8+pZhRPBhYMRuMkzSMEU8/n+T82D4f2le7MKnQYdEOo6qwvm hLBCQub/8JXSAMNZt4a66zYJ2mNXtkqb4o3mX7t4PrvLs2ayy8x1IfftUD5W+8updP6j pbrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=heAAc/3WAmcuG1gDfQHeqEiMau5nsirCkvH+OQJa+eI=; b=DJOtHbdAgl2HhKS1Mg5ZU2xF4oKD+CqRAVjx8SKUVXqnf504Y5z2zx9WkxneQOK6NP LT2xuAEGHDqeWnXuWbMZN+aJqXwuPVgzIQoQwR/o1iv0OvXFIhJNNPSf/5ggFhron+K7 WSQkOYfx25VJKkyXDYOSQ7Hs7kmnr6+TXUyUhMh/u3cgFbGK1nT2KXPDMMDldgXiefiq aQNpcJc/Y4wimZs83dnizoHetPViBDlaJCTlfpN6vY49QpMFVzTllOyfNzP5l+Ts2vxM TDySO2rX8ciD/8SfcihHyoJwcEq+Pzz5NfbPv4ECERYjM/6wCgMsElUQHcBMb4Z2vJQm Qh3Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Gc4oMGwu; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id p18-20020a63e652000000b003816043f098si3202274pgj.653.2022.03.25.12.03.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Mar 2022 12:03:29 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Gc4oMGwu; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 546311CAF37; Fri, 25 Mar 2022 11:12:17 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378614AbiCYPfO (ORCPT + 99 others); Fri, 25 Mar 2022 11:35:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1377733AbiCYPYc (ORCPT ); Fri, 25 Mar 2022 11:24:32 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 67135E72AE; Fri, 25 Mar 2022 08:18:47 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 015D660A1B; Fri, 25 Mar 2022 15:18:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 065F9C340E9; Fri, 25 Mar 2022 15:18:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1648221526; bh=dlt1A1biLcVDgMxTU/Y7y85mBaY6WRz6rpXrh1D3VB0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Gc4oMGwu9b3SOgIM+oASxdmUHb0irdvugJ5Q8dtqu5dHJIEZzksFAQaI3DjF/Q5yQ rFDhtU7VSCrEiSVsJDuSiJbsCEi+wh+cNJ4XtnGNk+8dpdq4yoq/f6oOTgrtDNOJdD bEuigIJ73IJuaZSRlgFOlyVFUTbHY8V2GkZzaUR4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jonathan Teh , Takashi Iwai Subject: [PATCH 5.17 17/39] ALSA: cmipci: Restore aux vol on suspend/resume Date: Fri, 25 Mar 2022 16:14:32 +0100 Message-Id: <20220325150420.736207240@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220325150420.245733653@linuxfoundation.org> References: <20220325150420.245733653@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jonathan Teh commit c14231cc04337c2c2a937db084af342ce704dbde upstream. Save and restore CM_REG_AUX_VOL instead of register 0x24 twice on suspend/resume. Tested on CMI8738LX. Fixes: cb60e5f5b2b1 ("[ALSA] cmipci - Add PM support") Signed-off-by: Jonathan Teh Cc: Link: https://lore.kernel.org/r/DBAPR04MB7366CB3EA9C8521C35C56E8B920E9@DBAPR04MB7366.eurprd04.prod.outlook.com Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/pci/cmipci.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/sound/pci/cmipci.c +++ b/sound/pci/cmipci.c @@ -298,7 +298,6 @@ MODULE_PARM_DESC(joystick_port, "Joystic #define CM_MICGAINZ 0x01 /* mic boost */ #define CM_MICGAINZ_SHIFT 0 -#define CM_REG_MIXER3 0x24 #define CM_REG_AUX_VOL 0x26 #define CM_VAUXL_MASK 0xf0 #define CM_VAUXR_MASK 0x0f @@ -3265,7 +3264,7 @@ static int snd_cmipci_probe(struct pci_d */ static const unsigned char saved_regs[] = { CM_REG_FUNCTRL1, CM_REG_CHFORMAT, CM_REG_LEGACY_CTRL, CM_REG_MISC_CTRL, - CM_REG_MIXER0, CM_REG_MIXER1, CM_REG_MIXER2, CM_REG_MIXER3, CM_REG_PLL, + CM_REG_MIXER0, CM_REG_MIXER1, CM_REG_MIXER2, CM_REG_AUX_VOL, CM_REG_PLL, CM_REG_CH0_FRAME1, CM_REG_CH0_FRAME2, CM_REG_CH1_FRAME1, CM_REG_CH1_FRAME2, CM_REG_EXT_MISC, CM_REG_INT_STATUS, CM_REG_INT_HLDCLR, CM_REG_FUNCTRL0,