Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp2160898pxb; Fri, 25 Mar 2022 12:10:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyfMV+VnWY8SLOb44sEn1l4I4TwG27PIUeHzfbV4X5ftFtyr4YZYv8930fUjU++Bq7wy9XO X-Received: by 2002:a17:90b:1b52:b0:1c6:b689:813d with SMTP id nv18-20020a17090b1b5200b001c6b689813dmr14272956pjb.186.1648235422294; Fri, 25 Mar 2022 12:10:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648235422; cv=none; d=google.com; s=arc-20160816; b=OIXD/jgs1roepcQ/ujGLJD0xkHlFtmKlmv8TiB6LZGpbBN0Bno1+0xHSqQj9b88sxN cqBJyO3kdIhAEeXekC2lxlvwgbbm2UbKlnk5KybEHfBKvazpp90btRgPzcN7WATTWyrC aOkqMrhzjgvBzwfsqLMx5OgUYvDGnT1qjTMGntosesb/dv5wVngd9n1NmkIDnKBLMYMT SmTd2ochRVP4v9kiaMql0PR2yJiKiz9Tj6pJRNUo3/5X6au+ehoMS5g5AG2J/hx8ZBrG W3DDUWRXKjdzEAQKC3hDz/fe6Sodxn7R9Ill2QPJie1B8FxL9yZemlg2S5WHdBJVWWrE B0Ag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=HfS7RNhMsAvhm3dkViHCIr0vMqh85tM7E/+ao0kRKJs=; b=gaP5VxnJ0IjAHnvNmtXUk8igPFjFkK1uGQVsFrFj01v52Ejppj8NR62cOjGrfopbsq 8HHS3LqkRd58WvCAGW7TPuWDpvSzxs+otsOdaSnsMYnwFXLf0ofYPa8i/3yT7L0eqyuW qA+WZYoX8IpdbjRIobAViQKSQ7wDdnRPRReSywAYuOYrR9LiIHLD5l/iY6Wmzl02E67M 2rDqghVCL2iKUPC9v0RUrb9eV3JJMf8/tYX9ae6tmhhWs/rq8Q3TjqdqEnRzrQbX9DuS Kf4XfSaYXgylEfDgjO2RK+ft/d+jGE/oLGh+0p5vsp1pbYCqVPqYhWiJrmBccdq58cIG eh9w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b="tW2EeH/e"; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id nv5-20020a17090b1b4500b001c6fd746c71si7369979pjb.119.2022.03.25.12.10.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Mar 2022 12:10:22 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b="tW2EeH/e"; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9CC781FDFE6; Fri, 25 Mar 2022 11:14:37 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345486AbiCWXbx (ORCPT + 99 others); Wed, 23 Mar 2022 19:31:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60188 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345476AbiCWXbw (ORCPT ); Wed, 23 Mar 2022 19:31:52 -0400 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6BC1869CCA for ; Wed, 23 Mar 2022 16:30:21 -0700 (PDT) Received: by mail-ej1-x631.google.com with SMTP id qa43so5850513ejc.12 for ; Wed, 23 Mar 2022 16:30:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HfS7RNhMsAvhm3dkViHCIr0vMqh85tM7E/+ao0kRKJs=; b=tW2EeH/eBKHhPEoNUW7aeZDdjSo2N3sR5g8/rjFyrWWIfWC9lzpK7okoF/VHQoK3/R nRnXQzDF/+QOzMU5yhwb972fhRH79C3FASiflIzZF8aFHuGLrEbg9V2ojYFvJoHWrXTg Rm9xIyV8e3TrJCUCw+B+7bIVxPbQfaXlyC9ysfKC0uwry4x2DrEiYC++/51pb+RW2DU9 WKnqE3tlVdqzQHCILZG7Fp5+Hy0OD3VN+P4mdQ35EngOytiOZ/9St5He9SjbDhSUlCYV rK+T4hZ4nfTY9AnZMav6bqNLsIOBTA+GiUrJF5I4n8B4BsfziS9oabg3fqvrik1d1MWi zURw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HfS7RNhMsAvhm3dkViHCIr0vMqh85tM7E/+ao0kRKJs=; b=6GGJlnx8H5FXOltLyI9UqZpo0ZJ/971PgoQtcxC38DxKCTKtb7Z2DvdiXunNPE+AoR DWDbTEfjyTnEnOsTG2QojCqGM6kmRS20G5HVjZX2+s7TLKksQmw7uJ88uxZxd2MW5Fmf OXEvSqhmUDH3OXJJ+EIstLAWpHKMQ1d8Mwg5QwXToFaIL3LIPrIpsBgRufU2w1C5xOO8 ETs5fyxkZ9mmXhIvljfM23KaxeI6nVzLbFxyADnexsKEqGzS0ADwsTMr4bqQPHoeNEp6 44CpAX2+WGer0VXMoQAGugr2nvFd793cdVsT4dT5s2Qs7mI9IO25XSMxMapWWbQXIAYk siog== X-Gm-Message-State: AOAM533gok2ex/20jmbDCifsUqOicYW5O+i4HEPsRJvWosFPdFR4+BQ7 xeQsnRN6+xA5IZuXZReAADjsMJ/1X0/tXBTI4orhBw== X-Received: by 2002:a17:906:d54d:b0:6e0:1f9b:5064 with SMTP id cr13-20020a170906d54d00b006e01f9b5064mr2733192ejc.59.1648078219829; Wed, 23 Mar 2022 16:30:19 -0700 (PDT) MIME-Version: 1.0 References: <20220224055350.1854078-1-keescook@chromium.org> In-Reply-To: <20220224055350.1854078-1-keescook@chromium.org> From: Brendan Higgins Date: Wed, 23 Mar 2022 19:30:08 -0400 Message-ID: Subject: Re: [PATCH] kunit: tool: Do not colorize output when redirected To: Kees Cook Cc: linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, David Gow , linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-9.5 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 24, 2022 at 12:53 AM Kees Cook wrote: > > Filling log files with color codes makes diffs and other comparisons > difficult. Only emit vt100 codes when the stdout is a TTY. > > Cc: Brendan Higgins > Cc: linux-kselftest@vger.kernel.org > Cc: kunit-dev@googlegroups.com > Signed-off-by: Kees Cook Reviewed-by: Brendan Higgins