Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.80.82.1.1\))
Subject: Re: [PATCH] IB/SA: replace usage of found with dedicated list
 iterator variable
From:   Jakob Koschel <jakobkoschel@gmail.com>
In-Reply-To: <a06fef85-7b5c-b2ef-7965-2387cbc8f724@nvidia.com>
Date:   Thu, 24 Mar 2022 09:24:01 +0100
Cc:     Jason Gunthorpe <jgg@ziepe.ca>, Leon Romanovsky <leon@kernel.org>,
        =?utf-8?Q?H=C3=A5kon_Bugge?= <haakon.bugge@oracle.com>,
        Mark Bloch <mbloch@nvidia.com>,
        Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        linux-rdma <linux-rdma@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Mike Rapoport <rppt@kernel.org>,
        Brian Johannesmeyer <bjohannesmeyer@gmail.com>,
        Cristiano Giuffrida <c.giuffrida@vu.nl>,
        "Bos, H.J." <h.j.bos@vu.nl>
Content-Transfer-Encoding: quoted-printable
Message-Id: <FA1E832C-2030-4344-97EA-E0E219DDDF6C@gmail.com>
References: <20220324071124.59849-1-jakobkoschel@gmail.com>
 <a06fef85-7b5c-b2ef-7965-2387cbc8f724@nvidia.com>
To:     Mark Zhang <markzhang@nvidia.com>
Precedence: bulk


> On 24. Mar 2022, at 08:53, Mark Zhang <markzhang@nvidia.com> wrote:
>=20
> On 3/24/2022 3:11 PM, Jakob Koschel wrote:
>> External email: Use caution opening links or attachments
>> To move the list iterator variable into the list_for_each_entry_*()
>> macro in the future it should be avoided to use the list iterator
>> variable after the loop body.
>> To *never* use the list iterator variable after the loop it was
>> concluded to use a separate iterator variable instead of a
>> found boolean [1].
>> This removes the need to use a found variable and simply checking if
>> the variable was set, can determine if the break/goto was hit.
>> Link: =
https://lore.kernel.org/all/CAHk-=3DwgRr_D8CB-D9Kg-c=3DEHreAsk5SqXPwr9Y7k9=
sA6cWXJ6w@mail.gmail.com/
>> Signed-off-by: Jakob Koschel <jakobkoschel@gmail.com>
>> ---
>> drivers/infiniband/core/sa_query.c | 15 +++++++--------
>> 1 file changed, 7 insertions(+), 8 deletions(-)
>> diff --git a/drivers/infiniband/core/sa_query.c =
b/drivers/infiniband/core/sa_query.c
>> index 74ecd7456a11..74cd84045e5b 100644
>> --- a/drivers/infiniband/core/sa_query.c
>> +++ b/drivers/infiniband/core/sa_query.c
>> @@ -1035,10 +1035,9 @@ int ib_nl_handle_resolve_resp(struct sk_buff =
*skb,
>> struct netlink_ext_ack *extack)
>> {
>> unsigned long flags;
>> - struct ib_sa_query *query;
>> + struct ib_sa_query *query =3D NULL, *iter;
>> struct ib_mad_send_buf *send_buf;
>> struct ib_mad_send_wc mad_send_wc;
>> - int found =3D 0;
>> int ret;
>> if ((nlh->nlmsg_flags & NLM_F_REQUEST) ||
>> @@ -1046,20 +1045,20 @@ int ib_nl_handle_resolve_resp(struct sk_buff =
*skb,
>> return -EPERM;
>> spin_lock_irqsave(&ib_nl_request_lock, flags);
>> - list_for_each_entry(query, &ib_nl_request_list, list) {
>> + list_for_each_entry(iter, &ib_nl_request_list, list) {
>> /*
>> * If the query is cancelled, let the timeout routine
>> * take care of it.
>> */
>> - if (nlh->nlmsg_seq =3D=3D query->seq) {
>> - found =3D !ib_sa_query_cancelled(query);
>> - if (found)
>> - list_del(&query->list);
>> + if (nlh->nlmsg_seq =3D=3D iter->seq) {
>> + if (!ib_sa_query_cancelled(iter))
>> + list_del(&iter->list);
>> + query =3D iter;
>> break;
>=20
> Should it be:
>=20
> if (nlh->nlmsg_seq =3D=3D iter->seq) {
> 	if (!ib_sa_query_cancelled(iter)) {
> 		list_del(&iter->list);
> 		query =3D iter;
> 	}
> 	break;

yes you are right. Sorry about that, I'll send a fixed version with v2.

>=20
>> }
>> }
>> - if (!found) {
>> + if (!query) {
>> spin_unlock_irqrestore(&ib_nl_request_lock, flags);
>> goto resp_out;
>> }
>> base-commit: f443e374ae131c168a065ea1748feac6b2e76613
>> --
>> 2.25.1