Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp2164717pxb; Fri, 25 Mar 2022 12:14:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy3TLbTH4ftfmxcMKPW+c7PSbekGdGrW2H4wUFt/NZpKGFcWE73KgfGSDpdgODc3B+IMGcc X-Received: by 2002:a05:6a00:10d0:b0:4f7:5af4:47b6 with SMTP id d16-20020a056a0010d000b004f75af447b6mr11676951pfu.6.1648235670930; Fri, 25 Mar 2022 12:14:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648235670; cv=none; d=google.com; s=arc-20160816; b=aszOvrl+wjvQoyHOZfPamDvNCz/5aVAFdrbNkVu6XQUKlb12UkrjO4Z3t4dkf0xEqK qZ2iEksePcic33xUoH5CPE3ZssBiMSBiGBmWJmX4lwQ+pY7f/LO57CooBQZXYXyyy7GI KGYEgIaiM2bYBAbw4tiKW1gjxXzwCneqTxbKYEvAMUTDJYs0++ZcGwa2LAUaLSeD/U8F RSVqkQ2+yQbfvzmuc6nvexwMsGTwNySoX/3yAknbn1aEr1E6528LmueiILsHWuVRoOKG Niw3Czye0RPaDHqmtj5JUMmHWyYo4r+lEhV6Ly9k48GXABh1/tdVA/zm593fb6BH45Se ro8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=8rN13FMeqEprGT5GtmNj2tl/IA4XlrCPy/4n11uT4fQ=; b=boQ8m+V7EAeRIHwfnEQBkX9xMTG5CtOhzZjYLLGaPcsA8IekMHsof49JJKKLBaM+5w Ry/A4uB2DCh/FgA2i6fb0VeUSznPqyJ5ikoWh/ABBoegWEwqwtTLHqQrJZRKgJQfSLZ6 G6Ls9pDVc7ghM5p4vsi1ar2FCxv3/2DlDMB4w3Q3QrDyl2zPGdszrS+KQNIBaAhKBuIy ITuyOU/9US4h6RCSOGmvthUsAw4CzE1WOx7L1lNqZC0TYfSScwnTD+1eFRA82RmztTAZ cEaIyTJ+P6Y4s7xjT2oS9uHr8NYFHvcyELoPVFCz4PAUuvpxggnxEBjnrpYBRX0hahTq s/WQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=lFcisYYI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id s13-20020a65584d000000b0038639161a37si3067186pgr.510.2022.03.25.12.14.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Mar 2022 12:14:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=lFcisYYI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 3D85022320A; Fri, 25 Mar 2022 11:19:48 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346839AbiCXAlU (ORCPT + 99 others); Wed, 23 Mar 2022 20:41:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40464 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230220AbiCXAlR (ORCPT ); Wed, 23 Mar 2022 20:41:17 -0400 Received: from mail-yw1-x1135.google.com (mail-yw1-x1135.google.com [IPv6:2607:f8b0:4864:20::1135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E817B65171 for ; Wed, 23 Mar 2022 17:39:46 -0700 (PDT) Received: by mail-yw1-x1135.google.com with SMTP id 00721157ae682-2e5e9025c20so35717117b3.7 for ; Wed, 23 Mar 2022 17:39:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8rN13FMeqEprGT5GtmNj2tl/IA4XlrCPy/4n11uT4fQ=; b=lFcisYYInl3HhTN9FFSdwKvRMetfhMw7fQeFnSW86dZe5L+XqQ8MjGPrpAEzEQXAt5 LqcnW/7aRPO9dsI6WqRmEMkClwvp14cGL86TdEutHb3KsvDkXQKXUfGGg7ilRtflQNot B9t9JuVMDSN9Yp43S1qt7s0f/KCgHaYlpqDq33vcvwDEgKRSVwskw94RPWF1v513MvNS cqJ1fmjC5zqHjWYggPS2OFCXXvXU1ZFq8hQaaFVc4Xy8rUEUf1T20Yv4i0Thg5beToNh tSE+Z7oHq0TQBBvu+SyIfWvdRc8wjdmorRSrF5DpZfzWilfYZV6b58FF4MHzQwxoulaj A0hQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8rN13FMeqEprGT5GtmNj2tl/IA4XlrCPy/4n11uT4fQ=; b=QRR9SGubx1kiKqONqJd8f0y45rA7tk2hItIctjaKeuxmmZ9ua1djYaGpO2j4cAuver YgQxcGa0jQHbqLQ4vU9GS7ijrfC5/+Any/du5bY9nq9KVLSGLikKOIfO6QjrZcW4x3eG xZUMqHZEvKLKJmSQGjaMYYCsiJlpEXoDb4OTY7/Pev4WgAjJKis9hRFPqErSdubrG68r uj3+yzsCZKEbTjbvrMofM4R+j6YjUnILt/sBAuqTK62J6/lmHYnKJr549sy5BaeTgZ2m Cdp2Bz5tYk8+YDsRpsMbbzkT0nFEqWhMcJEG0vFA2fQNDsOYWscgw4xPGh6w+lsHPqZE eavQ== X-Gm-Message-State: AOAM530qyfC6XD9RNggl2J/oTPnr7s+s8w50N0lTeoeC9vmxvH8PGf4P qdbgv9scVuU1DXwOcp62Yx159LmoKbAYH4YXsH+RHA== X-Received: by 2002:a81:d542:0:b0:2e5:c060:a0ac with SMTP id l2-20020a81d542000000b002e5c060a0acmr2644500ywj.118.1648082386034; Wed, 23 Mar 2022 17:39:46 -0700 (PDT) MIME-Version: 1.0 References: <20220317065851.495394-1-zhangjialin11@huawei.com> In-Reply-To: <20220317065851.495394-1-zhangjialin11@huawei.com> From: Linus Walleij Date: Thu, 24 Mar 2022 01:39:34 +0100 Message-ID: Subject: Re: [PATCH -next] pinctrl: nuvoton: Fix return value check in wpcm450_gpio_register() To: Jialin Zhang Cc: j.neuschaefer@gmx.net, openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 17, 2022 at 7:49 AM Jialin Zhang wrote: > In case of error, the function devm_platform_ioremap_resource() > returns ERR_PTR() and never returns NULL. The NULL test in the > return value check should be replaced with IS_ERR(). > > Fixes: a1d1e0e3d80a ("pinctrl: nuvoton: Add driver for WPCM450") > Reported-by: Hulk Robot > Signed-off-by: Jialin Zhang Patch applied! Yours, Linus Walleij