Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp2174469pxb; Fri, 25 Mar 2022 12:25:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJybcQtIcVXBMm8s9LORjeAbZHURPahrBAqYp9MUvF1mNoQ2soUVpug9Ymc1jrGHAiPFL2o4 X-Received: by 2002:a17:902:cecf:b0:154:2177:26be with SMTP id d15-20020a170902cecf00b00154217726bemr13434967plg.96.1648236322261; Fri, 25 Mar 2022 12:25:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648236322; cv=none; d=google.com; s=arc-20160816; b=L8zckSUeBOAJywnXU65bZ6DitKaHRwJ2Q666UIbyVQD624XMZCY4ZYbNJR25SygGq8 nxTF1ROW7Hq4fcUdTBwUiKdTiP8ePD1ZQyOavHeq8fLy8q2dOTntJPsYSiwxYtQfITas t9Z9H9bxmPLu2ul3BaDg7XjNrwziLwKqWJ+gHOJ/qQ/9nBS4vjEbGZdCYbLwLSR0hMG6 7nab6CNwTIL7/itbRwRLKUcEjqCcWiaglNIyJFyUiMrQQsFHifty0dgwB31Q1f1YLpUW HM1Y0QSnmnzNUXuefItEADVv1YtAZmwoKBv1riyubSrD6NvsDEeyeGP6A6rBe/F7+DRJ WzdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:user-agent:date:to:cc:from:subject :references:in-reply-to:content-transfer-encoding:mime-version :dkim-signature; bh=wsbD88OkQk6RA2UPPUVYj29mlvHLRNYOv+tOFG2E2wc=; b=SGIW2PmxIGhL+YrVUaDBnFm6u52HP40eAqLEciJ+lk5NiTYfqQKNpkxNk+HmmRA6ri YUpnESe+B1UrN+qRd0VD5dp4NAka83m0gsmDqQ1z1P1q/TEldJ5l3WeTrXBVFYF+SmNT E2Ou1VwtPhuiKCqsbecpX19uodHoZYKpJXM+qL27r65eNEweHWhl4y9iRZHerGft8tfl xL3xziK0Z/WK73GjA84N7gF5qoREmztF+Xvt22KVP/JW899eDQiaCfsPexKW5XDKIJPn DyaxiKeqOX22V0m1wHzg2VAnq4TtyTDM8eUfYlOMchZGwEw4EWAKacOvP4V69CCItp5z A2Lg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=aXsjkxgA; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id i17-20020a633c51000000b003816043f142si2820098pgn.823.2022.03.25.12.25.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Mar 2022 12:25:22 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=aXsjkxgA; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 8CE8829B113; Fri, 25 Mar 2022 11:33:58 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357257AbiCYBYI (ORCPT + 99 others); Thu, 24 Mar 2022 21:24:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41264 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229578AbiCYBYG (ORCPT ); Thu, 24 Mar 2022 21:24:06 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3190DBD8A5; Thu, 24 Mar 2022 18:22:34 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E5724B82726; Fri, 25 Mar 2022 01:22:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 899FBC340EC; Fri, 25 Mar 2022 01:22:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648171351; bh=wsbD88OkQk6RA2UPPUVYj29mlvHLRNYOv+tOFG2E2wc=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=aXsjkxgAT9q8AR32d84qZxnvZOw6VPTp+57E0WruO1F8ae/1dPJQtfOiMY0KsvHd4 RGRTOfxVGRvPNBevAMYGT/UgHx5Chj0HtXil0Kt2MDlhwgrpXPwr+48bqmQEPEghDp TLok6ARWoss753YbyWeIyjkyXVe5VDTXz2ykOOg1QoQR+8FLVn2fMxMxFmcyWuI6QP RmAiB7/HNSWDWUexZAJcrph6jaeeWbhf+4gULwTXWjhz+5h4QtYc+/QKjZ4/J1j9U3 EnizVD5Prha2R5AL97ItmsjDnLhF2t1H+OT6rEGFAb8qmORbJZe45ZoEdz974cT73s hi+PImrYOzTfQ== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: References: <20220321231548.14276-1-ansuelsmth@gmail.com> <20220321231548.14276-4-ansuelsmth@gmail.com> <20220325011037.03173C340EC@smtp.kernel.org> Subject: Re: [PATCH v6 03/18] clk: qcom: gcc-ipq806x: add PXO_SRC in clk table From: Stephen Boyd Cc: Andy Gross , Bjorn Andersson , Michael Turquette , Rob Herring , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org To: Ansuel Smith Date: Thu, 24 Mar 2022 18:22:29 -0700 User-Agent: alot/0.10 Message-Id: <20220325012231.899FBC340EC@smtp.kernel.org> X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Ansuel Smith (2022-03-24 18:13:49) > On Thu, Mar 24, 2022 at 06:10:35PM -0700, Stephen Boyd wrote: > > Quoting Ansuel Smith (2022-03-21 16:15:33) > > > PXO_SRC is currently defined in the gcc include and referenced in the > > > ipq8064 DTSI. Correctly provide a clk after gcc probe to fix kernel > > > panic if a driver starts to actually use it. > > >=20 > > > Signed-off-by: Ansuel Smith > > > --- > >=20 > > What is this patch about? clk providers shouldn't be calling clk_get(). > > >=20 > If pxo is passed as a clock in dts and defined as a fixed clock, what > should be used?=20 clk_parent_data