Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <ca18fa50-f63b-8131-07a2-8c44daed9f26@kernel.org>
Date:   Fri, 25 Mar 2022 10:42:17 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH] arm64: tegra: Enable hda node for P3737 + P3701
Content-Language: en-US
To:     Mohan Kumar D <mkumard@nvidia.com>, robh+dt@kernel.org,
        krzk+dt@kernel.org
Cc:     devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        thierry.reding@gmail.com, jonathanh@nvidia.com
References: <20220325072141.28597-1-mkumard@nvidia.com>
 <f35537de-6352-e6db-b4a6-17b1ab96deda@kernel.org>
 <32e425be-5d78-e1e0-6ec4-70ea21895e15@nvidia.com>
From:   Krzysztof Kozlowski <krzk@kernel.org>
In-Reply-To: <32e425be-5d78-e1e0-6ec4-70ea21895e15@nvidia.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 25/03/2022 10:31, Mohan Kumar D wrote:
> 
> On 3/25/2022 12:56 PM, Krzysztof Kozlowski wrote:
>> External email: Use caution opening links or attachments
>>
>>
>> On 25/03/2022 08:21, Mohan Kumar wrote:
>>> Add iommus property for hda and enable the node for P3737 + P3701
>>> platform.
>>>
>>> Signed-off-by: Mohan Kumar <mkumard@nvidia.com>
>>> ---
>>>   arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts | 1 +
>>>   arch/arm64/boot/dts/nvidia/tegra234.dtsi                      | 1 +
>>>   2 files changed, 2 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts b/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts
>>> index 34d6a01ee1c6..156d5d95fde7 100644
>>> --- a/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts
>>> +++ b/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts
>>> @@ -1751,6 +1751,7 @@
>>>
>>>                hda@3510000 {
>>>                        nvidia,model = "NVIDIA Jetson AGX Orin HDA";
>>> +                     status = "okay";
>> Nodes are enabled by default. Why do you need this?
> hda node status is set to "disabled" by default in soc dts file 
> tegra234.dtsi. The enable is controlled by platform specific dts files.

Oh, surprise... why do you override nodes with full path? This is
error-prone and makes any changes (like node name fixing) difficult.
This should be overridden by label.


Best regards,
Krzysztof