Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <05bbea3e-93d7-2e74-61ea-7756eeead09d@intel.com>
Date:   Wed, 23 Mar 2022 14:27:56 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v4 2/2] selftests/x86/amx: Update the ARCH_REQ_XCOMP_PERM
 test
Content-Language: en-CA
To:     Thomas Gleixner <tglx@linutronix.de>,
        <linux-kernel@vger.kernel.org>, <x86@kernel.org>, <bp@alien8.de>,
        <dave.hansen@linux.intel.com>, <mingo@redhat.com>
CC:     <yang.zhong@intel.com>, <ravi.v.shankar@intel.com>,
        <linux-kselftest@vger.kernel.org>
References: <20220129173647.27981-1-chang.seok.bae@intel.com>
 <20220129173647.27981-3-chang.seok.bae@intel.com> <8735j8aa9g.ffs@tglx>
From:   "Chang S. Bae" <chang.seok.bae@intel.com>
In-Reply-To: <8735j8aa9g.ffs@tglx>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WjJ6RFRlV3M4bXU5QlN6ZU5OMmNiRVNoUmVWYUcwSFExUkdBQzVXQnpCZ0Vn?=
 =?utf-8?B?VklQTTVkNS9ObVhQOU9QckFWTHhCWVVUbm1VUG1YUGlDbFlMNUpZcVJEWG9Q?=
 =?utf-8?B?ZXdiSDlLbXBqOGNQQnA4MGlyUUJ6ZWVnbUZZeUV3b1B3SXNVNlBBS0JXcjA2?=
 =?utf-8?B?a1lmcUQ1dXZDWms5SXZsc2NKcy81SG5mT1E2c05oZ2JYbFVvV2RPcDR2VE8x?=
 =?utf-8?B?d3pTQXVrdFU4Y09SbFVFblNCZnRlbXJZZTM2SDdvMFVuSWlHSzBaTEh6MEgr?=
 =?utf-8?B?VmNrOWVaOEZSNWphRC9nbnZBT3pVMjBFTWNCUURXRUFqYnQzM0tDaTVMVS9V?=
 =?utf-8?B?OGE4Mm9yWCtuOUFsakd3aUlsL1V1OEdSV08xSzNpMDRaNWxvMCtNSGJsbWhV?=
 =?utf-8?B?RmZPdG4vQmgzTmlrQnBncFhEZFo1NGUrL0FDZTk3UStJMjlpdGp0RUdob3Nn?=
 =?utf-8?B?TEFnZGFkdExzOW52K0ZhM1pta0RTWUpsblRPVVpCNUhTMzBEYzgvT0hBNE9X?=
 =?utf-8?B?VXVzK3BNblJ4ajVzc0NpVXFhcmNGMDVtM2lTMzNXb2t5bS9La2h5UHBJUUxH?=
 =?utf-8?B?RytDTGNyWmttTnA0ekl6RzNjY1hrdXkrdmJzN3pkN210U3Vzb2F0MlpBeXla?=
 =?utf-8?B?cG95dmt5TTVSNWpUVEVmNG9KM1czeExUaldkYVkydGpPaW5qR0dlcWxEMWFK?=
 =?utf-8?B?L1g4dFBoOGFGdHh5Q2JmcEVZUEZ3amhwOVdrM3dqa1dZK2Rhc3pjZ3QxTW91?=
 =?utf-8?B?TzQxVWg4SHNYVk45MEJ3bkJPWXlNOXVoYUhxQ2hUejhNMjh3Y3AyMFVmTURO?=
 =?utf-8?B?NnZPVnFTN1NRbjJ4aTdVNndaQzFHdHFzNFNqUU5oWmNRc0pkbjIyM21wdDhn?=
 =?utf-8?B?dHZrdmNXTHNSQnB0VVBSZXd1ejVXNUh5RndiVmNNaFB1emFwbjRYanFuMHhs?=
 =?utf-8?B?TW0zVm5ZNTRMRjhpN3FIQjVvQ3ZRQmUwU3p5OWFjcVY4TVlaWndWNm9ybGMz?=
 =?utf-8?B?OWc0SCtVa0NEVkRkM1lLSkhPdXVOZmkwVjdvMzVyU0RaRVJyUzVjdXFHUXlG?=
 =?utf-8?B?Wit1UTNvSzlWYTM4eDBkaHNmUC9heW15VW1jZGxZZldESUExQk9zU3hpVjBZ?=
 =?utf-8?B?YThkL0RqMWFPRHUzeUY1M1N1VmMwamxPMHo0VTFBTXhHdEFCNHpPM1U4U2p4?=
 =?utf-8?B?UU5UbmVERlV1cVdJWU14Y3kzYTJwNDZ0VGZETENOVk9Na3h6bDg0ZlV5QnE4?=
 =?utf-8?B?T0JDMDExdEJrU3MxK3owLzFkZ2FuRXpqMGJYd25GYXk5cmxoSnZUazlqbzA1?=
 =?utf-8?B?YnoyaG43UkJrZnppdENMcGM1dWtNRjVYM244MzFVTUJqc1M1NFpmNzEvZUIy?=
 =?utf-8?B?OExoOXJjb21FSExsQWYrMUI4TUJ4WkU3RHltc05LTFNVQjJkTFROM2pWSTZ0?=
 =?utf-8?B?TjhGam90K0tWUHVVenRFUUdWNHlSdFhEVW5DWHJIc1BDYk9vcXA4UkRKMGZQ?=
 =?utf-8?B?MkFOM3pIdEIvN3NqbVhYbEMwdENjVWdDVk1mSk5nTUtVZjhXNEVGd1VMTlhP?=
 =?utf-8?B?d29xZDRaanUyYzVvSjNCOWhsQUEzNnY4S1AxUHVHTTJQQmJFK2Y0WHpGczQ3?=
 =?utf-8?B?QmdRT0ZiYVg2eHhzMHZvNFFudmNsN1ozZUpNTWV6eG1GK28reHdqQnNHcTRz?=
 =?utf-8?B?c3Npc0RzOWxlNzJnaTlDOTU3QnQxTzV4dExGZ2lWbSs1TW1UMkFmcXBPbWd2?=
 =?utf-8?B?OVBCM1pjMkVmUmgyOEpMOUJGczZCcnJOelU1YVFMMTJTT1A3ejFIeTVuai9O?=
 =?utf-8?B?czV1dm5zc1Fmcy8rcFFjMXh5dWluNTB5ZzYwN016TXZWRDFXUS90MWpJN0JY?=
 =?utf-8?B?Qm9kT3ZKMVJNYm9UbHUrVzR2L2JFRElyK0ZiejhyMEgwSkswL2RnVU9EYWxt?=
 =?utf-8?B?UVR4djBWbXJQNW0vWDJRODMySFgyTjErKzU1ZUgwQVl0WDh2d0pyUGdYanli?=
 =?utf-8?B?dmVaL1pSaVdBPT0=?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 036853a5-4b98-4e08-ff61-08da0d140728
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4855.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2022 21:28:10.0417
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Zr3hnTw72ksOGX3pZ/G4k9j5MZ3Lbq1pu2IrOjWRe9zTnpnFmsQa7Dy0+NvUgmZ1HmELhZgA2E5GXsO5qMWF0ZrwT1QpH4K8HVJpu4d4dlE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3135
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 3/23/2022 9:44 AM, Thomas Gleixner wrote:
> 
> Running it on a machine which does not have AMX results in:
> 
>   amx_64: [FAIL]	xstate cpuid: invalid tile data size/offset: 0/0: Success
> 
> It's not a failure, really. Selftests are supposed to run on all
> machines and the proper thing to do if a hardware feature is not
> available is to SKIP the test and return 0.

Ah, right. The test should be just *skipped* on non-AMX or even 
non-XSAVE systems.

Will follow up with a separate patch.

Thanks,
Chang