Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp2196775pxb; Fri, 25 Mar 2022 12:51:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzy85AEHl0sUBxwoD9QmNSUKAt5UdyyzrbmHYibRZm5AV4UhO5U3BmoPVs6IL6crbdlUlTL X-Received: by 2002:a17:90a:c791:b0:1c7:26eb:88dd with SMTP id gn17-20020a17090ac79100b001c726eb88ddmr26436291pjb.218.1648237860170; Fri, 25 Mar 2022 12:51:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648237860; cv=none; d=google.com; s=arc-20160816; b=Mf+KIFF3mEqdErOlDorJxQQFGAmTKXwpRtlXz5HVdQYXHn8lxcfHUajx4heBdz+nH/ VLuM+SqOpRrznFD/Lij4IVKYufDTVoMhZj8PTFJwpnkwAc3uews+NTVCsQYtwx2v5q7+ iSCnlveKcXkfnruuBj3Pg4tYRUuzpChu1+hbgwVpVJ9bx/TP3KpWBukN867mKWadM6Pe 1hl6pbIbKmKsdi4SdQpPhS+1gan0zctEVrj7uRMgB3T20AJoXXvh8c81xdhUKvyqzcfh /MPOKHab9u8O1CJyFbuqAoEKyXd0UmPR6azsm74cJ1MWMJF7b/Pbnjv9UsVDt9Kxqde6 su0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=qYdVN87fI7cxolE1tClOfp7bWWvUcWqI33uDbVepwfo=; b=L8P16iqQ0N/qIy7yPMus3o4J/mNDdw4ygqIg9k923cZsU+GoH12852XHPuP5zfORtJ CkyGZ7OM3UA+ZJkSCLZYUUVu4A9ZymmEyuM5vWMSuXSNIWZXh5NqPLU6DiFqN+7RIoUP rkTflGP65QyFMl9/WEpp0UbXjugdrjK41XC0J4pH+88DUemhkfFn5uuSp+Bl6vAlonla nMnNiDdcZ3iPwuzY1XhnaDLBffzuU/bEoObg258GJPSwfXlOpvT6t5qLb7JBZygEsACm C+Sx8zP81twnq9YrRAGGY1WWDPTvWozZKwqZ4eCREeAcLFYq4C15TrEVmRt10wc1DwXI zDeg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=3annfi6Y; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id 60-20020a17090a0fc200b001bd14e01fb4si6348980pjz.162.2022.03.25.12.50.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Mar 2022 12:51:00 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=3annfi6Y; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id E391C2CD819; Fri, 25 Mar 2022 11:40:18 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240336AbiCWT3t (ORCPT + 99 others); Wed, 23 Mar 2022 15:29:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57896 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242548AbiCWT3r (ORCPT ); Wed, 23 Mar 2022 15:29:47 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F076131372; Wed, 23 Mar 2022 12:28:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=qYdVN87fI7cxolE1tClOfp7bWWvUcWqI33uDbVepwfo=; b=3annfi6YEaF1or+cu2vm3QExf5 2vLfWjZ1K3BzOE1/5x160FeQw7fgekNJ+PMIUMxNKg8KE00LpG76WJUfLYgqR9390+o5B5ArSuaxX O34b1CvFjELA1OxVOgTxlMMD5I9NhnfOmDtxm7IJqDWVpcV7OXYOGOsON+aV93P4WX2s=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1nX6e5-00CKeV-6j; Wed, 23 Mar 2022 20:27:49 +0100 Date: Wed, 23 Mar 2022 20:27:49 +0100 From: Andrew Lunn To: Michael Walle Cc: Heiner Kallweit , Russell King , Jakub Kicinski , Paolo Abeni , "David S . Miller" , Xu Liang , Alexandre Belloni , Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RFC net-next 1/5] net: phy: mscc-miim: reject clause 45 register accesses Message-ID: References: <20220323183419.2278676-1-michael@walle.cc> <20220323183419.2278676-2-michael@walle.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220323183419.2278676-2-michael@walle.cc> X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 23, 2022 at 07:34:15PM +0100, Michael Walle wrote: > The driver doesn't support clause 45 register access yet, but doesn't > check if the access is a c45 one either. This leads to spurious register > reads and writes. Add the check. > > Fixes: 542671fe4d86 ("net: phy: mscc-miim: Add MDIO driver") > Signed-off-by: Michael Walle Reviewed-by: Andrew Lunn Andrew