Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   "Zhang, Qiang1" <qiang1.zhang@intel.com>
To:     "paulmck@kernel.org" <paulmck@kernel.org>
CC:     "frederic@kernel.org" <frederic@kernel.org>,
        "quic_neeraju@quicinc.com" <quic_neeraju@quicinc.com>,
        "rcu@vger.kernel.org" <rcu@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] rcu: Check the validity of the boost_kthread_task pointer
Thread-Topic: [PATCH] rcu: Check the validity of the boost_kthread_task
 pointer
Thread-Index: AQHYP3Bozuxnyt+Oy0WTfpuy9UBnzazOsY6AgACE/YA=
Date:   Fri, 25 Mar 2022 00:00:47 +0000
Message-ID: <PH0PR11MB5880D7F86F013AE3CD799E08DA1A9@PH0PR11MB5880.namprd11.prod.outlook.com>
References: <20220324111515.1810160-1-qiang1.zhang@intel.com>
 <20220324160001.GW4285@paulmck-ThinkPad-P17-Gen-1>
In-Reply-To: <20220324160001.GW4285@paulmck-ThinkPad-P17-Gen-1>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-version: 11.6.401.20
dlp-reaction: no-action
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?J+MbkyeQsPR2WzPqM3flnVeK3j7Dg9TK0h08NoO+K+wF6+Aovh9AkpGdIgCU?=
 =?us-ascii?Q?5NXf25ikM5huLjylm2v/BkhDEafk0tMT7Y0Nb4EAY3I208AJdJmle/Xdggox?=
 =?us-ascii?Q?MYDcAJGxPaZleSgBfwb8mZ/hZp9yfVuHG5VijU0wUqw0By9iVV+y0usP9zrA?=
 =?us-ascii?Q?34W6WO2oBqg8PwMzcPHJPp791ZtG6Bn+rdQFmusJ6+qH1YqQBwJ3CNvAj6UK?=
 =?us-ascii?Q?tPvckU2cU+OU9GrtWHddKzQmxMd4KqFWPtOFVWk17MHM2SELO/nLrWdsEtW1?=
 =?us-ascii?Q?0QZSkv3LxnCFL97JfocQXHDLOAIYYT1uq9kf4iNvnjIowphjmnsBBSzJ02Wu?=
 =?us-ascii?Q?FRXpMbge3LeuuNfnzKIm3qoSQ2N0QGRRiTFuEPs7LmLOWmg7ElR+vUBoTYPP?=
 =?us-ascii?Q?be2zWQp/hhER12nYDLk8krH2u9edKv4jqOcdqhtuHc81dZxJ5Zj81axONuug?=
 =?us-ascii?Q?tUT1aGqtKZZSJqbGyU2v6EKJrpAHdHWsD22cBbEm3hNUbQiCa0Nw8ERUTxHc?=
 =?us-ascii?Q?UJMpbueP5ahgS+VMvhE7kvqcptZ3pTgNTQaNvT+6J2G32sVv+LtZp15UskCw?=
 =?us-ascii?Q?o2Eiuu0qWPpCJwrGNJPIi1hqN+rN6vctIMGmKgsvsCpZzk/wQT0pwuMYrM4g?=
 =?us-ascii?Q?8HUPtnIC9V8yu+4JIvlkWY2HxNfh+cXN6IznL9Y+YEfgzqMWAmi4v1HjtbTW?=
 =?us-ascii?Q?6f5E6vCrViDvrp9xohSozWgU7eeUMinS6UpGADl6J2IToeu8dNCZ/ymD3/UW?=
 =?us-ascii?Q?2QefSIu0XZ68n8ZdP6Mk93nWtEAXk7slc8pm0xftiQ03PoeV8uMfTX8323Ko?=
 =?us-ascii?Q?LPkSIzSClKgEox7F01sTue99i6BD34M0Zf4CBRWL3pOAgr8n4jNlJIQV/UrK?=
 =?us-ascii?Q?ufCIsY0pCUfsbxn8svNlBmW3lNKR9v/T4MOM+PSQvxsSGmIk5v9YbE6QAvps?=
 =?us-ascii?Q?rM2YI8U5neNHuPZ9fqxkHqdpZl+rl2q1VeOy4eEnHWN1rN2U1YNxGPIosJ3/?=
 =?us-ascii?Q?6RdpZ23y5EPhgz5qFr2hi4vwLcA6aFeme00envnhQv9Y+j5i7/1t9UPabLPb?=
 =?us-ascii?Q?c5e1E9ebXEMDGD0nDV8UVUzyhZemoRhaNJ0bhhtgdsBXu6XTmwbt+h7xW64a?=
 =?us-ascii?Q?fsFl1U9m7ksPLBSRaPChqRqGq56tbk5V98q9D42ZVfSD5NCtVqQDqwd+WmA3?=
 =?us-ascii?Q?NSJK2ZknVqwfQKpxiEDc26GlJwd1WUZ9jEryNsHAd/9C3SjEmA6pGmfJy3lC?=
 =?us-ascii?Q?INmlDDBK4vavue9pdvKh96aZqc0dJwoSJ11inUbS+W749oaURvwPM2hmcGEu?=
 =?us-ascii?Q?oQRXxedO4HyXBGgIbYao5sQpUgOm7Pl7KF9A8g/Yc8tDKN/K+yNfBDsmd2DZ?=
 =?us-ascii?Q?OzXk/To53LOD4k3D6t8bPjTNlR0/u+uRPWOfz/qciw5wUikocpkPQYu5aDMc?=
 =?us-ascii?Q?6Mbuh96oPtJDCe8f9pDiJtmw5zJX5EjXxwHXTXUAf/X+zfjFZO+SkbdV3LP/?=
 =?us-ascii?Q?Wq5pq9yPPQ8JA39J9SyzF8hRdYpmXRJ57J/WWzAmfHZeUDjR9o0BgqlRUoU9?=
 =?us-ascii?Q?tvJQokLZ663+lzDje0WyAy+fp0u5nvccpEkwTYuWdR74bvz7eI5B49uP1EZE?=
 =?us-ascii?Q?ZQY9KJyMed+HIjHuoC7wuEXTiDjVTrrVw5L0M6YGN/HTWNaoYz2NLj2+3q9j?=
 =?us-ascii?Q?lgJg5m6krPv2ZPWqABdLoZUUv4LkJd5Tpm7+SwltDWZuwj38CqqLWGnpc1dy?=
 =?us-ascii?Q?rPzTwVNjJA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5880.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 170f0dc4-800e-4de9-2732-08da0df28407
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Mar 2022 00:00:47.3872
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: BpM8QMnyFgnPHUs0ELV6Sd2UPYzzMsMCY9fAecLUhjQyoa0SDcbELNj++LZvE0w8XF71aFR0fzwlQSV09jUDhQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6054
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Mar 24, 2022 at 07:15:15PM +0800, Zqiang wrote:
> The boost kthreads may spawn failed, although the probability of=20
> creation failure is very low, in consideration of the robustness of=20
> the code, add boost_kthread_task pointer detection.
>=20
> Signed-off-by: Zqiang <qiang1.zhang@intel.com>
>
>Good catch!  As you say, rare, but definitely worth fixing.
>
>I could not resist a bit of wordsmithing.  Could you please check to see i=
f I messed something up?

Thanks wordsmithing, I think it's ok.

Thanks,
Zqiang

>
>							Thanx, Paul
>
>------------------------------------------------------------------------
>
>commit ad3c438e248cbc41fe30a41287621c3dbfcdf51c
>Author: Zqiang <qiang1.zhang@intel.com>
>Date:   Thu Mar 24 19:15:15 2022 +0800
>
>    rcu: Check for successful spawn of ->boost_kthread_task
>   =20
>    For the spawning of the priority-boost kthreads can fail, improbable
>    though this might seem.  This commit therefore refrains from attemotin=
g
>    to initiate RCU priority boosting when The ->boost_kthread_task pointe=
r
>    is NULL.
>   =20
>    Signed-off-by: Zqiang <qiang1.zhang@intel.com>
>    Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
>
>diff --git a/kernel/rcu/tree_plugin.h b/kernel/rcu/tree_plugin.h index 6b9=
bcd45c7b2..d58f6d6073bf 100644
>--- a/kernel/rcu/tree_plugin.h
>+++ b/kernel/rcu/tree_plugin.h
>@@ -1125,7 +1125,8 @@ static void rcu_initiate_boost(struct rcu_node *rnp,=
 unsigned long flags)
> 	__releases(rnp->lock)
> {
> 	raw_lockdep_assert_held_rcu_node(rnp);
>-	if (!rcu_preempt_blocked_readers_cgp(rnp) && rnp->exp_tasks =3D=3D NULL)=
 {
>+	if (!rnp->boost_kthread_task ||
>+	    (!rcu_preempt_blocked_readers_cgp(rnp) && !rnp->exp_tasks)) {
> 		raw_spin_unlock_irqrestore_rcu_node(rnp, flags);
> 		return;
> 	}