Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp2198168pxb; Fri, 25 Mar 2022 12:52:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy9b3lt/1uayJpwqj/lliKYazo4Hp+xUMEGq5f1BY0Im6LR5Uch4RBuNpOokreDEMGa6w/a X-Received: by 2002:a05:6a00:1acd:b0:4f7:c17b:28e5 with SMTP id f13-20020a056a001acd00b004f7c17b28e5mr11780396pfv.78.1648237966384; Fri, 25 Mar 2022 12:52:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648237966; cv=none; d=google.com; s=arc-20160816; b=aEfXQMR4mEtN9uoxZmaCXbjdQhZ4KLQb4/f6uZG3iOGwDINzBHmciSUsL0QgGZcrfV y6isTXXkTUqYyY9FOM+Vj7/Rq2Vgw7K9CzG5k5DuogNiAcz7V8nnP0CHuZjBbiekfo6C 2YltZox5IFEs/91n8odRQSYpvq/lv40mOLb/t+cmIGlEMvxSVI4Rmss31m7KvyAxP6TF gAkXZd45ReGYeEWr4PKDx/wzHTo8M6qc65CM6is8/Xu8rVwcw2L/f+VMYvKjHYkX6lNK koNDjwDwK8EV2rddmMtf16Nrs49ov5GHmN25tMDE8AYSp3Z4LgW0P7CWuHnCL66Bk2PY wcFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=TE1Fo3bYN0akxiBSSQuEaSEpaRK4HJLzffjxh5VNJoM=; b=sCLN8Nne3zLvhsTOP5nj/YLoV6bQMN91V3Pwrufh89DxQIA/NiIRWSpkyNa75bLj+H 9Joh/6L2f/aYe5twNWp6T3Ws8Fm/JOoCB2UeHf6sd6LK17ZMmxDXNOTi4cYAYKBFtmtW 1aJ0vV5s5F1SHKRk92kPNABYIiQ31/IAvOeDsmRQR3EMm+mFdNncoxWPo4QXXOD5ffrA rj0iqN8kLvNLEmKVzKW9VTLr6BZe/vnVVu5P4LbVjG31ojm3FcvOWjNR9XqJm7kQ4d4o ysPPnexkSGQkgK5sui+ihygbrlcmZP5iWYSR/Znea3fbkytfaEyrreKfGjIY9vNw5gAU 9qPw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=UWs7FddS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id s67-20020a635e46000000b003816043f0dfsi3293798pgb.724.2022.03.25.12.52.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Mar 2022 12:52:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=UWs7FddS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 486002D7ABD; Fri, 25 Mar 2022 11:41:55 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378636AbiCYPfQ (ORCPT + 99 others); Fri, 25 Mar 2022 11:35:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60242 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1377730AbiCYPYc (ORCPT ); Fri, 25 Mar 2022 11:24:32 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 76C74E0981; Fri, 25 Mar 2022 08:18:45 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id DF465B82903; Fri, 25 Mar 2022 15:18:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4C21CC340E9; Fri, 25 Mar 2022 15:18:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1648221523; bh=eFk4yBqvqHtTCOCzmb/fgcCnEPRbmh7FkU299JE65bc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UWs7FddSy8S89qmiERgQSNIgBPgEx3A0BclPzeF4FpeiHhB1p2YWxnwWd3aLuna7z B+Yyki8d4+KTtZGikl2aJNJUXWNZeC6jGUwMSBXBeUKRp8p+t1OIQIcZBmRkk+/wA5 0mhKRKZpK6tdH8bxsLh0RKy8TumpA7XHm2JlIM7o= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Lars-Peter Clausen , Takashi Iwai Subject: [PATCH 5.17 16/39] ALSA: usb-audio: Add mute TLV for playback volumes on RODE NT-USB Date: Fri, 25 Mar 2022 16:14:31 +0100 Message-Id: <20220325150420.708309299@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220325150420.245733653@linuxfoundation.org> References: <20220325150420.245733653@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Lars-Peter Clausen commit 0f306cca42fe879694fb5e2382748c43dc9e0196 upstream. For the RODE NT-USB the lowest Playback mixer volume setting mutes the audio output. But it is not reported as such causing e.g. PulseAudio to accidentally mute the device when selecting a low volume. Fix this by applying the existing quirk for this kind of issue when the device is detected. Signed-off-by: Lars-Peter Clausen Cc: Link: https://lore.kernel.org/r/20220311201400.235892-1-lars@metafoo.de Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/usb/mixer_quirks.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) --- a/sound/usb/mixer_quirks.c +++ b/sound/usb/mixer_quirks.c @@ -3360,9 +3360,10 @@ void snd_usb_mixer_fu_apply_quirk(struct if (unitid == 7 && cval->control == UAC_FU_VOLUME) snd_dragonfly_quirk_db_scale(mixer, cval, kctl); break; - /* lowest playback value is muted on C-Media devices */ - case USB_ID(0x0d8c, 0x000c): - case USB_ID(0x0d8c, 0x0014): + /* lowest playback value is muted on some devices */ + case USB_ID(0x0d8c, 0x000c): /* C-Media */ + case USB_ID(0x0d8c, 0x0014): /* C-Media */ + case USB_ID(0x19f7, 0x0003): /* RODE NT-USB */ if (strstr(kctl->id.name, "Playback")) cval->min_mute = 1; break;