Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Fri, 25 Mar 2022 14:29:12 +0800
From:   Xin Ji <xji@analogixsemi.com>
To:     Robert Foss <robert.foss@linaro.org>
Cc:     Chen-Yu Tsai <wenst@chromium.org>,
        Hsin-Yi Wang <hsinyi@chromium.org>,
        dri-devel@lists.freedesktop.org, Jonas Karlman <jonas@kwiboo.se>,
        David Airlie <airlied@linux.ie>, qwen@analogixsemi.com,
        Neil Armstrong <narmstrong@baylibre.com>,
        linux-kernel@vger.kernel.org,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        treapking@chromium.org, pihsun@chromium.org,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Andrzej Hajda <andrzej.hajda@intel.com>, tzungbi@google.com,
        bliang@analogixsemi.com
Subject: Re: [PATCH v2] drm/bridge: anx7625: Set downstream sink into normal
 status
Message-ID: <20220325062912.GA1527766@anxtwsw-Precision-3640-Tower>
References: <20220322080213.1487134-1-xji@analogixsemi.com>
 <CAJMQK-j+PhB6dZBuKG3NtW94oT0bVkp9G1bXhmyZLgYOmTCgog@mail.gmail.com>
 <20220322085208.GA1487511@anxtwsw-Precision-3640-Tower>
 <CAGXv+5Gddu8VU7xjX-r2=u85i7Ut=_6JpQV6py52OyzEkpezTg@mail.gmail.com>
 <20220322101342.GA1493353@anxtwsw-Precision-3640-Tower>
 <CAG3jFytYcLP_1JJzoTU8YcwXp8==EpPdad5z02ROu8HtuaqfzQ@mail.gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAG3jFytYcLP_1JJzoTU8YcwXp8==EpPdad5z02ROu8HtuaqfzQ@mail.gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?UaYkzOX81GE4yBOYP47hRxoxZ/ShmGrmRncslAWUZ85BY0ohF00QgKDO5L5F?=
 =?us-ascii?Q?Y4QOVCTLputynsusevzlDfeLvztd1FgmAO+hOMXqDLurR4Q0ZKniyYZVKzlk?=
 =?us-ascii?Q?NwExYEX7zwRqTWgg7woDqwMH75doFfpsOjA0qGXAsorlU9PIBcvRVPNf2rAk?=
 =?us-ascii?Q?XNUyKoBTAWawgrxNHXraS6iT9WXqoOmn1+daUkFcq8zk/wfo3TnVec0P2W6J?=
 =?us-ascii?Q?kcwhleZHR75bDJKdI4SrMsvFq3hLVMZkW86pH4/TOh6FZQmZAYGPyJBZ6O7R?=
 =?us-ascii?Q?evJDV7TLgLwCZqs/Tza27QNYCNN82QCAMB/irw0GOBLA3Lj9F0ICKUePlgGX?=
 =?us-ascii?Q?LrRs0Sr4jD1eIPEtrHlk+/Sw5nmRHMLlLU0D8jSUycZZg5oc8bRoAffwtXpg?=
 =?us-ascii?Q?8kn9JPhxXWzV7ackDdSflpqV9gJofhagwVDtWQry+qtt1V+E4ylf/RM5ZKhk?=
 =?us-ascii?Q?yl5oCnusKHD7A33X77/17iuEGKwg4H9BpVwV2pvWjfZLxrJ4sRZrx7ucJyQ+?=
 =?us-ascii?Q?m5y4mDzek7IzoDs/fOvTLvjHiQbtX5fHp6Mcl3Thqtmd8VO0K+0C1vrlUckI?=
 =?us-ascii?Q?EtixLXgZw2NLcXvboSksMa5UKI1NUBDmtiyBW9sMYaR3KM1fixNxh9qEWgdp?=
 =?us-ascii?Q?zLBYEfE3RrIpSssY/1MLBxGxOXHS6C9r96CJMm6maOcDVx7kklxfSJy8GFwF?=
 =?us-ascii?Q?rRwL2sk2ovn8qtdTlAnywrAyjBcQPW3DXdVMZnMF5g+06/P7l+Ra9pV++ZZI?=
 =?us-ascii?Q?FyygOezuxaEuk8fq2YihepnQfeNiRzPbCki39Y66WPVgZiUlpUUxebAcOEOc?=
 =?us-ascii?Q?7wEYiNdHYPFr1GtLPhZRs4g8n0aK2Iyvpf/FlS3ee5WGZYjwoFWyfw8391e5?=
 =?us-ascii?Q?Mg3RAA+x7YQVFv/6nmK8EHxVBS4/zd/FeC6k86Q/uOZLK3ucEzQTWddCQ7TA?=
 =?us-ascii?Q?gkPU57qeQvgDVEsxSSBuHzAwD1nyGRV0omf+1i65RbRvAesSltd5ZmPd52Qo?=
 =?us-ascii?Q?9ZNZf/onGdb69FyWirDsjyRTiwwc8qHOfDHORPYbtxJhXTbDxqjcPUbHzS+M?=
 =?us-ascii?Q?jHh7pEfzCWTYo7fPrzSb+Mu6T5Qr6dTFElyUXKQl+op+0UQR5t5FkQX9xpEl?=
 =?us-ascii?Q?VntgrMqiJviK8ioHjIrGYgsYtHE1NjoNv7R6AFJPpgp/8tnk/yddWR0pNgdg?=
 =?us-ascii?Q?uKTVzXT0q/NknzbKsDhF/MGcIiFU3ft2x9sUJ5+Tj+RXquF4qTGm93IrUI7F?=
 =?us-ascii?Q?M4ZqFTngYznT1mclZ1wbJZ/hbpgCVNl2hNHgI25jYp6f3X0F6N4cY3mEjLUn?=
 =?us-ascii?Q?+XMpJoB5/pxynITjpDlH9khEkJerYtH9mgF4iI4PReUQCs2S+rjD0hLin+j4?=
 =?us-ascii?Q?kxwUp1m0TQQ2S249zkxQrA62ibPC3SAtXIVsFDy/uo6bfYnYoX4X7hpxf2K1?=
 =?us-ascii?Q?o8oB5N1FMZOBjkhrzttzbqXGr13l54eK?=
X-OriginatorOrg: analogixsemi.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c67a0c08-164c-42a4-bf52-08da0e28cb48
X-MS-Exchange-CrossTenant-AuthSource: BY5PR04MB6739.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Mar 2022 06:29:20.2588
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: b099b0b4-f26c-4cf5-9a0f-d5be9acab205
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5WM77Rsyt8t3qq+uw5IdE6VVdPc3Kzxxtz1fEwE5ORlqIIFzsaBYxaX5OWmop+2cbKS9XzHgYogYAYq2NauOvg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR04MB4246
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE,
	SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Mar 24, 2022 at 01:07:56PM +0100, Robert Foss wrote:
> > > > > The driver uses DRM_DEV_* for logs. Can we use this?
> > > > Hi Hsin-Yi, as comment in drm/drm_print.h:
> > > > "NOTE: this is deprecated in favor of drm_dbg". DRM bridge driver not
> > > > use DRM_DEV_* any more. I'll send a patch to replace all of DRM_DEV_*
> > > > later.
> > >
> > > drm_dbg is better than dev_dbg though. With the former, you still get the
> > > option to control it with the drm.debug module parameter, unlike the latter
> > > which normally gets compiled out.
> > >
> > > Please use drm_dbg*.
> > >
> > > ChenYu
> >
> > Hi ChenYu, the parameter of drm_dbg is "drm", if use drm_dbg, it will
> > change more code, I'll consider to upstream new patch to replace all of
> > them later.
> >
> 
> Alright, since the driver already uses these logging functions, let's
> apply this patch and fix the logging function this driver uses in a
> separate series.
> 
> Xin: Can you submit a patch/series that converts this driver to use
> drm_dbg* functions instead?
Hi Robert Foss, OK, I'll submit patch after this patch get merged.
Thanks,
Xin