Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
MIME-Version: 1.0
References: <PAXPR04MB9186D7B361F9FFE56A0AE69C88039@PAXPR04MB9186.eurprd04.prod.outlook.com>
 <CA+V-a8t2=MRObzdjHM9OUE8LzQXqoiLo-T+D3i1fLAOaneESpw@mail.gmail.com> <PAXPR04MB91866AB1474C9F9F2CB15B7A88039@PAXPR04MB9186.eurprd04.prod.outlook.com>
In-Reply-To: <PAXPR04MB91866AB1474C9F9F2CB15B7A88039@PAXPR04MB9186.eurprd04.prod.outlook.com>
From:   "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Date:   Fri, 25 Mar 2022 17:13:02 +0000
Message-ID: <CA+V-a8u-KQSdTFNDKYJBL=1c2xtDraVAyqeNtTT-eFMWjYBtKQ@mail.gmail.com>
Subject: Re: [EXT] Re: [RFC PATCH 0/5] PCIe EPF support for internal DMAC
 handling and driver update for R-Car PCIe EP to support DMAC
To:     Kishon Vijay Abraham I <kishon@ti.com>
Cc:     Frank Li <frank.li@nxp.com>, Bjorn Helgaas <bhelgaas@google.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
        Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
        =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= <kw@linux.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Marek Vasut <marek.vasut+renesas@gmail.com>,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
        Rob Herring <robh@kernel.org>,
        linux-pci <linux-pci@vger.kernel.org>,
        Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Biju Das <biju.das.jz@bp.renesas.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Kishon,

On Wed, Mar 2, 2022 at 6:28 PM Frank Li <frank.li@nxp.com> wrote:
>
>
>
> > -----Original Message-----
> > From: Lad, Prabhakar <prabhakar.csengg@gmail.com>
> > Sent: Wednesday, March 2, 2022 11:18 AM
> > To: Frank Li <frank.li@nxp.com>
> > Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>; Lad Prabh=
akar
> > <prabhakar.mahadev-lad.rj@bp.renesas.com>; Kishon Vijay Abraham I
> > <kishon@ti.com>; Bjorn Helgaas <bhelgaas@google.com>; Lorenzo Pieralisi
> > <lorenzo.pieralisi@arm.com>; Krzysztof Wilczy=C5=84ski <kw@linux.com>; =
Arnd
> > Bergmann <arnd@arndb.de>; Greg Kroah-Hartman <gregkh@linuxfoundation.or=
g>;
> > Marek Vasut <marek.vasut+renesas@gmail.com>; Yoshihiro Shimoda
> > <yoshihiro.shimoda.uh@renesas.com>; Rob Herring <robh@kernel.org>; linu=
x-
> > pci <linux-pci@vger.kernel.org>; Linux-Renesas <linux-renesas-
> > soc@vger.kernel.org>; LKML <linux-kernel@vger.kernel.org>; Biju Das
> > <biju.das.jz@bp.renesas.com>
> > Subject: [EXT] Re: [RFC PATCH 0/5] PCIe EPF support for internal DMAC
> > handling and driver update for R-Car PCIe EP to support DMAC
> >
> > Caution: EXT Email
> >
> > Hi Frank,
> >
> > On Wed, Mar 2, 2022 at 3:42 PM Frank Li <frank.li@nxp.com> wrote:
> > >
> > >
> > >
> > > > -----Original Message-----
> > > > From: Lad, Prabhakar <prabhakar.csengg@gmail.com>
> > > > Sent: Thursday, February 10, 2022 3:24 AM
> > > > To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > > > Cc: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>; Kishon
> > Vijay
> > > > Abraham I <kishon@ti.com>; Bjorn Helgaas <bhelgaas@google.com>; Lor=
enzo
> > > > Pieralisi <lorenzo.pieralisi@arm.com>; Krzysztof Wilczy=C5=84ski
> > <kw@linux.com>;
> > > > Arnd Bergmann <arnd@arndb.de>; Greg Kroah-Hartman
> > > > <gregkh@linuxfoundation.org>; Marek Vasut
> > <marek.vasut+renesas@gmail.com>;
> > > > Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>; Rob Herring
> > > > <robh@kernel.org>; linux-pci <linux-pci@vger.kernel.org>; Linux-Ren=
esas
> > > > <linux-renesas-soc@vger.kernel.org>; LKML <linux-
> > kernel@vger.kernel.org>;
> > > > Biju Das <biju.das.jz@bp.renesas.com>
> > > > Subject: [EXT] Re: [RFC PATCH 0/5] PCIe EPF support for internal DM=
AC
> > > > handling and driver update for R-Car PCIe EP to support DMAC
> > >
> > > I use standard DMA engine API to implement Designware PCIE EP embedde=
d
> > DMA support.
> > > Please check
> > https://eur01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Flor=
e.kern
> > el.org%2Fall%2F20220302032646.3793-3-
> > Frank.Li%40nxp.com%2FT%2F&amp;data=3D04%7C01%7Cfrank.li%40nxp.com%7C0e2=
e5fe8f
> > d224076afb208d9fc70aa16%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63=
7818
> > 383096028914%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMz=
IiLC
> > JBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=3DDCDX%2BYEVFsPOE6ZWzwrMx=
k1Fjlk
> > ZA%2FEPGmhQSHuPB2c%3D&amp;reserved=3D0
> > >
> > Thank you for the link. The Designware PCIE EP is implemented as a DMA
> > engine driver so it's convenient to use the DMA engine API, whereas
> > the R-Car PCIe-EP is implemented as an actual PCIe EP [0].
>
> My means, needn't add new interface pci_epf_internal_dmac_xfr at epc/epf.
> Your R-Car PCI-EP DMA part can implement as a dma engine driver like desi=
gnware.
>
> So EP functional driver use the same method to operate DMA regardless
> EP controller type.
>
With this approach all the PCIe controllers supporting internal dmac
will have to be added as a DMA driver.

Could you please provide some feedback on the above?

Sorry this mail is not in chain to my orignal patch series. My orignal
series can be found at [0]

[0] https://patchwork.kernel.org/project/linux-renesas-soc/cover/2022012619=
5043.28376-1-prabhakar.mahadev-lad.rj@bp.renesas.com/

Cheers,
Prabhakar