Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Wed, 23 Mar 2022 21:37:13 +0100
From:   Petr Vorel <petr.vorel@gmail.com>
To:     Konrad Dybcio <konrad.dybcio@somainline.org>
Cc:     ~postmarketos/upstreaming@lists.sr.ht, martin.botka@somainline.org,
        angelogioacchino.delregno@somainline.org,
        marijn.suijten@somainline.org, jamipkettunen@somainline.org,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Bastian =?iso-8859-2?Q?K=F6cher?= <mail@kchr.de>,
        Jeremy McNicoll <jeremymc@redhat.com>,
        linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: qcom: gcc-msm8994: Fix gpll4 width
Message-ID: <YjuE+cgGXCLihPIa@pevik>
Reply-To: Petr Vorel <petr.vorel@gmail.com>
References: <20220319174940.341137-1-konrad.dybcio@somainline.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220319174940.341137-1-konrad.dybcio@somainline.org>
Precedence: bulk

Hi Konrad,

Reviewed-by: Petr Vorel <petr.vorel@gmail.com>


> The gpll4 postdiv is actually a div4, so make sure that Linux is aware of
> this.

> This fixes the following error messages:

> [    0.804491] mmc1: Card appears overclocked; req 200000000 Hz, actual 343999999 Hz
> [    0.805057] mmc1: Card appears overclocked; req 400000000 Hz, actual 687999999 Hz
yes, this works on my patchset [1] even without these workarounds (I'll submit
v5 without it)

+	assigned-clocks = <&gcc GPLL4_EARLY>;
+	assigned-clock-rates = <384000000>;

Tested-by: Petr Vorel <petr.vorel@gmail.com>

Kind regards,
Petr

[1] https://lore.kernel.org/linux-arm-msm/20220218203710.895-1-petr.vorel@gmail.com/

> Fixes: aec89f78cf01 ("clk: qcom: Add support for msm8994 global clock controller")

> Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>
> ---
> Cc: Petr Vorel <petr.vorel@gmail.com>

>  drivers/clk/qcom/gcc-msm8994.c | 1 +
>  1 file changed, 1 insertion(+)

> diff --git a/drivers/clk/qcom/gcc-msm8994.c b/drivers/clk/qcom/gcc-msm8994.c
> index f09499999eb3..6b702cdacbf2 100644
> --- a/drivers/clk/qcom/gcc-msm8994.c
> +++ b/drivers/clk/qcom/gcc-msm8994.c
> @@ -77,6 +77,7 @@ static struct clk_alpha_pll gpll4_early = {

>  static struct clk_alpha_pll_postdiv gpll4 = {
>  	.offset = 0x1dc0,
> +	.width = 4,
>  	.regs = clk_alpha_pll_regs[CLK_ALPHA_PLL_TYPE_DEFAULT],
>  	.clkr.hw.init = &(struct clk_init_data){
>  		.name = "gpll4",