Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp2224384pxb; Fri, 25 Mar 2022 13:22:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxatrPU3F+i+POE5kZi7lkny0LOndFyH5HeLQLbk6W39V/pRAl3J2ngdIeruvNzeSRZucUP X-Received: by 2002:a17:90b:1e01:b0:1c6:cabc:b2d4 with SMTP id pg1-20020a17090b1e0100b001c6cabcb2d4mr14870337pjb.64.1648239778166; Fri, 25 Mar 2022 13:22:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648239778; cv=none; d=google.com; s=arc-20160816; b=nRM6RpVeUx7+dGr63BeyQCjIHyBb8lD5RlrLxHoWNqI0KZ28IMHG4LMXEQiZdLPJU2 y+GjSjH9g7oiYpuj8fkgjFBL6/gI1rmWEeTW/tazi8Nf5JwqpA47lDMN9nzoRIiqwORd gJ7GgDjx+TNo98tblvjiSuAUOYquo+/eQNdlCmZVgZdb95u8dYlKvP7ml7e99MZbbdYh MQxTWyJ56ReMV5vEMhz/tAm2+lUXCg3NEOxGKDU+g6LJmnHh3sptytfyPUjTCfKWpGXp bSoOdsFlb8hQ4Y2KAyNtW9bhVZmgTm+W8T/gnVE4EgW5hnk575SVZumgvyaHlDtM1Yhr 2mhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=mMfFQHUnMg0S5gwaDqoNxPrby/mA1FHHq+MNDUnHb+k=; b=T7AyQOaZHEYlBjuIBpj+px8MDO6ublx0BZGUKWwYFW/ArLmkZzS6mzG3pKVLkKR0/E t9y8IsxXGlJa6C8qoHD5hSS10ep22ddmSkHSDJYnT94KSNwGKs87ihQuXfceaG3XO9z6 ecZBL4qzeRIKMzU+DDeYl9t6G2s93hqUouScPTXy2JkJWhbQRAEyo9eC5/huAFq9UWjp reUrwV15BP2LHCewfloy8ZW8nMWY5ocL61Y1a52kthKsfTirgy8kw1Qd4BhkVa+uuA4u NzMfAPoPK2LTGjjsHJrLLsgOFXIv5leC677UfnWREoGNuJ0tKNwUk73/k06/xaYXcniP DmNw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=o798N7Gk; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id j75-20020a636e4e000000b003816043eee1si2981234pgc.214.2022.03.25.13.22.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Mar 2022 13:22:58 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=o798N7Gk; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 3312433E97C; Fri, 25 Mar 2022 12:32:32 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230326AbiCYTcl (ORCPT + 99 others); Fri, 25 Mar 2022 15:32:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51118 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230090AbiCYTcc (ORCPT ); Fri, 25 Mar 2022 15:32:32 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 747492D8131 for ; Fri, 25 Mar 2022 12:07:08 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 797F161C2E for ; Fri, 25 Mar 2022 18:18:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C9832C2BBE4; Fri, 25 Mar 2022 18:18:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648232333; bh=mfPWDhUfqbiFXpRrbs4H8Twleo93bChDmAXbKA3DZOI=; h=From:To:Cc:Subject:Date:From; b=o798N7GkFeIXVrWFHPZUaHG9jCRy9jMmPaypZ7TWckJNbKHKJvdpAefwEJlRnIRBQ ITBtHfs5ESK7wul7zx+DUIF/lpqKYsNODukV5/gruejEdwJVvd2To2a2kyPkInlHfj SdAEtxVnnnn9ELw8VCyZNaVjss5B+4Yp74WsOC+KB40iW3k1DcSm9IRHArs41771/3 9cw5YkPzpKXCu0/8iFlgQLZlAggXEo4VTrcKOjfpjRYv/0ulhS3lKKYF8c7Dmn+w2p NsxEmt1rRdGOQshTgTtmTk7tngCAMIWTYVr1yQPZUFyOof/0T4b80t3pINYH5p6K4A eg/uP/F/HVn9w== From: Jaegeuk Kim To: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Cc: Jaegeuk Kim , Linus Torvalds Subject: [PATCH] f2fs: remove unnecessary f2fs_lock_op in f2fs_new_inode Date: Fri, 25 Mar 2022 11:18:50 -0700 Message-Id: <20220325181850.513023-1-jaegeuk@kernel.org> X-Mailer: git-send-email 2.35.1.1021.g381101b075-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This can be removed, since f2fs_alloc_nid() actually doesn't require to block checkpoint and __f2fs_build_free_nids() is covered by nm_i->nat_tree_lock. Suggested-by: Linus Torvalds Signed-off-by: Jaegeuk Kim --- fs/f2fs/namei.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c index 5ed79b29999f..816285414564 100644 --- a/fs/f2fs/namei.c +++ b/fs/f2fs/namei.c @@ -37,13 +37,10 @@ static struct inode *f2fs_new_inode(struct user_namespace *mnt_userns, if (!inode) return ERR_PTR(-ENOMEM); - f2fs_lock_op(sbi); if (!f2fs_alloc_nid(sbi, &ino)) { - f2fs_unlock_op(sbi); err = -ENOSPC; goto fail; } - f2fs_unlock_op(sbi); nid_free = true; -- 2.35.1.1021.g381101b075-goog