Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <bc63e39f-33dd-0633-f72d-df08ece23684@oracle.com>
Date:   Fri, 25 Mar 2022 15:18:52 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [PATCH v2] xen: fix is_xen_pmu()
Content-Language: en-US
To:     Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org,
        x86@kernel.org, linux-kernel@vger.kernel.org
Cc:     Stefano Stabellini <sstabellini@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "H. Peter Anvin" <hpa@zytor.com>,
        =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= 
        <marmarek@invisiblethingslab.com>
References: <20220325142002.31789-1-jgross@suse.com>
From:   Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <20220325142002.31789-1-jgross@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TmxTZ01JeDNrNlJWMkYvTlpKNnF4RWpZcWJaM1lrRElyWU5FTHpqeitHcUNj?=
 =?utf-8?B?cnlBcmFaUXpCOVlnbGV0M0t2WVJQd21ackthVDFiNG81K1RNc0lmKzRiemhp?=
 =?utf-8?B?b3JRT1oxakVsM0R4TWZNekNpN1FjYWdsOUU1UHNadFQ5WURSMG5jQjBJcS9U?=
 =?utf-8?B?TjdQVDA4WHJwbHVQWW4yandHVG5NeFB3VUM2M3djTHExalVjc0FPdzVJcGpH?=
 =?utf-8?B?SEVzM0VwclhvVzRIaFEvNFVqcC9GbHZPdHVVWThUNUhBRlk0cGgrc1M5cU5F?=
 =?utf-8?B?bzRkcVJ0QjdpZWxvUGZINHpzUWZ6R0R0QVN5ZnlLYWQvSVVzbHovQ2k3dldY?=
 =?utf-8?B?bFcvbUtHVW9oRG0wbDlOTFdoOWR5aVNuN2ZvMGZERFJ1ZHlZSnZIdGRtd0pU?=
 =?utf-8?B?QTFPZ2RVWmprNERGd25LV2ZJa3BZWGdFbFI0blhHWHhqYXpZWDFkQkZ0VkRx?=
 =?utf-8?B?OFZqUkFtOTlFeXhlZVBKL2dWSkZSN1ppdlppOWNqTjRBWEhvZ1ZMdHVxWnoz?=
 =?utf-8?B?NExUb2tweTBHRTZ1TFVrZ0lJTFhnRFpwRVVxSk9VZ0l0SU1pTG9MVFNSRkdX?=
 =?utf-8?B?RVFHMDRaTWRPZVp1UDVhOVF5NzRxMXFLVVpRdFpCeG9NRHJJU2ZvRWZpcFZu?=
 =?utf-8?B?L0gvNUp1dXZ4Tmc3OTlXTEhxZ2ZtMGlWcjl2ZHIrc3B5VFZXYlArSi93RmxV?=
 =?utf-8?B?ZWZzMVNrY0NPVUR5OGovdmNHdkVYYnR5bUFuMTdPMWYzR1d6M0cyK3FWZnRS?=
 =?utf-8?B?L2ZDeVltSk9NRjU2K2xFKzByZnd0RjQ5U2Vsd25LZHF4c2VQMmhYZ3pub0dr?=
 =?utf-8?B?cGVEQklrMFRHQk5sVWdFcXZhcExWb3Mrb2ozUDVVV2dKOXlBWGZQMlZ6Y3VL?=
 =?utf-8?B?aHVXRG9tQWErQXM0Skl4R2JHTnNxNU9JWDB4N3YyOFQrV3R6N200K2ZuMDRE?=
 =?utf-8?B?SmZtRVc5WnllZVBHK2xxSUF2VEI3UWlRVWxEVmJ6UlBrL1NGN2UwR2FXQWc3?=
 =?utf-8?B?djRlUUM1ZndCMTJ3bmp6RTRmd0x3UWZsbEZ3NmRkNkZsalI0MTJ0bHJNeGlY?=
 =?utf-8?B?VE9EdUtuZ3RhV2VncDcxS2l6bmVtcFVVL04wSkgvZ041TDczdmgxU1FVZnFO?=
 =?utf-8?B?VzRNbTRJTndyRGtEbUNVTTB4MjRla21iNW1Qay9pTU0yTHJiL1U2UG1LNk5S?=
 =?utf-8?B?eGVncVE2cDVHZDhtRWlLcG45TkhwaEt6bmtodWpDT2svNVN6bzhMU2owTC9T?=
 =?utf-8?B?eDdHZTFkVGF6b2M4RzVFcTIzYTZLRE03anpVek9WZHIvY0tWNFFLV2gvdTZk?=
 =?utf-8?B?RGRBRkRMcUF1VHk4NVYzSVlyWDdLSEY1UVlnYmR2VGFSUUVGMVdIQko4eHZz?=
 =?utf-8?B?S1dBK0FSVWk2OVFRZWFid3JEZThYNGNzSWpTcjdmMEQ1eFFRWTVUWDZHK2pZ?=
 =?utf-8?B?b3ovdStZVE1IdzNwMGhmNFEwbG0rTnFwMVl0Y0lXRkhnczJGZS93emdsNGZV?=
 =?utf-8?B?b2cyMVZRMmxHUE9QeHNIZ2ZxS1VOdW5zSjZYRXlqVlNnTWloYjlWdC9xSUlN?=
 =?utf-8?B?dlJqamNtVGUveDM0U1I5L3dtSXlPREFqRE5uY2h4eXRwTk5yaXQrS1lkSmpq?=
 =?utf-8?B?a29yMi9qZVh0Zi90bEEvNDdCa012dE5RdnhUdEFaYTI3UEtRVVNOMzBvZ1c0?=
 =?utf-8?B?WC9IMGhsUkV4TEtyckZ3ZmZNcFBSVVE4MU1CVlhtbzVxZkczUG1WWEFLSWY0?=
 =?utf-8?B?WDFiNlRhR3VHM1hONHY0K1NWNDVKbkg5M2hYb01OZzdyYlFtaEwzemNlaCtk?=
 =?utf-8?B?NFRxRDRuUFZsWWIrQkIzMVFSR3gxUW1ydTFaOU02RzV3ekw4Rkxtc0FEMzgv?=
 =?utf-8?B?K0Q3bU1iQ2w2eFpFc0ZsbVdHTCt1VVFjQkpvV1Y5MDdpZVZjd3NKekNrTE95?=
 =?utf-8?B?K1hScCtLMmI5WmFmNTNZNlJlRHorbFI2NGdEL3FZRnN0Zi8raXlXSk5vaDBs?=
 =?utf-8?B?V0Mrc21qUGFBPT0=?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1152988c-f18f-4c33-5273-08da0e944ea2
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Mar 2022 19:18:56.4961
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9lg5DXlRYHdM7/LLSHOqS2vlsgMFn4kxQ3uMPMKm3wDt1n5AFTxhV9Kow4wufriVRJa6tAN1W3LJd6PKJwefbbSl/PWHVUVGttXAMgtzdl0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR10MB3473
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10297 signatures=694973
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 phishscore=0
 mlxlogscore=999 adultscore=0 suspectscore=0 malwarescore=0 spamscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2203250106
X-Proofpoint-GUID: 6HFzpSig4kPhgDHJ4UKFromS15xH2F46
X-Proofpoint-ORIG-GUID: 6HFzpSig4kPhgDHJ4UKFromS15xH2F46
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 3/25/22 10:20 AM, Juergen Gross wrote:
> is_xen_pmu() is taking the cpu number as parameter, but it is not using
> it. Instead it just tests whether the Xen PMU initialization on the
> current cpu did succeed. As this test is done by checking a percpu
> pointer, preemption needs to be disabled in order to avoid switching
> the cpu while doing the test. While resuming from suspend() this seems
> not to be the case:
>
> [   88.082751] ACPI: PM: Low-level resume complete
> [   88.087933] ACPI: EC: EC started
> [   88.091464] ACPI: PM: Restoring platform NVS memory
> [   88.097166] xen_acpi_processor: Uploading Xen processor PM info
> [   88.103850] Enabling non-boot CPUs ...
> [   88.108128] installing Xen timer for CPU 1
> [   88.112763] BUG: using smp_processor_id() in preemptible [00000000] code: systemd-sleep/7138
> [   88.122256] caller is is_xen_pmu+0x12/0x30
> [   88.126937] CPU: 0 PID: 7138 Comm: systemd-sleep Tainted: G        W         5.16.13-2.fc32.qubes.x86_64 #1
> [   88.137939] Hardware name: Star Labs StarBook/StarBook, BIOS 7.97 03/21/2022
> [   88.145930] Call Trace:
> [   88.148757]  <TASK>
> [   88.151193]  dump_stack_lvl+0x48/0x5e
> [   88.155381]  check_preemption_disabled+0xde/0xe0
> [   88.160641]  is_xen_pmu+0x12/0x30
> [   88.164441]  xen_smp_intr_init_pv+0x75/0x100
>
> Fix that by replacing is_xen_pmu() by a simple boolean variable which
> reflects the Xen PMU initialization state on cpu 0.
>
> Modify xen_pmu_init() to return early in case it is being called for a
> cpu other than cpu 0 and the boolean variable not being set.
>
> Fixes: bf6dfb154d93 ("xen/PMU: PMU emulation code")
> Reported-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
> Signed-off-by: Juergen Gross <jgross@suse.com>


Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>