Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220315083723.97822-1-krzysztof.kozlowski@canonical.com> <CACRpkdZATQubzrzqq2b4VY+W3Pb9RfzOGRiF+34YhEqpSKyUZg@mail.gmail.com>
In-Reply-To: <CACRpkdZATQubzrzqq2b4VY+W3Pb9RfzOGRiF+34YhEqpSKyUZg@mail.gmail.com>
From:   Krzysztof Kozlowski <krzk@kernel.org>
Date:   Sat, 26 Mar 2022 09:05:33 +0100
Message-ID: <CAJKOXPdyDeCozev=AqSnS-E0Cvc6BjXysV70vm0eaSnwN6eB3w@mail.gmail.com>
Subject: Re: [PATCH] dt-bindings: gpio: add common consumer GPIO lines
To:     Linus Walleij <linus.walleij@linaro.org>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
        Bartosz Golaszewski <brgl@bgdev.pl>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzk+dt@kernel.org>,
        linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, 26 Mar 2022 at 01:28, Linus Walleij <linus.walleij@linaro.org> wrote:
>
> On Tue, Mar 15, 2022 at 9:37 AM Krzysztof Kozlowski
> <krzysztof.kozlowski@canonical.com> wrote:
>
> > Typical GPIO lines like enable, powerdown, reset or wakeup are not
> > documented as common, which leads to new variations of these (e.g.
> > pwdn-gpios).  Add a common schema which serves also as a documentation
> > for preferred naming.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>
> I like the idea!
>
> > +  enable-gpios:
> > +    $ref: /schemas/types.yaml#/definitions/phandle-array
> > +
> > +  reset-gpios:
> > +    $ref: /schemas/types.yaml#/definitions/phandle-array
> > +
> > +  powerdown-gpios:
> > +    $ref: /schemas/types.yaml#/definitions/phandle-array
> > +
> > +  pwdn-gpios:
> > +    $ref: /schemas/types.yaml#/definitions/phandle-array
> > +    description: Use powerdown-gpios
> > +    deprecated: true
> > +
> > +  wakeup-gpios:
> > +    $ref: /schemas/types.yaml#/definitions/phandle-array
>
> I would underscore either on each one or in a global description:
> that lines on components that indicate they are active low
> such as RESETN, RESET* etc MUST have the flag in the
> second cell set to GPIO_ACTIVE_LOW.

Sure, I'll add it.

Best regards,
Krzysztof