Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp2732122pxb; Sat, 26 Mar 2022 03:05:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxtPSvfjIcS79hAAkheZTJ6LygILPgdlFWl/oWF5DU8oged2qph5S9Rci9U71CYnk8125a4 X-Received: by 2002:a17:902:7c17:b0:154:a51a:d285 with SMTP id x23-20020a1709027c1700b00154a51ad285mr16013124pll.158.1648289111369; Sat, 26 Mar 2022 03:05:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648289111; cv=none; d=google.com; s=arc-20160816; b=IJ5q/Wa0yXynFpMUeJsdqegVFP8v9Bx0JWICYs7Dy52AAKQso2sAtVFKpAhnuJ59pU OBdLMhWT5cb6jfSrFnzYp8N7/pKi8Wpmte19JwpjGZx2nBYYhq8arRNMNgkOMPkRWtSl rq1Yana9pnw+Y2aY5Ylu0fEbPNEpa5yviqid2QyJMG9YGRleNOqQL3fdU7tu8KewOuYi zw7zOE0n1Ql+yGgeT+dS5Gmq7CYyDNESISf3lBi8AFll9I9x5LHQja5Nn/iKut+u8U3H 8IFmCoq4EmP55dbA/jMv6PgD+WueUHhxtTX0kUP0nUL6+My/Vf/NWBLaCqnsXONk1hs8 QK6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=0xppcPjcYerEsTF1eOYNx9qoWMzhzQnluc7NtolKlLc=; b=0Z7W/SvNvlZ/n97AS/aC4bWUHzTBjMRUEcamC+prOnm9B8y1U2XPlmf271BuPvrp/e uNeu9lrbcKtB/vlutRCrPtV6Me+RXKcCo4QPaqsYH7iGl6fxyFEVTbh699kQzpd1dloQ XRdgPORPL//TkxXzfUyJ4btw9QgNfYcTifF6vBISCGAN1Gsy78w9CiehCoQfqhzVvIgS +VQAnMtLTHMnWjnlfLb2kiYa0zBVRCjUveoTGRmkPy5Hqw0MoJRMFFhH7ARbRJ9sJOWh x/99F6UWAqk9UI5KZRAZ8ndl3hN2L9I4AJyZOpoR6eFSUj+QRc4uWjoNwd8FndHGs8P1 CSaw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id kb4-20020a17090ae7c400b001bf57214400si6090997pjb.115.2022.03.26.03.04.57; Sat, 26 Mar 2022 03:05:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231811AbiCZHZu (ORCPT + 99 others); Sat, 26 Mar 2022 03:25:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52858 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230024AbiCZHZs (ORCPT ); Sat, 26 Mar 2022 03:25:48 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 025EADAFC5 for ; Sat, 26 Mar 2022 00:24:11 -0700 (PDT) Received: from dggpemm500020.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4KQVlD2HRqzCrGV; Sat, 26 Mar 2022 15:22:00 +0800 (CST) Received: from dggpemm500007.china.huawei.com (7.185.36.183) by dggpemm500020.china.huawei.com (7.185.36.49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Sat, 26 Mar 2022 15:24:09 +0800 Received: from huawei.com (10.175.103.91) by dggpemm500007.china.huawei.com (7.185.36.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Sat, 26 Mar 2022 15:24:09 +0800 From: Yang Yingliang To: , CC: , , Subject: [PATCH] drm/bridge: anx7625: add missing destroy_workqueue() in anx7625_i2c_probe() Date: Sat, 26 Mar 2022 15:33:26 +0800 Message-ID: <20220326073326.3389347-1-yangyingliang@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.103.91] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpemm500007.china.huawei.com (7.185.36.183) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add the missing destroy_workqueue() before return from anx7625_i2c_probe() in the error handling case. Fixes: adca62ec370c ("drm/bridge: anx7625: Support reading edid through aux channel") Signed-off-by: Yang Yingliang --- drivers/gpu/drm/bridge/analogix/anx7625.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c index 31ecf5626f1d..1895e3448c02 100644 --- a/drivers/gpu/drm/bridge/analogix/anx7625.c +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c @@ -2654,7 +2654,7 @@ static int anx7625_i2c_probe(struct i2c_client *client, if (ret) { if (ret != -EPROBE_DEFER) DRM_DEV_ERROR(dev, "fail to parse DT : %d\n", ret); - return ret; + goto free_wq; } if (anx7625_register_i2c_dummy_clients(platform, client) != 0) { @@ -2669,7 +2669,7 @@ static int anx7625_i2c_probe(struct i2c_client *client, pm_suspend_ignore_children(dev, true); ret = devm_add_action_or_reset(dev, anx7625_runtime_disable, dev); if (ret) - return ret; + goto free_wq; if (!platform->pdata.low_power_mode) { anx7625_disable_pd_protocol(platform); -- 2.25.1