Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 26 Mar 2022 09:43:27 +0000
From:   Wei Yang <richard.weiyang@gmail.com>
To:     Miaohe Lin <linmiaohe@huawei.com>
Cc:     akpm@linux-foundation.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: compaction: use helper isolation_suitable
Message-ID: <20220326094327.hofczncyzqyrxdxw@master>
Reply-To: Wei Yang <richard.weiyang@gmail.com>
References: <20220322110750.60311-1-linmiaohe@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220322110750.60311-1-linmiaohe@huawei.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Precedence: bulk

On Tue, Mar 22, 2022 at 07:07:50PM +0800, Miaohe Lin wrote:
>Use helper isolation_suitable to check whether page is suitable to isolate
>to simplify the code. Minor readability improvement.
>
>Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>

Reviewed-by: Wei Yang <richard.weiyang@gmail.com>

>---
> mm/compaction.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/mm/compaction.c b/mm/compaction.c
>index c3e37aa9ff9e..86f34053c39d 100644
>--- a/mm/compaction.c
>+++ b/mm/compaction.c
>@@ -899,7 +899,7 @@ isolate_migratepages_block(struct compact_control *cc, unsigned long low_pfn,
> 		 * not falsely conclude that the block should be skipped.
> 		 */
> 		if (!valid_page && IS_ALIGNED(low_pfn, pageblock_nr_pages)) {
>-			if (!cc->ignore_skip_hint && get_pageblock_skip(page)) {
>+			if (!isolation_suitable(cc, page)) {
> 				low_pfn = end_pfn;
> 				page = NULL;
> 				goto isolate_abort;
>-- 
>2.23.0

-- 
Wei Yang
Help you, Help me