Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp3374143pxb; Sat, 26 Mar 2022 17:47:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwFpiiL46nPEVbKYd1QNr6IJImDPEwRZ9tL1aAM7O6Ap9ZSy1Qy6D3KTwYOnJHljXJJjLaN X-Received: by 2002:a17:903:22c6:b0:154:4156:f397 with SMTP id y6-20020a17090322c600b001544156f397mr19290127plg.29.1648342041516; Sat, 26 Mar 2022 17:47:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648342041; cv=none; d=google.com; s=arc-20160816; b=G50lwJDMnNa6CbXvkhQX5cgCed+33e5iqRdjuZ2vanKLtIpVOQyJHgoGNrAbj+1BWG MEnk+5c2iT17z8PEOReEuHuYznHYElmO2R7iZDzd1yYHCty6AiVu22BINhVs/XeahXdB +L1KSUXpxNK14Bo8HD8oTqVjJCT//iJx3CUIU7/u1gR2pZVPLU3Y866JKi+bgOAX1Ga/ G30djRBuFodfgFn9C3uc3V3ZEB40lqXnmLkwvaM1JGO+MBcCzJnC7HKgpH+t3uR6/DV+ Vw++wcsc0o4Jss/mPuZqUwpqDfdkJoVnkdBBKPeuEuPXfMO/rBz1hnILK+d2PZmbSgdh WnGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=1bFUegqYT8k2poPh+xdDZvwTixg5gnF0UeprrNhFoVk=; b=K9JgwYDyYEMDm0R+jOaa5azPw5Gbxd5E/wHapN8jwQzaAvy27MCS1LKittvuv4qLrC SsZbLjcD329eJHY6UVxsoDJ00IKKyX0XyGdCnjdO2R63DpoID94Jh2VyFPhIVxdNVCgE PgyBabX+2zQ6SNnoV0Hr8Q663nJ/LsDQ2jjcfdMaXaWEVOfPA8FHUZuQaBbDjo7kIWYA tGt4lHqarzIAADfgPfCpOCbRntxWjtfWH4ejkxZAdryGNruAOZsEhjT+n+nwNGABBE0h /+x+XmCgNBoQCAxxxPI+oNzLj5CEM82WGg+jZe8YzDwvjUKlK9eQgIKCCAkxxu3q7Joo AI8Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=rXVumBjY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m13-20020a170902f64d00b00155fd90f30fsi2259391plg.299.2022.03.26.17.46.56; Sat, 26 Mar 2022 17:47:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=rXVumBjY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232135AbiCZIm5 (ORCPT + 99 others); Sat, 26 Mar 2022 04:42:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40636 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229491AbiCZImz (ORCPT ); Sat, 26 Mar 2022 04:42:55 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A4FE495A16 for ; Sat, 26 Mar 2022 01:41:18 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 570DBB80159 for ; Sat, 26 Mar 2022 08:41:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 362B5C2BBE4; Sat, 26 Mar 2022 08:41:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648284076; bh=MzvQcR96gyo7RqQQpE892/lFN19x54FxFHC5aLVYzKw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=rXVumBjYyJgGoDJQvG0zZZrIvOjRYcNSmF9H+qWFcfBXO6sc0IFlQKcEXJczfuhoH 1Zp/RMudRTfydYWOjbLhkv27ZlBT2GU6glq06x7b1SGqZwxb1gApbpNaYEIZJlcdJV slSm3qQlpjDuC8UkzC7yBlA/QmaN87YCZQswSWnkm9hwekKL4z3CH/H3JIbjVTVz7t tvvJfMXgCSzS6G+NVRn8ySnBT/hSw6tyfDtOcBY+7XjkqZ55K9hdZNaWDZXu5bmtBG /vP+FuQD/cYo9HgLFnEfY3WoFyZB8DpJaH8gVrgbd6YBXXa26Izs4E9a8fVpLiOoRx 4J613z2NQZk3g== Message-ID: Date: Sat, 26 Mar 2022 16:41:10 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [f2fs-dev] [PATCH] f2fs: remove unnecessary f2fs_lock_op in f2fs_new_inode Content-Language: en-US To: Jaegeuk Kim , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Cc: Linus Torvalds References: <20220325181850.513023-1-jaegeuk@kernel.org> From: Chao Yu In-Reply-To: <20220325181850.513023-1-jaegeuk@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/3/26 2:18, Jaegeuk Kim wrote: > This can be removed, since f2fs_alloc_nid() actually doesn't require to block > checkpoint and __f2fs_build_free_nids() is covered by nm_i->nat_tree_lock. > > Suggested-by: Linus Torvalds > Signed-off-by: Jaegeuk Kim Looks fine, but still it needs more test to check stability w/ the patch. ;) Reviewed-by: Chao Yu Thanks,