Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp3414049pxb; Sat, 26 Mar 2022 18:55:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwH6TCMUChczbiVxNnxKbKzJc2Sq3Tp7pmGHuArjnvc2TM7vVyxoXy93oSVLla3wR23NAWa X-Received: by 2002:a17:907:c0c:b0:6d1:8c46:6415 with SMTP id ga12-20020a1709070c0c00b006d18c466415mr20453801ejc.326.1648346137787; Sat, 26 Mar 2022 18:55:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648346137; cv=none; d=google.com; s=arc-20160816; b=B0kOYrfRsA/y5Lsw87bVztVGRn2T+4jmEeEHu2IOLacjz308QXbY66qmR/gT/zZ25C +5moXcIxl/GkEUquEKYuAYvdIkriQGnMsYurlNzSIbUX5uBdilFH561UcFsoqwCvclqj e+DTaE9b4Ij2sYFtJySsxsl/zWHEhLuipv7w66pVLNVL930uZudu3SdvfunONpoC/POh Vp4tkuy9wkiw+hsbBpPj8x2VmYBcJn2kC4K0FuK6gJLh1LXcaeod2euOVBVSLAKSMxf8 iUW/f3GWFLcuSIiaKQYQEOa7cem/KfiCHsVLWhVV3rOqW79K0Jg6bTijb4OMUPcVINpo vp8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=PSw9wWu8CdX7WYkoTURD/5NictUfhT43dpp9yffuwMc=; b=vupB7M8v0+Ml76V+K4rWB+e8y8M32xjoDdZ9Nazj6/oNLPm0WmHKJM7n/DXowpyuhB PLJ8eB9CPA+C3MaCu4hxWwIO5jmI5YmAtmHEv40V8tZ5ATO9PCV/MM2XmO04X3/FkFyQ yxs2E2iOQ5F9YsEYd1B1TM5dMrRb4iyUGEvlRidW6FnvlMwfSXXp4qgOXBBvhWKCSmhR gDggo4fmPRUftA0dMK6bU+ytzMhbfTDgXxOUJhquRg9nRHXzZW20/ZTtWYwMSOtLw+3I 9pNG9rEMX8ozuu4k7eYgXLgEHuwiH6kabGugTv188ougG1vFKPvo1voflIdaTdmqDaWz 778Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=u7TxL5wB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id wi22-20020a170906fd5600b006df76385d58si6656996ejb.504.2022.03.26.18.55.12; Sat, 26 Mar 2022 18:55:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=u7TxL5wB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229678AbiCZBLm (ORCPT + 99 others); Fri, 25 Mar 2022 21:11:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53400 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229446AbiCZBLk (ORCPT ); Fri, 25 Mar 2022 21:11:40 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A15416D8E6; Fri, 25 Mar 2022 18:10:05 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4C463B82ACC; Sat, 26 Mar 2022 01:10:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 223E1C2BBE4; Sat, 26 Mar 2022 01:09:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648257002; bh=2xiQISCsw2cy2y6MHShJ4Jqd9uPswPsIo+/nl7cHzog=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=u7TxL5wBkuAlU15aDeVXpEFVdmxwEHp9frlni9CwXVreMtiz/irA1vVwyeRfo8ZcY LgzdQEGx5vleNMqyJT636GsqvBAyJWNAty7wo0SvCvrzgqEXnn448oe3ZU7eLsPCP4 9s5U6EjoL8yNonMtnWKR5Z2A6mo/QiM54lpmJOlypIMt7GBKCdRq71PXmdu/jn2KbL tBAow0/9xo7PXG2lpo4FlKLMdQXua4ZdoHqfgm7dDp//t2LLlUSPJp8U0zlPENnP0j tiO/b5rh/zvV1onpmurAETgfzGg2DwRExU/CpMrxf0kmbZxpusON8bgTgwKY3SD3EZ pynU1B70Q8MxA== Date: Sat, 26 Mar 2022 10:09:56 +0900 From: Masami Hiramatsu To: Peter Zijlstra Cc: Alexei Starovoitov , Andrii Nakryiko , x86@kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , Dan Carpenter , kernel-janitors@vger.kernel.org, Steven Rostedt , Jiri Olsa , bpf@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH bpf-next v2 0/4] kprobes: rethook: x86: Replace kretprobe trampoline with rethook Message-Id: <20220326100956.2d8acf1df409a890403eefcc@kernel.org> In-Reply-To: References: <164821817332.2373735.12048266953420821089.stgit@devnote2> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 25 Mar 2022 15:43:14 +0100 Peter Zijlstra wrote: > On Fri, Mar 25, 2022 at 11:22:53PM +0900, Masami Hiramatsu wrote: > > > Masami Hiramatsu (3): > > kprobes: Use rethook for kretprobe if possible > > rethook: kprobes: x86: Replace kretprobe with rethook on x86 > > x86,kprobes: Fix optprobe trampoline to generate complete pt_regs > > > > Peter Zijlstra (1): > > Subject: x86,rethook: Fix arch_rethook_trampoline() to generate a complete pt_regs > > You fat-fingered the subject there ^ > Oops, I missed to import the patch... > Other than that: > > Acked-by: Peter Zijlstra (Intel) Thanks! > > Hopefully the ftrace return trampoline can also be switched over.. The rethook clarifies the interfaces for the return trampoline, so I think this can step the integration forward. -- Masami Hiramatsu