Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c41a7822-c4d3-3589-f39a-6a2afee67469@oracle.com>
Date:   Sat, 26 Mar 2022 11:09:26 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [PATCH v2] xen: fix is_xen_pmu()
Content-Language: en-US
To:     Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org,
        x86@kernel.org, linux-kernel@vger.kernel.org
Cc:     Stefano Stabellini <sstabellini@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "H. Peter Anvin" <hpa@zytor.com>,
        =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= 
        <marmarek@invisiblethingslab.com>
References: <20220325142002.31789-1-jgross@suse.com>
From:   Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <20220325142002.31789-1-jgross@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UjJjakN2VFd2WHF2RjVNU21hMk9YL1BrcHc5dStWWnNnejFxZTZtMnVPcHBp?=
 =?utf-8?B?UTBFZW9VMmFpNUVuN2tMN2VRWi9GTC9IdkVLS0R6TFI5QmxqVm03NW5EQWZt?=
 =?utf-8?B?eFcxMnRySWhvem9sNTBJRDhwV2lqWVlBYXVLKzlWOEZtSFBMb2d1MTdpdDVs?=
 =?utf-8?B?b3BjKzZXWEZRaStyRW1KQ2Y0R214R2dSdVI1T081d0hpa1BiWENkdnc0dXp1?=
 =?utf-8?B?V1V5cmd2OXptV0I3eDUzeERoYU1JcVU0MHJBb1MwNU5UWnRKVjRUOEFTV092?=
 =?utf-8?B?YnJSdWFrc09jT3RkZW9SV3RWbDZSVUZsQjV4OVkyeWNoZi9UVFkvdFBUc09r?=
 =?utf-8?B?cE9LZGJ3RnFueUMvTzcvSEViUldDTnhQaHdtN1VVcm0yakVCL3VBZk53L05w?=
 =?utf-8?B?ejdlbjBTOHlkTWt2WFFBc0ludjNnczEvL3ZtWE9oMXRoNS8zZkJLV1ZZNjcw?=
 =?utf-8?B?V0xSOW1sYWhGVllaU2xwUDl4K2gvOVZBSkdvUnRjWTh5aW1nZU8yT01kcS9l?=
 =?utf-8?B?Vldydm8vdXBsV1pKQWlSRnkvQTdrVVFYbEVvVXc3VEI0OVp2aWpXZEVLK0R3?=
 =?utf-8?B?U3JFTWxHODJ1Sjg1bVVXQys0NFlzV1djS0xOWXJDWWhtYzNMY3FscEYxelhW?=
 =?utf-8?B?TUNJUzBZNyt0WDRjWlV6Vk5YNk1ZeXd4anZXTmVJOFNKR29waXJKenZmS3Aw?=
 =?utf-8?B?a0dJSFg4R1Z0WGY4WVJFQTFidkJYbGxDVzZnMEJGNEhMV3FvdmNQRVJ5ZmJW?=
 =?utf-8?B?bG9vOE1CWVl0TENjMUZZaEd2SzlQMWlyeDUwQnVwQ01ZeVZxazJPbHRLWk84?=
 =?utf-8?B?NVBtQ2ZqcGlnZzhCYjZDRWhZMGlPUll1L1o4dGRQamdnVVFaZ3NudVVCeS9P?=
 =?utf-8?B?cVk3Ri80d29ZNVNtS3EzM0tUeUlyTi92d0k4Zm9jZFlDeCtkN0MvdkZZelg2?=
 =?utf-8?B?elNRMmQwZXBnN0hyaG9BNElXd2JnL0RmT1lSSXpWdHJwR2ZWUVR2Y2V6Y213?=
 =?utf-8?B?Um9xNVFLVnVQNGpSOEI0MVFrWHg0bHEvZ0M1dmtkMGg3QnlodzZ4KzEya0F1?=
 =?utf-8?B?TVdDem1uSDBRUEkrR1JUQTYyYmNHUVV3QjgvVVFIR3pielFwbEpOemdFcWJ3?=
 =?utf-8?B?NEwxS3BsUnhZYkxxVG5aWVBtUm5ESmI1eUxFRVFOdnBhbXd1YmozOG5oR08x?=
 =?utf-8?B?YWJ0VjlGb0NZbGt6MDRNb0xVaGhFMXdDckRDVkM1dWxWRzRDMjczTnRDN3R6?=
 =?utf-8?B?S1c2akg5NXdxNjNHSXNrTHRONWc0TFI4WVp2MGtlc3pwbk85dmpFMFJxY0k0?=
 =?utf-8?B?SDhic3NPc1FoZEl4ZmZXbkw5dXBqM0FlRnRKbWxGd2FvY0ZGWUFtTkQzMFBV?=
 =?utf-8?B?QWU4b3h6VS9sd2pCVlJxR21aMG85cXdIVmpCQWIxRU8xZ3NDTXJoSnpOVVFW?=
 =?utf-8?B?cEgvbHNMZ2Z3N1FqUjZud0JiSXZQd1cwLy9NSVdTbFk4LzJGL09JWVIwRG05?=
 =?utf-8?B?VG5wUW5uc1RLWnZPTEJUZjZnVXdWbkhzeThnbW1sN1FnbE9CaERjVEhWTUE3?=
 =?utf-8?B?TEREWnlTOVJxZ2puV0M4M3ZJQWdxM3F4cDJ2MjNZQjVpNXF2UmNaN0hOWVMx?=
 =?utf-8?B?T0ZuNHlvNTdyRGdjVENPNXhkdE94WFNubjdCVlk4UDZFQW5kZjQrWVFvWUZI?=
 =?utf-8?B?VEJXZWtMNFRZTllhU0tNVDVuLzZ5Z0Z4ejdSOWMrb28rdDF1a2p3WHhodlhQ?=
 =?utf-8?B?a0dUNkQwMjBzOGlkVXh0RTlPakFncEw0SitoQXRsQURPRUxZaWU0eDIwRnQy?=
 =?utf-8?B?VmRuZE5IU3doTkNTQVA3eEVnYnhkVHFxa2dwdWJIZ01NZVlEM050ZHp5c3Nv?=
 =?utf-8?B?Rjc2RWVzOURheEdudENJeFpBM05SMzlrRVhvR3dxdUFDakhKeVhxZU02b2pN?=
 =?utf-8?B?MktDeGJPcHNGblpRem1URnF0cGU5MTVpdm5haXZMemo3U2JhSG5WUk9jOWIy?=
 =?utf-8?B?VHl2VlFPWlRnPT0=?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5e4384f2-cda6-47a3-4797-08da0f3aa06e
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Mar 2022 15:09:30.1229
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CgSwHRk3fGWC+AY8CQJnh/Edru3XqIULvkp+trZF8vklR9Q1glk7dRA28ht05R10+CsyDWJ7cuXyA6Tpd7z3QnOgc4FeXfpPyPHzFhUxHic=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4429
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10298 signatures=694973
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxscore=0 bulkscore=0
 adultscore=0 spamscore=0 mlxlogscore=999 phishscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2203260098
X-Proofpoint-GUID: D2ydAiWTgQfOiztmLZK5d2FW-1klQXok
X-Proofpoint-ORIG-GUID: D2ydAiWTgQfOiztmLZK5d2FW-1klQXok
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 3/25/22 10:20 AM, Juergen Gross wrote:
> is_xen_pmu() is taking the cpu number as parameter, but it is not using
> it. Instead it just tests whether the Xen PMU initialization on the
> current cpu did succeed. As this test is done by checking a percpu
> pointer, preemption needs to be disabled in order to avoid switching
> the cpu while doing the test. While resuming from suspend() this seems
> not to be the case:
>
> [   88.082751] ACPI: PM: Low-level resume complete
> [   88.087933] ACPI: EC: EC started
> [   88.091464] ACPI: PM: Restoring platform NVS memory
> [   88.097166] xen_acpi_processor: Uploading Xen processor PM info
> [   88.103850] Enabling non-boot CPUs ...
> [   88.108128] installing Xen timer for CPU 1
> [   88.112763] BUG: using smp_processor_id() in preemptible [00000000] code: systemd-sleep/7138
> [   88.122256] caller is is_xen_pmu+0x12/0x30
> [   88.126937] CPU: 0 PID: 7138 Comm: systemd-sleep Tainted: G        W         5.16.13-2.fc32.qubes.x86_64 #1
> [   88.137939] Hardware name: Star Labs StarBook/StarBook, BIOS 7.97 03/21/2022
> [   88.145930] Call Trace:
> [   88.148757]  <TASK>
> [   88.151193]  dump_stack_lvl+0x48/0x5e
> [   88.155381]  check_preemption_disabled+0xde/0xe0
> [   88.160641]  is_xen_pmu+0x12/0x30
> [   88.164441]  xen_smp_intr_init_pv+0x75/0x100
>
> Fix that by replacing is_xen_pmu() by a simple boolean variable which
> reflects the Xen PMU initialization state on cpu 0.
>
> Modify xen_pmu_init() to return early in case it is being called for a
> cpu other than cpu 0 and the boolean variable not being set.
>
> Fixes: bf6dfb154d93 ("xen/PMU: PMU emulation code")
> Reported-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
> Signed-off-by: Juergen Gross <jgross@suse.com>


Applied to for-linus-5.18.