Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <CAAZOf27PHWxdZifZpQYfTHb3h=qk22jRc6-A2LvBkLTR6xNOKg@mail.gmail.com>
 <CAAZOf24Gux0bfS-QGgjcd93NpcpxeA5xU5n2k+EhhyphJo-Mmg@mail.gmail.com> <59034997-46f4-697d-3620-7897db7fb97d@gmail.com>
In-Reply-To: <59034997-46f4-697d-3620-7897db7fb97d@gmail.com>
From:   David Kahurani <k.kahurani@gmail.com>
Date:   Sat, 26 Mar 2022 21:26:26 +0300
Message-ID: <CAAZOf25uFOf=Edz2fEU6ecjPi2QYRimx6dKRuOOGDhd1eAwh8A@mail.gmail.com>
Subject: Re: [syzbot] KMSAN: uninit-value in ax88179_led_setting
To:     Pavel Skripkin <paskripkin@gmail.com>
Cc:     davem@davemloft.net, jgg@ziepe.ca, kuba@kernel.org,
        linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
        netdev@vger.kernel.org, Phillip Potter <phil@philpotter.co.uk>,
        syzkaller-bugs@googlegroups.com,
        syzbot+d3dbdf31fbe9d8f5f311@syzkaller.appspotmail.com,
        arnd@arndb.de
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, Mar 26, 2022 at 3:43 PM Pavel Skripkin <paskripkin@gmail.com> wrote:
>
> Hi David,
>
> On 3/26/22 14:47, David Kahurani wrote:
> >>
> >> Signed-off-by: David Kahurani <k.kahurani@gmail.com>
> >> Reported-by: syzbot+d3dbdf31fbe9d8f5f311@syzkaller.appspotmail.com
> >> ---
> >>  drivers/net/usb/ax88179_178a.c | 181 +++++++++++++++++++++++++++------
> >>  1 file changed, 152 insertions(+), 29 deletions(-)
> >>
> >> diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c
> >> index a31098981..932e21a65 100644
> >> --- a/drivers/net/usb/ax88179_178a.c
> >> +++ b/drivers/net/usb/ax88179_178a.c
> >> @@ -224,9 +224,12 @@ static int __ax88179_write_cmd(struct usbnet *dev, u8 cmd, u16 value, u16 index,
> >>   ret = fn(dev, cmd, USB_DIR_OUT | USB_TYPE_VENDOR | USB_RECIP_DEVICE,
> >>   value, index, data, size);
> >>
>

Yes, this breaks the logic of the entire patch. It was a mistake. Will
fix that alongside your other comments.

> You've changed __ax88179_write_cmd(), but not __ax88179_read_cmd(). I've
> missed it. Changing  __ax88179_write_cmd() does not help with uninit
> value bugs
>
> Also I believe, __ax88179_read_cmd() should have __must_check annotation
> too, since problem came from it in the first place (I mean after added
> sane error handling inside it)
>
> Next thing is ax88179_read_cmd_nopm() still prone to uninit value bugs,
> since it touches uninitialized `buf` in case of __ax88179_read_cmd()
> error...
>
>
>
> I remembered why I gave up on fixing this driver... I hope, you have
> more free time and motivation :)
>
>
>
>
> With regards,
> Pavel Skripkin