Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 27 Mar 2022 17:19:16 +0100
From:   Jonathan Cameron <jic23@kernel.org>
To:     Paul Cercueil <paul@crapouillou.net>
Cc:     Zizhuang Deng <sunsetdzz@gmail.com>, Jonathan.Cameron@huawei.com,
        linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
        Paul Cercueil <paul.cercueil@analog.com>
Subject: Re: [PATCH] iio: dac: ad5592r: Fix the missing return value.
Message-ID: <20220327171916.5d6c7b18@jic23-huawei>
In-Reply-To: <OZ839R.NWJC2LY54LGX@crapouillou.net>
References: <20220310125450.4164164-1-sunsetdzz@gmail.com>
        <20220320152047.2a04a62e@jic23-huawei>
        <OZ839R.NWJC2LY54LGX@crapouillou.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, 21 Mar 2022 09:28:36 +0000
Paul Cercueil <paul@crapouillou.net> wrote:

> Hi,
>=20
> Le dim., mars 20 2022 at 15:20:47 +0000, Jonathan Cameron=20
> <jic23@kernel.org> a =C3=A9crit :
> > On Thu, 10 Mar 2022 20:54:50 +0800
> > Zizhuang Deng <sunsetdzz@gmail.com> wrote:
> >  =20
> >>  The third call to `fwnode_property_read_u32` did not record
> >>  the return value, resulting in `channel_offstate` possibly
> >>  being assigned the wrong value.
> >>=20
> >>  Signed-off-by: Zizhuang Deng <sunsetdzz@gmail.com> =20
> > Hi,
> >=20
> > Definitely rather odd looking and I think your conclusion is correct.
> > +CC Paul for confirmation that this isn't doing something clever.. =20
>=20
> It's been a while, but I don't think there was anything clever going on=20
> here - so the patch is fine.

Added a fixes tag (it was driver introduction) and marked for stable
given this could have some weird side effects if anyone actually
had a dt that hit this path.  Applied to the fixes-togreg branch of iio.git
but not pushed out yet as I'll be rebasing that branch on rc1 next week.

Thanks,

Jonathan

>=20
> Cheers,
> -Paul
>=20
> >  =20
> >>  ---
> >>   drivers/iio/dac/ad5592r-base.c | 2 +-
> >>   1 file changed, 1 insertion(+), 1 deletion(-)
> >>=20
> >>  diff --git a/drivers/iio/dac/ad5592r-base.c=20
> >> b/drivers/iio/dac/ad5592r-base.c
> >>  index a424b7220b61..4434c1b2a322 100644
> >>  --- a/drivers/iio/dac/ad5592r-base.c
> >>  +++ b/drivers/iio/dac/ad5592r-base.c
> >>  @@ -522,7 +522,7 @@ static int ad5592r_alloc_channels(struct=20
> >> iio_dev *iio_dev)
> >>   		if (!ret)
> >>   			st->channel_modes[reg] =3D tmp;
> >>=20
> >>  -		fwnode_property_read_u32(child, "adi,off-state", &tmp);
> >>  +		ret =3D fwnode_property_read_u32(child, "adi,off-state", &tmp);
> >>   		if (!ret)
> >>   			st->channel_offstate[reg] =3D tmp;
> >>   	} =20
> >  =20
>=20
>=20