Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp4469540pxb; Sun, 27 Mar 2022 19:49:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy1AF8Y5lWzlMO5szGLWDcnB+kKWIKVx4PHQdfp019V07Rv3kCtnmELH1kKKHmp9vVjqYfe X-Received: by 2002:a63:5907:0:b0:382:2f93:5467 with SMTP id n7-20020a635907000000b003822f935467mr8448414pgb.460.1648435762730; Sun, 27 Mar 2022 19:49:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648435762; cv=none; d=google.com; s=arc-20160816; b=QOdQHBiteinOilnwVShJwQEc62KdtaIEz7xypLK6Ri6PNjd8Zyk2trSaR9KKYdDWZI OJMA1ssKs1he5eTVaYE7YDdl54gXzkfGYA0okYRGg8YQs1WmciJzaJEdOP5vNnFT8GjA sheRFkgVu4peoNFTmYxNic3OgCBqc/t9euYXcdyM3YsaQXL5gwvrpH06/75vRPj2vbop gV5+9TBvO01DGnTB0XcJ2ARkq8ufdsGdi7U6+OY/HBHmZp40aLL/9FA/e5JhsSi6Z48N +NFz2gKav1ZfAQCU8athNDL+BdPDP5NbS9e9Nj9xn+ViWNt35lu1Fo9Fij4Ut7NOEmoG 6VYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=SJC0OBpbo1wPJs92walEXwvuMKGL+QuVz9UtNgWIQO4=; b=mmMo6uPnYdC9sBm/ugcrLY/1LBSwCfioGXbvA6SpJUD+wqKKEb69ac6yWXZiGOdadP cLi4p5RPMI2Dn3q0O8MhGEny7IUzKFua2dvc26I6Ix5N1CiC1eGqwo17WAH2+wk24xfC l+LYmGNyex82POsUrfPo6ppPN9KlBCAkwV0+7H3WeF3O6sKQcs6ZwYBD8EHLg/hFfsbu akDMRpHSDtUVOCiT2aZQw1UTTcsVYvjvA9QTGwHMWjA4dND4cq5uQQUtq0LOxHggFTwA ssmHoi7ZEnSfn+l5/VBfn6KixfFl61qK1tiuV3r+RhsmB4m0wRcvFVrrfd4rNQ1s32fE HRxA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=cbr7IATf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b4-20020a056a000cc400b004fa687c28d4si12023780pfv.86.2022.03.27.19.49.08; Sun, 27 Mar 2022 19:49:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=cbr7IATf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232072AbiC0UAY (ORCPT + 99 others); Sun, 27 Mar 2022 16:00:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38170 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229584AbiC0UAX (ORCPT ); Sun, 27 Mar 2022 16:00:23 -0400 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 56C5A10FDC; Sun, 27 Mar 2022 12:58:44 -0700 (PDT) Received: by mail-ed1-x52c.google.com with SMTP id c62so14746735edf.5; Sun, 27 Mar 2022 12:58:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SJC0OBpbo1wPJs92walEXwvuMKGL+QuVz9UtNgWIQO4=; b=cbr7IATfDrBAabV81aPZWOvIUBIUIpSdkVpz3wjkORMU+Td/ujiwFi9ZmSk3nHQVca qjNhZ+aFm+JtQYK//RiGq1gFJxM3cmSauYqUO2zFMLO92vxv2idh3/kJkah5hdsKpIGu ohyvdc6aUDzyrgxarmcXEakKWBjWYqlfE3WMVENslcooChfSlJsQNnzSyLyNuECHCTUB bRs1z9EhRBXqUQTHHRdq+XJEiCuxMkMsGkp4wRMPUhOZcZzxM7/lQ4CY1YO15gUoudXV 1CUzBCwGedNlRNVXhiCntP139L693MrUoHassTyuCBVby16DlShHN5rHMaHEZH4B0VAv 665A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SJC0OBpbo1wPJs92walEXwvuMKGL+QuVz9UtNgWIQO4=; b=maE2XiZjyIWwtC1kvyMwVbkX1blPYeqn9P4I0203gUyw5Q+9KQp6i67r2JgRLTD742 YISsvPI2blRXvnCpMA0ncxL2axDFErJ1CcLngxEiI8qEMmOYef3igiq8/s2l9wPAjBja FHL9RWQO9rSksUtEVFiGVdEAVHgpNNXyvoAxPhAw7BP9I4fQglmmFJD+Apiovc4+ab9e zFzDmcx5Gj6Dr6QWC6LUzvbLAMvobQXbgE8Z5zLAoEHDE8UuqB5vGQOZO9QNHlPjN/Mp Bk6mxyI4nZ6meIugTFRhU6d8Ep/UcUvmMSgFWN/Xm7ddeeHCkxGwksiCROk+mlt9nNPv SLvQ== X-Gm-Message-State: AOAM532xXqQQsRaRgctGY2PK1R7r3yavjgCIE84TsCA4E8YF58tGlS4i 0quytp79VMqt5H7RQBUoNhJC8dltcrK2/sjcmIo= X-Received: by 2002:aa7:c30f:0:b0:419:2af:4845 with SMTP id l15-20020aa7c30f000000b0041902af4845mr12139494edq.296.1648411122928; Sun, 27 Mar 2022 12:58:42 -0700 (PDT) MIME-Version: 1.0 References: <20220325200338.54270-1-andriy.shevchenko@linux.intel.com> <20220325200338.54270-5-andriy.shevchenko@linux.intel.com> <3415996d-e8b5-2416-fb66-e65779a9b507@omp.ru> In-Reply-To: <3415996d-e8b5-2416-fb66-e65779a9b507@omp.ru> From: Andy Shevchenko Date: Sun, 27 Mar 2022 22:58:07 +0300 Message-ID: Subject: Re: [PATCH v1 5/5] pinctrl: armada-37xx: Replace custom code by gpiochip_count() call To: Sergey Shtylyov Cc: Andy Shevchenko , Gregory CLEMENT , Geert Uytterhoeven , Fabien Dessenne , Linus Walleij , "open list:GPIO SUBSYSTEM" , linux-arm Mailing List , linux-amlogic , Linux Kernel Mailing List , Linux-Renesas , linux-stm32@st-md-mailman.stormreply.com, Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Andrew Lunn , Sebastian Hesselbarth , Maxime Coquelin , Alexandre Torgue , Bartosz Golaszewski Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 26, 2022 at 7:02 PM Sergey Shtylyov wrote: > On 3/25/22 11:03 PM, Andy Shevchenko wrote: > > > Since we have a generic function to count GPIO controller nodes > > under a given device, there is no need to open-code it. Replace > > custom code by gpiochip_count() call. ... > > + nr_child_nodes = of_irq_count(np); > > Mhm, 'np' is no longer assigned to it at this point... Good catch! We may retrieve it by calling np = to_of_node(device_get_named_child_node(dev, "gpio-controller")); like it's done in the previous patch in the series. -- With Best Regards, Andy Shevchenko