Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <42c32324-ce22-ae37-6118-35590f4e355c@kernel.org>
Date:   Sun, 27 Mar 2022 21:21:34 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH] dt-bindings: spi: qcom-qspi: Add minItems to
 interconnect-names
Content-Language: en-US
To:     Kuldeep Singh <singh.kuldeep87k@gmail.com>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Mark Brown <broonie@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Mukesh Savaliya <msavaliy@codeaurora.org>,
        Akash Asthana <akashast@codeaurora.org>
Cc:     Rob Herring <robh@kernel.org>, linux-arm-msm@vger.kernel.org,
        linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20220326212134.45759-1-singh.kuldeep87k@gmail.com>
From:   Krzysztof Kozlowski <krzk@kernel.org>
In-Reply-To: <20220326212134.45759-1-singh.kuldeep87k@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 26/03/2022 22:21, Kuldeep Singh wrote:
> Qualcomm QSPI DT spec says interconnects has minimum length 1 and
> maximum length 2. Same configuration will be applicable for
> interconnect-names. Schema currently depicts interconnects length
> correctly but not interconnect-names. It can have a single entry, which
> is a valid case yet to be incorporated in the current configuration. The
> schema tries to look for 2 names and fail for DTs with a single entry.
> Thus, add minItems property to interconnect-names to fix it.

Thanks for the patch.

6 sentences which explaining the same, which could be written in one
sentence. In the same time you actually do not explain whether having
one interconnect is correct. You just say what DT spec says about
interconnects, but maybe that's wrong.

So either keep just one sentence or really explain why one or two are
allowed (based on datasheet for example).

> 
> With the change applied, below interconnect-names values are possible:
> ['qspi-config'], ['qspi-config', 'qspi-memory']
> 
> Fixes: 8f9c291558ea ("dt-bindings: spi: Add interconnect binding for QSPI")
> Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com>
> ---
>  Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml | 1 +
>  1 file changed, 1 insertion(+)


Best regards,
Krzysztof