Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Trond Myklebust <trondmy@hammerspace.com>
To:     "anna@kernel.org" <anna@kernel.org>,
        "xiam0nd.tong@gmail.com" <xiam0nd.tong@gmail.com>
CC:     "bhalevy@panasas.com" <bhalevy@panasas.com>,
        "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "bharrosh@panasas.com" <bharrosh@panasas.com>
Subject: Re: [PATCH] nfs: callback_proc: fix an incorrect NULL check on list
 iterator
Thread-Topic: [PATCH] nfs: callback_proc: fix an incorrect NULL check on list
 iterator
Thread-Index: AQHYQbEIv3QbmQbNHEGPE23RAen3xqzTWQ6A
Date:   Sun, 27 Mar 2022 15:20:42 +0000
Message-ID: <436766b6fb5f3ec513629d4fa0888b77c65cfa16.camel@hammerspace.com>
References: <20220327080230.12134-1-xiam0nd.tong@gmail.com>
In-Reply-To: <20220327080230.12134-1-xiam0nd.tong@gmail.com>
Accept-Language: en-US, en-GB
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?SzQ5L01tL1JFcFJDMjNMVm8xTVMrY0dDblk5L1ZXSWF3ZlZ0QVpscVJ0bThF?=
 =?utf-8?B?OEZEYjdGOGxzc2laNFFtaitid2tvWWFWTC9EaWNsZWY0endENFdCZEZUenBq?=
 =?utf-8?B?VTFpMmJMb1c3Zk14S1ptdmd0T2hiNUVYLytaamtHWkszbHlPa2RPaWZQUnVZ?=
 =?utf-8?B?eFlkSHB5endsRkk1Ry8vSWsxcU0vUXZnSmZkSHI4RnRjdk14WWVQZlAzKzhV?=
 =?utf-8?B?UE9ZWndnenJyNnFPS1h1Q1hjRVVWY0lGMXdOQlRCWDBvQmJiYXh1NlhCRHJ0?=
 =?utf-8?B?b0JDbVErUXdHMlI0djJ4Mk50WG1kTk41SFU5RFlVZmtJVGtodW80SExHZ0No?=
 =?utf-8?B?Tm1teG9IbkF6ZWFoNU45ME15dW9reFF2WDJra2I2emt6dldWZnJLTEhTNVBB?=
 =?utf-8?B?Y2VDb2s2OWZoaWphems4OFRSSWlmSGljUmVhWlNjS0hBdkhsVDc4RU41VEI2?=
 =?utf-8?B?TjJTOHIyTm5sYUlYUFluM3FnV1Y1M1RxVFVFMTVUMTArWks4WGhSQ24wL0Vy?=
 =?utf-8?B?bE9kY3VmUkZuWE40MjN5eW1hNkQrdHYza216UVZGbkNVU2dhcGxqaHdnaHFB?=
 =?utf-8?B?K0RISDRWWHMwTTlNQ2pjQW1vUUh3aDk5ZHpIZkdNSEtKcERiZkZUMDh0SUF0?=
 =?utf-8?B?YUE4T0VxMk8rLytqN0tvUjV6a2xGR3NsMVhNakNVMXNwL2laTlpJajJrWmFm?=
 =?utf-8?B?RWxUMmo2V3gvNVMrak40Z3o5Ry9oSzlJQXVjK1RwRVhoMTkwWTZFNTdHbk5W?=
 =?utf-8?B?VEQ5Y3RwVGxkY0UwSy9CY3ZLTzFodVNnQng4NmNIaXVzWmhDVlM5RnBjMytX?=
 =?utf-8?B?MVdXQS9HNERPS2tlMHhkdjUvWlB4RG9mL28vSVNmdHJVSDBUVFVBK0U0bk9W?=
 =?utf-8?B?VThuL0dLZi82ZU16QjRVczlvd1Zyck51WXNLeEg4ZElycE1CU0pxYmJqWUl6?=
 =?utf-8?B?VGtTWE1wSjQ0bWQySnZNaE9GeXhqNVl3dnlQbkZ6bnJQTW9MZWczLzJUZXRz?=
 =?utf-8?B?bE5XYThCNGVRcStBK0FxTlZJcVdUOTdiVEFYUUhwVVkrYWJwVzhRbUE3Yllp?=
 =?utf-8?B?bHRuUC9Nc3kyOTVUMmEwZ0FlcmFudXZmRGN1b0hQYjg5cnhkc01mZEwrZy9q?=
 =?utf-8?B?cFRvWVNZN3VzUlg5cG45OFkraVY4ZVNJU1RCaUFrNnFEa3RSdTk3VFVSZlpz?=
 =?utf-8?B?aTh6eEd5R2VoN2l4NnBwVUFwWjFjc2RTTWZXN0Nlc25GRzA3b0VQdCtkUFBu?=
 =?utf-8?B?d0dkNUpzRnU5WWo3UzA5UlVsV1pUYnRBODFWM0RYRnJVbEc3czgwRE1vTlZY?=
 =?utf-8?B?ZE4xaVEzOXhyZGJ5OU9wUlB2c0dEb01rcndESCttaTMyYnVUbHpVZDltcTdl?=
 =?utf-8?B?S0p3ODdVNEdUbVN1eUgyWG9renR0b3BpUXk1NEh5WExhbWxXNGFCQ050Y1cv?=
 =?utf-8?B?aXFWTTdVUFp6UzBJQ1k3SFppUlF6NXJCR1MvZFNnZ1VFb0F6emg2c1g3aGlp?=
 =?utf-8?B?ZTdVajVFOHY3eDdGUm5PM3BQYVN4VjZnVmZhTjRJS0k4WDZmWGI3dTE3WFd5?=
 =?utf-8?B?amJkRS9sZjU0WCtYVGs4OW56THRaM2lhU2RzK21uS3VRS2tFK0tpeDd2eDdH?=
 =?utf-8?B?Mzg3c2Y1UDNWd0dVcU9xb2gxN3FVdlhaemJxOE9CL2VrbVlPKzZITnk5dzdk?=
 =?utf-8?B?MTVSdFByU3ZpeUptS1ZWNTE4c1Y3UTBBN0Nsdy9WSEE2cU9nemF1RmVPdkhO?=
 =?utf-8?B?MmZFS0VacEt4V2p1dGEzVnRoRXpaNlRTaTFKbElpZnZXVFBXa0RpVjNGSjVI?=
 =?utf-8?B?VnRkYmtueXpTbjJ6NGpIR3MwV0k1WnlkRTZQMkZSOWdxZzJwcXlXQUhHcEl5?=
 =?utf-8?B?U3FMSTB3VHZsWDNlSU92U0tFQ2RXbFBiTHFOWksydlUrRVp0RGN1ZkpJNjlW?=
 =?utf-8?B?SlM4Y0kxUllRYjRnS3NDYnFVQzFubnZ2ZHFIVGJVMFVOMi9hL2NkZmJpTXVk?=
 =?utf-8?B?Lzk3c0RYOHdXZzhqR2h4TmMwM3Z4RE94eUM3aDMra0pMVDhYS051WUNpdVJQ?=
 =?utf-8?B?S2pHMi9QQnBRcUlKU04wcGt5YjdJaDhacHExcFROVUJxcHFreGxQSko2aWY2?=
 =?utf-8?B?dlA1MHlrRnVFajVoSWJnSkpTTnBxWFVWUUQxaXJtZ3BUY1c4QUQ4TmxXa1Iz?=
 =?utf-8?B?QlFENGpjaDBHc0o4QTJyWlQ0cFhaYUE2am9sM2pUR0swUlVLL0FGWXd6Y3hT?=
 =?utf-8?B?T0RSbVZsc2VTTDh4RUlVZ3dPOS9ZeVBvUm1zTFJzN2pIa09ISXgvNTQybGRp?=
 =?utf-8?B?aWQ1d1NTdHY5NzMrN20wVUJ5REJiNGdoUnR5Skh3djRDSG9ZRlo1VlRIdHdP?=
 =?utf-8?Q?210kUMy8RUF8s0WI=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <AF854E950B739A4EB837EF941DADC7DD@namprd13.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: hammerspace.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CH0PR13MB5084.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ff563f5f-609b-4227-d272-08da10055be8
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Mar 2022 15:20:42.7181
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 0d4fed5c-3a70-46fe-9430-ece41741f59e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: GfHm5DDOPsz1jQ8j7IhEqcT/HWrkm3bG1I/UmcE5MQiNW805v/B4sdb5xzUvBd18KwEcxyHLforhYQmSFbOKYw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR13MB1825
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

T24gU3VuLCAyMDIyLTAzLTI3IGF0IDE2OjAyICswODAwLCBYaWFvbWVuZyBUb25nIHdyb3RlOgo+
IFRoZSBidWcgaXMgaGVyZToKPiDCoMKgwqDCoMKgwqDCoMKgaWYgKCFzZXJ2ZXIgfHwKPiDCoMKg
wqDCoMKgwqDCoMKgc2VydmVyLT5wbmZzX2N1cnJfbGQtPmlkICE9IGRldi0+Y2JkX2xheW91dF90
eXBlKSB7Cj4gCj4gVGhlIGxpc3QgaXRlcmF0b3IgdmFsdWUgJ3NlcnZlcicgd2lsbCAqYWx3YXlz
KiBiZSBzZXQgYW5kIG5vbi1OVUxMCj4gYnkgbGlzdF9mb3JfZWFjaF9lbnRyeV9yY3UsIHNvIGl0
IGlzIGluY29ycmVjdCB0byBhc3N1bWUgdGhhdCB0aGUKPiBpdGVyYXRvciB2YWx1ZSB3aWxsIGJl
IE5VTEwgaWYgdGhlIGxpc3QgaXMgZW1wdHkgb3Igbm8gZWxlbWVudCBpcwo+IGZvdW5kIChJbiBm
YWN0LCBpdCB3aWxsIGJlIGEgYm9ndXMgcG9pbnRlciB0byBhbiBpbnZhbGlkIHN0cnVjdAo+IG9i
amVjdCBjb250YWluaW5nIHRoZSBIRUFELCB3aGljaCBpcyB1c2VkIGZvciBhYm92ZSBjaGVjayBh
dCBuZXh0Cj4gb3V0ZXIgbG9vcCkuIE90aGVyd2lzZSBpdCBtYXkgYnlwYXNzIHRoZSBjaGVjayBp
biB0aGVvcnkgKGlpZgo+IHNlcnZlci0+cG5mc19jdXJyX2xkLT5pZCA9PSBkZXYtPmNiZF9sYXlv
dXRfdHlwZSwgJ3NlcnZlcicgbm93IGlzCj4gYSBib2d1cyBwb2ludGVyKSBhbmQgbGVhZCB0byBp
bnZhbGlkIG1lbW9yeSBhY2Nlc3MgcGFzc2luZyB0aGUgY2hlY2suCj4gCj4gVG8gZml4IHRoZSBi
dWcsIHVzZSBhIG5ldyB2YXJpYWJsZSAnaXRlcicgYXMgdGhlIGxpc3QgaXRlcmF0b3IsCj4gd2hp
bGUgdXNlIHRoZSBvcmlnaW5hbCB2YXJpYWJsZSAnc2VydmVyJyBhcyBhIGRlZGljYXRlZCBwb2lu
dGVyIHRvCj4gcG9pbnQgdG8gdGhlIGZvdW5kIGVsZW1lbnQuCj4gCj4gQ2M6IHN0YWJsZUB2Z2Vy
Lmtlcm5lbC5vcmcKPiBGaXhlczogMWJlNTY4M2IwM2E3NiAoInBuZnM6IENCX05PVElGWV9ERVZJ
Q0VJRCIpCj4gU2lnbmVkLW9mZi1ieTogWGlhb21lbmcgVG9uZyA8eGlhbTBuZC50b25nQGdtYWls
LmNvbT4KPiAtLS0KPiDCoGZzL25mcy9jYWxsYmFja19wcm9jLmMgfCA5ICsrKysrLS0tLQo+IMKg
MSBmaWxlIGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKPiAKPiBkaWZm
IC0tZ2l0IGEvZnMvbmZzL2NhbGxiYWNrX3Byb2MuYyBiL2ZzL25mcy9jYWxsYmFja19wcm9jLmMK
PiBpbmRleCBjMzQzNjY2ZDlhNDIuLjg0Nzc5Nzg1ZGM4ZCAxMDA2NDQKPiAtLS0gYS9mcy9uZnMv
Y2FsbGJhY2tfcHJvYy5jCj4gKysrIGIvZnMvbmZzL2NhbGxiYWNrX3Byb2MuYwo+IEBAIC0zNjEs
NyArMzYxLDcgQEAgX19iZTMyIG5mczRfY2FsbGJhY2tfZGV2aWNlbm90aWZ5KHZvaWQgKmFyZ3As
Cj4gdm9pZCAqcmVzcCwKPiDCoMKgwqDCoMKgwqDCoMKgdWludDMyX3QgaTsKPiDCoMKgwqDCoMKg
wqDCoMKgX19iZTMyIHJlcyA9IDA7Cj4gwqDCoMKgwqDCoMKgwqDCoHN0cnVjdCBuZnNfY2xpZW50
ICpjbHAgPSBjcHMtPmNscDsKPiAtwqDCoMKgwqDCoMKgwqBzdHJ1Y3QgbmZzX3NlcnZlciAqc2Vy
dmVyID0gTlVMTDsKPiArwqDCoMKgwqDCoMKgwqBzdHJ1Y3QgbmZzX3NlcnZlciAqc2VydmVyID0g
TlVMTCwgKml0ZXI7Cj4gwqAKPiDCoMKgwqDCoMKgwqDCoMKgaWYgKCFjbHApIHsKPiDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoHJlcyA9IGNwdV90b19iZTMyKE5GUzRFUlJfT1BfTk9U
X0lOX1NFU1NJT04pOwo+IEBAIC0zNzQsMTAgKzM3NCwxMSBAQCBfX2JlMzIgbmZzNF9jYWxsYmFj
a19kZXZpY2Vub3RpZnkodm9pZCAqYXJncCwKPiB2b2lkICpyZXNwLAo+IMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgaWYgKCFzZXJ2ZXIgfHwKPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoCBzZXJ2ZXItPnBuZnNfY3Vycl9sZC0+aWQgIT0gZGV2LT5jYmRfbGF5
b3V0X3R5cGUpCj4gewo+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoHJjdV9yZWFkX2xvY2soKTsKPiAtwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoGxpc3RfZm9yX2VhY2hfZW50cnlfcmN1KHNlcnZlciwgJmNscC0KPiA+
Y2xfc3VwZXJibG9ja3MsIGNsaWVudF9saW5rKQo+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoGlmIChzZXJ2ZXItPnBuZnNfY3Vy
cl9sZCAmJgo+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBzZXJ2ZXItPnBuZnNfY3Vycl9sZC0+aWQgPT0gZGV2LQo+
ID5jYmRfbGF5b3V0X3R5cGUpIHsKPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoGxpc3RfZm9yX2VhY2hfZW50cnlfcmN1KGl0ZXIsICZjbHAtCj4gPmNsX3N1
cGVyYmxvY2tzLCBjbGllbnRfbGluaykKPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqBpZiAoaXRlci0+cG5mc19jdXJyX2xkICYm
Cj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgIGl0ZXItPnBuZnNfY3Vycl9sZC0+aWQgPT0gZGV2LQo+ID5jYmRfbGF5
b3V0X3R5cGUpIHsKPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoHJjdV9yZWFkX3VubG9jaygpOwo+
ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqBzZXJ2ZXIgPSBpdGVyOwoKSG1tLi4uIFdlJ3JlIG5vdCBo
b2xkaW5nIGFueSBsb2NrcyBvbiB0aGUgc3VwZXIgYmxvY2sgZm9yICdpdGVyJyBoZXJlLApzbyBu
b3RoaW5nIGlzIHByZXZlbnRpbmcgaXQgZnJvbSBnb2luZyBhd2F5IHdoaWxlIHdlJ3JlLgoKR2l2
ZW4gdGhhdCB3ZSByZWFsbHkgb25seSB3YW50IGEgcG9pbnRlciB0byB0aGUgc3RydWN0CnBuZnNf
bGF5b3V0ZHJpdmVyX3R5cGUgYW55d2F5LCB3aHkgbm90IGp1c3QgY29udmVydCB0aGUgY29kZSB0
byBzYXZlIGEKcG9pbnRlciB0byB0aGF0IChhbmQgZG8gaXQgd2hpbGUgaG9sZGluZyB0aGUgcmN1
X3JlYWRfbG9jaygpKT8KClRoZSBzdHJ1Y3QgcG5mc19sYXlvdXRkcml2ZXIgaXMgYWx3YXlzIGV4
cGVjdGVkIHRvIGJlIGEgc3RhdGljYWxseQphbGxvY2F0ZWQgc3RydWN0dXJlLCBzbyBpdCB3b24n
dCBnbyBhd2F5IGFzIGxvbmcgYXMgdGhlIHBORlMgZHJpdmVyCm1vZHVsZSByZW1haW5zIGxvYWRl
ZC4KCj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqBnb3RvIGZvdW5kOwo+IMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqB9Cj4gwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgcmN1X3JlYWRfdW5s
b2NrKCk7CgotLSAKVHJvbmQgTXlrbGVidXN0CkxpbnV4IE5GUyBjbGllbnQgbWFpbnRhaW5lciwg
SGFtbWVyc3BhY2UKdHJvbmQubXlrbGVidXN0QGhhbW1lcnNwYWNlLmNvbQoKCg==