Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.80.82.1.1\))
Subject: Re: [PATCH] bnx2x: replace usage of found with dedicated list
 iterator variable
From:   Jakob Koschel <jakobkoschel@gmail.com>
In-Reply-To: <7393b673c626fd75f2b4f8509faa5459254fb87c.camel@redhat.com>
Date:   Sun, 27 Mar 2022 23:32:17 +0200
Cc:     Ariel Elior <aelior@marvell.com>,
        Sudarsana Kalluru <skalluru@marvell.com>,
        Manish Chopra <manishc@marvell.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, Mike Rapoport <rppt@kernel.org>,
        Brian Johannesmeyer <bjohannesmeyer@gmail.com>,
        Cristiano Giuffrida <c.giuffrida@vu.nl>,
        "Bos, H.J." <h.j.bos@vu.nl>
Content-Transfer-Encoding: quoted-printable
Message-Id: <A2882749-A512-447C-B28F-37BEC287A614@gmail.com>
References: <20220324070816.58599-1-jakobkoschel@gmail.com>
 <7393b673c626fd75f2b4f8509faa5459254fb87c.camel@redhat.com>
To:     Paolo Abeni <pabeni@redhat.com>
Precedence: bulk

Hello,

> On 24. Mar 2022, at 11:46, Paolo Abeni <pabeni@redhat.com> wrote:
>=20
> Hello,
>=20
> On Thu, 2022-03-24 at 08:08 +0100, Jakob Koschel wrote:
>> To move the list iterator variable into the list_for_each_entry_*()
>> macro in the future it should be avoided to use the list iterator
>> variable after the loop body.
>>=20
>> To *never* use the list iterator variable after the loop it was
>> concluded to use a separate iterator variable instead of a
>> found boolean [1].
>>=20
>> This removes the need to use a found variable and simply checking if
>> the variable was set, can determine if the break/goto was hit.
>>=20
>> Link: =
https://lore.kernel.org/all/CAHk-=3DwgRr_D8CB-D9Kg-c=3DEHreAsk5SqXPwr9Y7k9=
sA6cWXJ6w@mail.gmail.com/
>> Signed-off-by: Jakob Koschel <jakobkoschel@gmail.com>
>=20
> This looks like a purely net-next change, and we are in the merge
> window: net-next is closed for the time being. Could you please =
re-post
> after net-next re-open?

Thanks for letting me know, I'll re-post after net-next is reopened.

>=20
> Additionally, I suggest you to bundle the net-next patches in a single
> series, namely:

Are you saying having a single patchset for all /net and /drivers/net
related changes? This would also simplify a lot on my end.


>=20
> bnx2x: replace usage of found with dedicated list iterator variable=20
> octeontx2-pf: replace usage of found with dedicated list iterator =
variable=20
> sctp: replace usage of found with dedicated list iterator variable=20
> taprio: replace usage of found with dedicated list iterator variable=20=

>=20
> that will simplify the processing, thanks!
>=20
> Paolo

Thanks,
Jakob