Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 27 Mar 2022 17:25:46 +0100
From:   Jonathan Cameron <jic23@kernel.org>
To:     "Sa, Nuno" <Nuno.Sa@analog.com>
Cc:     Wang ShaoBo <bobo.shaobowang@huawei.com>,
        "cj.chengjian@huawei.com" <cj.chengjian@huawei.com>,
        "liwei391@huawei.com" <liwei391@huawei.com>,
        "Miclaus, Antoniu" <Antoniu.Miclaus@analog.com>,
        "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Jonathan.Cameron@huawei.com" <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH v2] iio:filter:admv8818: select REGMAP_SPI for ADMV8818
Message-ID: <20220327172546.40497743@jic23-huawei>
In-Reply-To: <PH0PR03MB67860473C10499C1EEED1C0A99169@PH0PR03MB6786.namprd03.prod.outlook.com>
References: <20220320055457.254983-1-bobo.shaobowang@huawei.com>
        <PH0PR03MB67860473C10499C1EEED1C0A99169@PH0PR03MB6786.namprd03.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, 21 Mar 2022 09:10:01 +0000
"Sa, Nuno" <Nuno.Sa@analog.com> wrote:

> > -----Original Message-----
> > From: Wang ShaoBo <bobo.shaobowang@huawei.com>
> > Sent: Sunday, March 20, 2022 6:55 AM
> > Cc: cj.chengjian@huawei.com; liwei391@huawei.com;
> > bobo.shaobowang@huawei.com; Miclaus, Antoniu
> > <Antoniu.Miclaus@analog.com>; Sa, Nuno <Nuno.Sa@analog.com>;
> > linux-iio@vger.kernel.org; linux-kernel@vger.kernel.org;
> > jic23@kernel.org; Jonathan.Cameron@huawei.com
> > Subject: [PATCH v2] iio:filter:admv8818: select REGMAP_SPI for
> > ADMV8818
> >=20
> > [External]
> >=20
> > admv8818 driver needs __devm_regmap_init_spi() which is defined
> > when CONFIG_REGMAP_SPI is set and struct regmap_config when
> > CONFIG_REGMAP is set, so automatically select CONFIG_REGMAP_SPI
> > which also sets CONFIG_REGMAP.
> >=20
> > Fixes: f34fe888ad05 ("iio:filter:admv8818: add support for ADMV8818")
> > Signed-off-by: Wang ShaoBo <bobo.shaobowang@huawei.com>
> > --- =20
>=20
> Reviewed-by: Nuno S=C3=A1 <nuno.sa@analog.com>
Applied to the fixes-togreg branch of iio.git but I'll not push that tree o=
ut
until I have had a chance to rebase on rc1.

Thanks,

Jonathan

>=20
> >  drivers/iio/filter/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> >=20
> > diff --git a/drivers/iio/filter/Kconfig b/drivers/iio/filter/Kconfig
> > index 3ae35817ad82..a85b345ea14e 100644
> > --- a/drivers/iio/filter/Kconfig
> > +++ b/drivers/iio/filter/Kconfig
> > @@ -8,6 +8,7 @@ menu "Filters"
> >  config ADMV8818
> >  	tristate "Analog Devices ADMV8818 High-Pass and Low-Pass
> > Filter"
> >  	depends on SPI && COMMON_CLK && 64BIT
> > +	select REGMAP_SPI
> >  	help
> >  	  Say yes here to build support for Analog Devices ADMV8818
> >  	  2 GHz to 18 GHz, Digitally Tunable, High-Pass and Low-Pass
> > Filter.
> > --
> > 2.25.1 =20
>=20