Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp4715041pxb; Mon, 28 Mar 2022 01:57:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzYB17/I9Hg4QTYtWBSscYAxcDEHY8fF3h2pVb9m7G5RnKIjMlcRa3OK2SnxjFPj46zw3Hb X-Received: by 2002:a05:6402:1112:b0:413:3d99:f2d7 with SMTP id u18-20020a056402111200b004133d99f2d7mr14801504edv.23.1648457820218; Mon, 28 Mar 2022 01:57:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648457820; cv=none; d=google.com; s=arc-20160816; b=xvYVgeTxKJAWhTL+DLjjPIqbnzGPOCDCXmjh7WC+yYgfVBCr9a4FMBG++UwrhlpXJ0 wFsln3rRBdLaKGwNZr2rAlmtT7JUmvLLZJPs+1LJUQPHsUZzoto1sFYFFnHiXwyb3gdS 66omS/uBaeo6uqckq/JbJItUVkwEKjpM+xoM0/0BIRHSg38U4+cOwRsSR8k0ZOn4B6Qn 0aFYGVFvvSb0qamsHOIceVgJhaFb/fSoXvGsiEVu3m4O6Mf/HqbwMLOgrTQvcqJTkHC7 m8hOu1pUUVyNxCW207sRlEr7F/16WL7CfW+0CGNn3h2urH6KpKXYS0c5lKxg0EioLk9P TEGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=Eo+NI/ZY6vwsGX0YbjboRUexcl2mfDPwhfiG8UnYnwk=; b=N+0+uVTL7iCOZrDuXXx61pPJRyKh6HlZ1mj75f6XyJMmriSedKG+BTNp/xyJBqs1Zv h3R+yZUBVTB6usfUFnNDw70n/TpSrxwdfVcJMOKy7GaklkZsDS6xMgezg8UmHk+PMiYw S/g3zIhPuOYNoHahZLA53YQwFzFVtb+MDs/vU2S5DLAHiCZ2jLUnI7/arapwM+ywrQhn wGV/5/Ll9t1Zqq4+8BEku4ZYqjTkLmUDLyyuKb9JtMh59iHEOwbQyWEk9kalWJCRM2hh NymVDpzHoFVQ0y9rOqOqL+h9m1XyG4pUpV+PBJbN3AyFMM6aQaK868zuWx9XoCRVoY7u pJfw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=BnS1v48f; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q24-20020a1709064cd800b006df76385c8bsi12974818ejt.299.2022.03.28.01.56.34; Mon, 28 Mar 2022 01:57:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=BnS1v48f; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234737AbiCZTmP (ORCPT + 99 others); Sat, 26 Mar 2022 15:42:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40232 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229724AbiCZTmP (ORCPT ); Sat, 26 Mar 2022 15:42:15 -0400 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F43712E149 for ; Sat, 26 Mar 2022 12:40:38 -0700 (PDT) Received: by mail-lf1-x131.google.com with SMTP id d5so18574808lfj.9 for ; Sat, 26 Mar 2022 12:40:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Eo+NI/ZY6vwsGX0YbjboRUexcl2mfDPwhfiG8UnYnwk=; b=BnS1v48fprKmSRXFjcrnsMCOkSZvYZQKHkA3LVRLp/DQnYYFla62uXIfXJRAbLMigi bFCZxlifzHg0dE0dAEH4xtBlMhLSpHZdPD89nlH9F7pdl3UwkeWWhnSQ/WTlG5C7cq9x p3SeW6+eqS57A/bUxi4swECZhDIttG9TD9X6Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Eo+NI/ZY6vwsGX0YbjboRUexcl2mfDPwhfiG8UnYnwk=; b=VAqgvHV+Vp35xBdDDqS4Z2YJory5WzvQ3CTS0YWc7CP7T2qAoNZiyne4ZzSJnLTF/8 gRSE4EjpWtEWpnLp3VKuEuQBVdvv+tw3oQz6vQ7dXvpqGmI3GiHWwmrpzZ7Fz5L9FVxY nKdBZThpCmVFUnjnFgfG36fFUtBEAmQIf3rU6tBDLjvz5s13Obh0yeSTahMF+nXsXTtK iPHcHFck2JJRVrQzms1Subx4Xk+nCWBOf3/d4cjtErd1grswVxiUtKWNzHKjA8Jqyw5+ ltLmRp/lWlr4wdVQmn7Nqau5i9ZvqUfvv6joq6qpDnVUuS0UxtR3tyNZubkLQ/3wFc0+ O1jQ== X-Gm-Message-State: AOAM5307J4y2H6buVT1FFQ/R4LsIm+Dagd5A4e20/Y3izTIqByuvt1KB PuYYO6da40vQGTvmeNsSGcglSwbu2w3RXhruXa0= X-Received: by 2002:a05:6512:3c92:b0:448:392d:af85 with SMTP id h18-20020a0565123c9200b00448392daf85mr12826114lfv.511.1648323636219; Sat, 26 Mar 2022 12:40:36 -0700 (PDT) Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com. [209.85.167.43]) by smtp.gmail.com with ESMTPSA id h7-20020ac25d67000000b0044836d7c475sm1147556lft.147.2022.03.26.12.40.35 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 26 Mar 2022 12:40:35 -0700 (PDT) Received: by mail-lf1-f43.google.com with SMTP id bq24so2636403lfb.5 for ; Sat, 26 Mar 2022 12:40:35 -0700 (PDT) X-Received: by 2002:ac2:4203:0:b0:448:8053:d402 with SMTP id y3-20020ac24203000000b004488053d402mr12881072lfh.687.1648323634830; Sat, 26 Mar 2022 12:40:34 -0700 (PDT) MIME-Version: 1.0 References: <202203251443.9BBADFD98@keescook> In-Reply-To: From: Linus Torvalds Date: Sat, 26 Mar 2022 12:40:18 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [GIT PULL] FORTIFY_SOURCE updates for v5.18-rc1 To: Kees Cook Cc: Linux Kernel Mailing List , George Burgess IV , linux-hardening@vger.kernel.org, llvm@lists.linux.dev, Miguel Ojeda , Nathan Chancellor , Nick Desaulniers Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 26, 2022 at 12:29 PM Linus Torvalds wrote: > > Because if all the compiler issues and warnings have been sorted out, > it sounds to me like the compile-time side could/should be done > unconditionally if there are no runtime downsides. .. or do the existing compiler warnings for the builtins already cover all cases, and the only reason the fortify-source code has compile-time warnings is that the option takes over the builtins? So maybe there's no upside to the fortify-source code for that case? Linus