Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f1455f47-dbeb-46cb-69bd-5edf193f69fe@linux.alibaba.com>
Date:   Mon, 28 Mar 2022 11:11:43 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.1
Subject: Re: [PATCH v6 12/22] erofs: add cookie context helper functions
Content-Language: en-US
To:     dhowells@redhat.com, linux-cachefs@redhat.com, xiang@kernel.org,
        chao@kernel.org, linux-erofs@lists.ozlabs.org,
        torvalds@linux-foundation.org, gregkh@linuxfoundation.org,
        willy@infradead.org, linux-fsdevel@vger.kernel.org,
        joseph.qi@linux.alibaba.com, bo.liu@linux.alibaba.com,
        tao.peng@linux.alibaba.com, gerry@linux.alibaba.com,
        eguan@linux.alibaba.com, linux-kernel@vger.kernel.org,
        luodaowen.backend@bytedance.com, tianzichen@kuaishou.com,
        fannaihao@baidu.com
References: <20220325122223.102958-1-jefflexu@linux.alibaba.com>
 <20220325122223.102958-13-jefflexu@linux.alibaba.com>
 <Yj3GlpvjL3u0RTjN@B-P7TQMD6M-0146.local>
From:   JeffleXu <jefflexu@linux.alibaba.com>
In-Reply-To: <Yj3GlpvjL3u0RTjN@B-P7TQMD6M-0146.local>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 3/25/22 9:41 PM, Gao Xiang wrote:
> Hi Jeffle,
> 
> On Fri, Mar 25, 2022 at 08:22:13PM +0800, Jeffle Xu wrote:
>> Introduce "struct erofs_fscache" for managing cookie for backinig file,
>> and helper functions for initializing and cleaning up this context
>> structure.
>>
>> Signed-off-by: Jeffle Xu <jefflexu@linux.alibaba.com>
>> ---
>>  fs/erofs/fscache.c  | 61 +++++++++++++++++++++++++++++++++++++++++++++
>>  fs/erofs/internal.h | 14 +++++++++++
>>  2 files changed, 75 insertions(+)
>>
>> diff --git a/fs/erofs/fscache.c b/fs/erofs/fscache.c
>> index 08cf570a0810..73235fd43bf6 100644
>> --- a/fs/erofs/fscache.c
>> +++ b/fs/erofs/fscache.c
>> @@ -7,6 +7,67 @@
>>  
>>  static struct fscache_volume *volume;
>>  
>> +static int erofs_fscache_init_cookie(struct erofs_fscache *ctx, char *path)
>> +{
>> +	struct fscache_cookie *cookie;
>> +
>> +	cookie = fscache_acquire_cookie(volume, FSCACHE_ADV_WANT_CACHE_SIZE,
>> +					path, strlen(path),
>> +					NULL, 0, 0);
> 
> It'd be better to rearrange in one line?

Sure.

> 
> 					path, strlen(path), NULL, 0, 0);
> 
>> +	if (!cookie)
>> +		return -EINVAL;
>> +
>> +	fscache_use_cookie(cookie, false);
>> +	ctx->cookie = cookie;
>> +	return 0;
>> +}
>> +
>> +static inline void erofs_fscache_cleanup_cookie(struct erofs_fscache *ctx)
>> +{
>> +	struct fscache_cookie *cookie = ctx->cookie;
>> +
>> +	fscache_unuse_cookie(cookie, NULL, NULL);
>> +	fscache_relinquish_cookie(cookie, false);
>> +	ctx->cookie = NULL;
>> +}
>> +
>> +/*
>> + * erofs_fscache_get - create an fscache context for blob file
>> + * @sb:		superblock
>> + * @path:	name of blob file
>> + *
>> + * Return: fscache context on success, ERR_PTR() on failure.
>> + */
>> +struct erofs_fscache *erofs_fscache_get(struct super_block *sb, char *path)
> 
> erofs_fscache_register?

OK.


> 
>> +{
>> +	struct erofs_fscache *ctx;
>> +	int ret;
>> +
>> +	ctx = kzalloc(sizeof(*ctx), GFP_KERNEL);
>> +	if (!ctx)
>> +		return ERR_PTR(-ENOMEM);
>> +
>> +	ret = erofs_fscache_init_cookie(ctx, path);
> 
> Can we fold it here? No need to introduce such simple wrapper..
> 
>> +	if (ret) {
>> +		erofs_err(sb, "failed to init cookie");
> 
> It would be better to print the path?

OK.

> 
>> +		goto err;
> 
> 		kfree(ctx);
> 		return ERR_PTR(ret);
> 
> At least for now.

Yeah, it's better.

> 
>> +	}
>> +
>> +	return ctx;
>> +err:
>> +	kfree(ctx);
>> +	return ERR_PTR(ret);
>> +}
>> +
>> +void erofs_fscache_put(struct erofs_fscache *ctx)
> 
> erofs_fscache_unregister?

OK.

> 
>> +{
>> +	if (!ctx)
>> +		return;
>> +
>> +	erofs_fscache_cleanup_cookie(ctx);
> 
> Fold it too, since such helper doesn't simplify code a lot but need
> to take one more time to redirect..

OK.

-- 
Thanks,
Jeffle