Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Xiaomeng Tong <xiam0nd.tong@gmail.com>
To:     viresh.kumar@linaro.org
Cc:     linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, nm@ti.com,
        rafael.j.wysocki@intel.com, sboyd@kernel.org,
        stable@vger.kernel.org, vireshk@kernel.org, xiam0nd.tong@gmail.com
Subject: Re: [PATCH] opp: fix a missing check on list iterator
Date:   Mon, 28 Mar 2022 17:13:39 +0800
Message-Id: <20220328091339.27021-1-xiam0nd.tong@gmail.com>
In-Reply-To: <20220328085057.ikn3mcyz2gbftkg4@vireshk-i7>
References: <20220328085057.ikn3mcyz2gbftkg4@vireshk-i7>
Precedence: bulk

On Mon, 28 Mar 2022 14:20:57 +0530, Viresh Kumar wrote:
> On 28-03-22, 15:43, Xiaomeng Tong wrote:
> > No. the conditon to call opp_migrate_dentry(opp_dev, opp_table); is:
> > if (!list_is_singular(&opp_table->dev_list)), 
> > 
> > while list_is_singlular is: !list_empty(head) && (head->next == head->prev);
> > 
> > so the condition is: list_empty(head) || (head->next != head->prev)
> > 
> > if the list is empty, the bug can be triggered.
> 
> List can't be empty here by design. It will be a huge bug in that
> case, which should lead to crash somewhere.
> 

There is anther condition to trigger this bug: the list is not empty and
no element found (if (iter != opp_dev)).

--
Xiaomeng Tong