Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Christian Schoenebeck <linux_oss@crudebyte.com>
To:     asmadeus@codewreck.org
Cc:     David Kahurani <k.kahurani@gmail.com>, davem@davemloft.net,
        ericvh@gmail.com, kuba@kernel.org, linux-kernel@vger.kernel.org,
        lucho@ionkov.net, netdev@vger.kernel.org,
        syzkaller-bugs@googlegroups.com,
        v9fs-developer@lists.sourceforge.net,
        syzbot+5e28cdb7ebd0f2389ca4@syzkaller.appspotmail.com
Subject: Re: [syzbot] WARNING in p9_client_destroy
Date:   Sat, 26 Mar 2022 13:36:31 +0100
Message-ID: <2582025.XdajAv7fHn@silver>
In-Reply-To: <Yj8F6sQzx6Bvy+aZ@codewreck.org>
References: <CAAZOf26g-L2nSV-Siw6mwWQv1nv6on8c0fWqB4bKmX73QAFzow@mail.gmail.com>
 <3597833.OkAhqpS0b6@silver> <Yj8F6sQzx6Bvy+aZ@codewreck.org>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
Precedence: bulk

On Samstag, 26. M=E4rz 2022 13:24:10 CET asmadeus@codewreck.org wrote:
> Christian Schoenebeck wrote on Sat, Mar 26, 2022 at 12:48:26PM +0100:
> > [...]
> >=20
> > > Signed-off-by: David Kahurani <k.kahurani@gmail.com>
> > > Reported-by: syzbot+5e28cdb7ebd0f2389ca4@syzkaller.appspotmail.com
>=20
> Looks good to me - it's pretty much what I'd have done if I hadn't
> forgotten!
> It doesn't strike me as anything critical and I don't have anything else
> for this cycle so I'll just queue it in -next for now, and submit it
> at the start of the 5.19 cycle in ~2months.

BTW, another issue that I am seeing for a long time affects the fs-cache: W=
hen
I use cache=3Dmmap then things seem to be harmless, I periodically see mess=
ages
like these, but that's about it:

[90763.435562] FS-Cache: Duplicate cookie detected
[90763.436514] FS-Cache: O-cookie c=3D00dcb42f [p=3D00000003 fl=3D216 nc=3D=
0 na=3D0]
[90763.437795] FS-Cache: O-cookie d=3D0000000000000000{?} n=3D0000000000000=
000
[90763.440096] FS-Cache: O-key=3D[8] 'a7ab2c0000000000'
[90763.441656] FS-Cache: N-cookie c=3D00dcb4a7 [p=3D00000003 fl=3D2 nc=3D0 =
na=3D1]
[90763.446753] FS-Cache: N-cookie d=3D000000005b583d5a{9p.inode} n=3D000000=
00212184fb
[90763.448196] FS-Cache: N-key=3D[8] 'a7ab2c0000000000'

The real trouble starts when I use cache=3Dloose though, in this case I get=
 all
sorts of misbehaviours from time to time, especially complaining about inva=
lid
file descriptors.

Any clues?

Best regards,
Christian Schoenebeck