Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8ce4ea34-f389-6eff-2e5b-0f23641df219@gmail.com>
Date:   Sun, 27 Mar 2022 15:14:05 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH v1 03/12] dt-bindings: pinctrl: add i.MXRT1170 pinctrl
 Documentation
Content-Language: en-US
To:     Krzysztof Kozlowski <krzk@kernel.org>, linux-imx@nxp.com
Cc:     robh+dt@kernel.org, mturquette@baylibre.com, sboyd@kernel.org,
        shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de,
        festevam@gmail.com, aisheng.dong@nxp.com, stefan@agner.ch,
        linus.walleij@linaro.org, daniel.lezcano@linaro.org,
        tglx@linutronix.de, arnd@arndb.de, olof@lixom.net, soc@kernel.org,
        linux@armlinux.org.uk, abel.vesa@nxp.com, dev@lynxeye.de,
        marcel.ziswiler@toradex.com, tharvey@gateworks.com,
        leoyang.li@nxp.com, sebastian.reichel@collabora.com,
        cniedermaier@dh-electronics.com, clin@suse.com,
        giulio.benetti@benettiengineering.com, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org
References: <20220326144313.673549-1-Mr.Bossman075@gmail.com>
 <20220326144313.673549-4-Mr.Bossman075@gmail.com>
 <2af35b48-c49d-3a76-256b-c31d2650ed39@kernel.org>
From:   Jesse Taube <mr.bossman075@gmail.com>
In-Reply-To: <2af35b48-c49d-3a76-256b-c31d2650ed39@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 3/27/22 15:08, Krzysztof Kozlowski wrote:
> On 26/03/2022 15:43, Jesse Taube wrote:
>> Add i.MXRT1170 pinctrl binding Documentation
>>
>> Cc: Giulio Benetti <giulio.benetti@benettiengineering.com>
>> Signed-off-by: Jesse Taube <Mr.Bossman075@gmail.com>
>> ---
>>   .../bindings/pinctrl/fsl,imxrt1170.yaml       | 77 +++++++++++++++++++
>>   1 file changed, 77 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/pinctrl/fsl,imxrt1170.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/pinctrl/fsl,imxrt1170.yaml b/Documentation/devicetree/bindings/pinctrl/fsl,imxrt1170.yaml
>> new file mode 100644
>> index 000000000000..2e880b3e537c
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/pinctrl/fsl,imxrt1170.yaml
>> @@ -0,0 +1,77 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/pinctrl/fsl,imxrt1170.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Freescale i.MXRT1170 IOMUX Controller
>> +
>> +maintainers:
>> +  - Giulio Benetti <giulio.benetti@benettiengineering.com>
>> +  - Jesse Taube <Mr.Bossman075@gmail.com>
>> +
>> +description:
>> +  Please refer to fsl,imx-pinctrl.txt and pinctrl-bindings.txt in this directory
>> +  for common binding part and usage.
>> +
>> +properties:
>> +  compatible:
>> +    const: fsl,imxrt1170-iomuxc
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +# Client device subnode's properties
>> +patternProperties:
>> +  'grp$':
>> +    type: object
>> +    description:
>> +      Pinctrl node's client devices use subnodes for desired pin configuration.
>> +      Client device subnodes use below standard properties.
>> +
>> +    properties:
>> +      fsl,pins:
>> +        description:
>> +          each entry consists of 6 integers and represents the mux and config
>> +          setting for one pin. The first 5 integers <mux_reg conf_reg input_reg
>> +          mux_val input_val> are specified using a PIN_FUNC_ID macro, which can
>> +          be found in <arch/arm/boot/dts/imxrt1170-pinfunc.h>. The last
>> +          integer CONFIG is the pad setting value like pull-up on this pin. Please
>> +          refer to i.MXRT1170 Reference Manual for detailed CONFIG settings.
>> +        $ref: /schemas/types.yaml#/definitions/uint32-matrix
>> +        items:
>> +          items:
>> +            - description: |
>> +                "mux_reg" indicates the offset of mux register.
>> +            - description: |
>> +                "conf_reg" indicates the offset of pad configuration register.
>> +            - description: |
>> +                "input_reg" indicates the offset of select input register.
>> +            - description: |
>> +                "mux_val" indicates the mux value to be applied.
>> +            - description: |
>> +                "input_val" indicates the select input value to be applied.
>> +            - description: |
>> +                "pad_setting" indicates the pad configuration value to be applied.
>> +    required:
>> +      - fsl,pins
>> +
>> +    additionalProperties: false
>> +
>> +required:
>> +  - compatible
>> +  - reg
> 
> You miss pinctrl.yaml, why?
In the file name? Because I forgot for the fsl,imxrt1050.yaml, I can 
change for both files.
> 
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> +  - |
>> +    iomuxc: iomuxc@400e8000 {
>> +        compatible = "fsl,imxrt1170-iomuxc";
>> +        reg = <0x400e8000 0x4000>;
>> +        pinctrl_lpuart1: lpuart1grp {
>> +            fsl,pins =
>> +              <0x16C 0x3B0 0x620 0x0 0x0  0xf1>,
>> +              <0x170 0x3B4 0x61C 0x0 0x0	0xf1>;
>> +        };
>> +    };
> 
> 
> Best regards,
> Krzysztof