Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <cd928bbbba3260dfe6ce4a964185a377b4a767cd.camel@kernel.org>
Subject: Re: [PATCH] ceph: remove unused CEPH_MDS_LEASE_RELEASE related code
From:   Jeff Layton <jlayton@kernel.org>
To:     xiubli@redhat.com
Cc:     idryomov@gmail.com, vshankar@redhat.com,
        ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Mon, 28 Mar 2022 06:28:21 -0400
In-Reply-To: <20220328022535.847164-1-xiubli@redhat.com>
References: <20220328022535.847164-1-xiubli@redhat.com>
Content-Type: text/plain; charset="ISO-8859-15"
User-Agent: Evolution 3.42.4 (3.42.4-1.fc35) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 2022-03-28 at 10:25 +0800, xiubli@redhat.com wrote:
> From: Xiubo Li <xiubli@redhat.com>
> 
> The ceph_mdsc_lease_release() has been removed by commit(8aa152c77890)
> and the CEPH_MDS_LEASE_RELEASE will never be used.
> 

Like it says in Documentation/process/5.Posting.rst:

"...and please provide both the commit ID and the title when citing
commits"

You might want to reword this with something like:

"ceph_mdsc_lease_release was removed by commit 8aa152c77890 (ceph:
remove ceph_mdsc_lease_release). ceph_mdsc_lease_send_msg will never
call this function with CEPH_MDS_LEASE_RELEASE."

> Signed-off-by: Xiubo Li <xiubli@redhat.com>
> ---
>  fs/ceph/mds_client.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/fs/ceph/mds_client.c b/fs/ceph/mds_client.c
> index 459c6f23915f..a89ee866ebbb 100644
> --- a/fs/ceph/mds_client.c
> +++ b/fs/ceph/mds_client.c
> @@ -4424,12 +4424,6 @@ void ceph_mdsc_lease_send_msg(struct ceph_mds_session *session,
>  	memcpy((void *)(lease + 1) + 4,
>  	       dentry->d_name.name, dentry->d_name.len);
>  	spin_unlock(&dentry->d_lock);
> -	/*
> -	 * if this is a preemptive lease RELEASE, no need to
> -	 * flush request stream, since the actual request will
> -	 * soon follow.
> -	 */
> -	msg->more_to_follow = (action == CEPH_MDS_LEASE_RELEASE);
>  
>  	ceph_con_send(&session->s_con, msg);
>  }

It might be possible to trim this function back further. There's only
one caller and it always calls this with the same "action" value. Still,
this looks fine...

Reviewed-by: Jeff Layton <jlayton@kernel.org>