Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 27 Mar 2022 14:55:11 +0100
From:   Jonathan Cameron <jic23@kernel.org>
To:     Shreeya Patel <shreeya.patel@collabora.com>
Cc:     lars@metafoo.de, robh+dt@kernel.org, Zhigang.Shi@liteon.com,
        krisman@collabora.com, linux-iio@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        kernel@collabora.com, alvaro.soliverez@collabora.com
Subject: Re: [PATCH 2/3] dt-bindings: Document ltrf216a light sensor
 bindings
Message-ID: <20220327145511.2d36dd10@jic23-huawei>
In-Reply-To: <20220325103014.6597-3-shreeya.patel@collabora.com>
References: <20220325103014.6597-1-shreeya.patel@collabora.com>
        <20220325103014.6597-3-shreeya.patel@collabora.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Fri, 25 Mar 2022 16:00:13 +0530
Shreeya Patel <shreeya.patel@collabora.com> wrote:

> Add devicetree bindings for ltrf216a ambient light sensor
> 
> Signed-off-by: Shreeya Patel <shreeya.patel@collabora.com>
Hi Shreeya,

As we are making this Zhigang Shi's problem to maintain, I'm 
looking for an ack.  Bit mean otherwise :)

Except for the deprecated part this could just have gone in
trivial-bindings.yaml.

I guess you don't need it for your existing board, but best
practice would probably include ensuring whatever supplies
the device needs are here so that platforms that don't enable
them by default can turn them on.

Also, there is an interrupt according to the datasheet linked
from patch 3 and that should definitely be in the binding
even if the driver isn't using it.

Jonathan


> ---
>  .../bindings/iio/light/liteon,ltrf216a.yaml   | 42 +++++++++++++++++++
>  1 file changed, 42 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/light/liteon,ltrf216a.yaml
> 
> diff --git a/Documentation/devicetree/bindings/iio/light/liteon,ltrf216a.yaml b/Documentation/devicetree/bindings/iio/light/liteon,ltrf216a.yaml
> new file mode 100644
> index 000000000000..275d86a0353a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/light/liteon,ltrf216a.yaml
> @@ -0,0 +1,42 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/light/liteon,ltrf216a.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: LTRF216A Ambient Light Sensor
> +
> +maintainers:
> +  - Zhigang Shi <Zhigang.Shi@liteon.com>
> +
> +description: |
> +  Ambient sensing with an i2c interface.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - liteon,ltrf216a
> +      - ltr,ltrf216a
> +
> +  reg:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    i2c {
> +
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        light-sensor@53 {
> +                compatible = "ltr,ltrf216a";
> +                reg = <0x53>;
> +        };
> +    };
> +...