Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp5422873pxb; Mon, 28 Mar 2022 12:16:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz4MexqKx5z+rnmuDKoeDatOBmaEp8SgfrkaH+lhs7gSvTOvPT8Mw/w4EYrEIPReneVLjEr X-Received: by 2002:a17:907:97cc:b0:6df:83bc:314c with SMTP id js12-20020a17090797cc00b006df83bc314cmr29583673ejc.587.1648494979905; Mon, 28 Mar 2022 12:16:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648494979; cv=none; d=google.com; s=arc-20160816; b=SrcOAAKBhWVozJ5O7cAscUh+5SN8jaevl2asThV0GN5LKzoiR4qILmTFMQdIjQ+q+E y1mA82TnTVKRQg1tVj0A9N5+y1uwGwmOM5g2rh+gwnkeyM8g+bfsNEMahKWKqwmDdLLh rMDI76kVucCgCeRwc7ijuelGuqbAdbyrsdqWSjI5EWzKu1upcdbaDxt2M4bjoUvAZeCH SipGXJXlzEUeqQ2ZtWX1yZn7xMvyWeJSYtKQvcCTHfhCG+IzkC0W4+6dIioRWe1hBG2g /yZaX/yp6ywMFQUQNAZ9aa/4Q86b/PacmVsYsN4jhatPljOxkfSckHYmzG0uiNcYKpdS pP8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=62kxbYjOC1Pdkwa5wMmdd0cCG7qP5qnu3ZqUiccwe3s=; b=bOwYyBdtClgiyiCbE1fUzXfRyr+bNsln8ZkqCutBuQe5NuYd+TPwSeHF1aYhtuCNjq aeCe0XEyqCfqtfXCj6gm20wCfxwE79ccFkMoS3uiMdqdrgT59HGRLzycdIZp669RucxG l15QRDR1iz1F0npxeidoRV3T4VRjA+X3PlnVy41BSmNkfeNGTF2zPZ0a1/LtkK5vt7zV Yq4KlUIj/Xact03uymy3B6u/ZSVSIkEVapG5Dy8AAZq0LscMfBF6RXe3Z4gEOqrGNHuc tI1qKHmmb8lkoYBMHY/2oYyR8BCXbhiVyi5NYvWc6Q3O8S/aWw9W3rLPO9Zp9msiqzuG R8uw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@marek-ca.20210112.gappssmtp.com header.s=20210112 header.b=I4aBTTyR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r9-20020a056402018900b0041949c93e3dsi14000936edv.502.2022.03.28.12.15.54; Mon, 28 Mar 2022 12:16:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@marek-ca.20210112.gappssmtp.com header.s=20210112 header.b=I4aBTTyR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236623AbiC0U2j (ORCPT + 99 others); Sun, 27 Mar 2022 16:28:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52710 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234709AbiC0U2h (ORCPT ); Sun, 27 Mar 2022 16:28:37 -0400 Received: from mail-qt1-x831.google.com (mail-qt1-x831.google.com [IPv6:2607:f8b0:4864:20::831]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 95F3E33E87 for ; Sun, 27 Mar 2022 13:26:57 -0700 (PDT) Received: by mail-qt1-x831.google.com with SMTP id t2so10791336qtw.9 for ; Sun, 27 Mar 2022 13:26:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marek-ca.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=62kxbYjOC1Pdkwa5wMmdd0cCG7qP5qnu3ZqUiccwe3s=; b=I4aBTTyRTAaQtbpu3CS7l6DyrNP/QDmYqsRB8mfAv60faqVosTuBA1upMbJW6HkIFR Dm5BDU2Mt5jjrtSGH5UlYB6xEBkLChnrFaCcbUEnbLdNeUh1EK0YtnfTRqRPubZS3zwk mZWH7wUVW68Ibp56kJHs93vIOGwxa8Q+60MvuyQfWGp/GyAk2WYOkvoLvSJ0Yawo6+gQ fYgZIi2ThISR0qY9CyKM+P4sFEzDtXHRRJjUtSHn6eGJ+lu4Xd3EzVfbJ8QnWUWVfDlV fnmQQ89SmLmJKGEtYJwdUYXLI2RFJEDSPe20yHqD6D84crtbeW2G+mLf/6HRSE/XHktk 4P3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=62kxbYjOC1Pdkwa5wMmdd0cCG7qP5qnu3ZqUiccwe3s=; b=MQZlYsALZ9Bo/qBerxyzZ+46/Yqruk1FuO6U4UnuRVPpxFUs5C+AOBsmD/pXI6UXwO HKHsDwYYnLtbcwtsyf/6gTJI/UL1EOWF5O/5t3NgqWwKhvOKqstC6MKgKU0WbKZcSbbG 284jbvdSQnzgz6gigW/Jn34wIqvLsaIFsJRtd5jfwanF+G8srViET4yrcAhshEGZJqB+ jpHaSzOfdVHtB1eoai/KXrOj8C95nyvBzmUAsRUtNzqzaiUqMgjaQ6rfXWyL8h/PsNuq MYVu5rC1atnnD/F1aqY4YNoVmcu7q2N0sfLhzuWUUdM+mvYP0UZbex6yAifOPnaI5jrA +4KQ== X-Gm-Message-State: AOAM530wxOxlHZqh+1lYyhQqMuzV5ng4uBKZzYZusaRdJZm0zcmORXhH 85nWajfEUuI3aPJj3Dh3y1lfUg== X-Received: by 2002:ac8:5b86:0:b0:2e2:72c:9e06 with SMTP id a6-20020ac85b86000000b002e2072c9e06mr18354799qta.113.1648412816673; Sun, 27 Mar 2022 13:26:56 -0700 (PDT) Received: from localhost.localdomain (modemcable134.222-177-173.mc.videotron.ca. [173.177.222.134]) by smtp.gmail.com with ESMTPSA id g9-20020a05620a108900b0067b13036bd5sm6720386qkk.52.2022.03.27.13.26.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Mar 2022 13:26:56 -0700 (PDT) From: Jonathan Marek To: freedreno@lists.freedesktop.org Cc: Rob Clark , Sean Paul , Abhinav Kumar , David Airlie , Daniel Vetter , Akhil P Oommen , Yangtao Li , Dmitry Osipenko , Bjorn Andersson , Emma Anholt , Vladimir Lypak , linux-arm-msm@vger.kernel.org (open list:DRM DRIVER FOR MSM ADRENO GPU), dri-devel@lists.freedesktop.org (open list:DRM DRIVER FOR MSM ADRENO GPU), linux-kernel@vger.kernel.org (open list) Subject: [PATCH 1/4] drm/msm/adreno: move a6xx CP_PROTECT macros to common code Date: Sun, 27 Mar 2022 16:25:54 -0400 Message-Id: <20220327202643.4053-2-jonathan@marek.ca> X-Mailer: git-send-email 2.26.1 In-Reply-To: <20220327202643.4053-1-jonathan@marek.ca> References: <20220327202643.4053-1-jonathan@marek.ca> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org These will be used by a7xx, so move them to common code. A6XX_ prefix is kept because the generic ADRENO_ is already in use. Signed-off-by: Jonathan Marek --- drivers/gpu/drm/msm/adreno/a6xx_gpu.h | 17 ----------------- drivers/gpu/drm/msm/adreno/adreno_gpu.h | 6 ++++++ 2 files changed, 6 insertions(+), 17 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.h b/drivers/gpu/drm/msm/adreno/a6xx_gpu.h index 86e0a7c3fe6df..d117c1589f2af 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.h +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.h @@ -36,23 +36,6 @@ struct a6xx_gpu { #define to_a6xx_gpu(x) container_of(x, struct a6xx_gpu, base) -/* - * Given a register and a count, return a value to program into - * REG_CP_PROTECT_REG(n) - this will block both reads and writes for _len - * registers starting at _reg. - */ -#define A6XX_PROTECT_NORDWR(_reg, _len) \ - ((1 << 31) | \ - (((_len) & 0x3FFF) << 18) | ((_reg) & 0x3FFFF)) - -/* - * Same as above, but allow reads over the range. For areas of mixed use (such - * as performance counters) this allows us to protect a much larger range with a - * single register - */ -#define A6XX_PROTECT_RDONLY(_reg, _len) \ - ((((_len) & 0x3FFF) << 18) | ((_reg) & 0x3FFFF)) - static inline bool a6xx_has_gbif(struct adreno_gpu *gpu) { if(adreno_is_a630(gpu)) diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.h b/drivers/gpu/drm/msm/adreno/adreno_gpu.h index 0490c5fbb7803..55c5433a4ea18 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.h +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.h @@ -416,6 +416,10 @@ static inline uint32_t get_wptr(struct msm_ringbuffer *ring) ((1 << 30) | (1 << 29) | \ ((ilog2((_len)) & 0x1F) << 24) | (((_reg) << 2) & 0xFFFFF)) +#define A6XX_PROTECT_NORDWR(_reg, _len) \ + ((1 << 31) | \ + (((_len) & 0x3FFF) << 18) | ((_reg) & 0x3FFFF)) + /* * Same as above, but allow reads over the range. For areas of mixed use (such * as performance counters) this allows us to protect a much larger range with a @@ -425,6 +429,8 @@ static inline uint32_t get_wptr(struct msm_ringbuffer *ring) ((1 << 29) \ ((ilog2((_len)) & 0x1F) << 24) | (((_reg) << 2) & 0xFFFFF)) +#define A6XX_PROTECT_RDONLY(_reg, _len) \ + ((((_len) & 0x3FFF) << 18) | ((_reg) & 0x3FFFF)) #define gpu_poll_timeout(gpu, addr, val, cond, interval, timeout) \ readl_poll_timeout((gpu)->mmio + ((addr) << 2), val, cond, \ -- 2.26.1