Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 28 Mar 2022 14:08:12 +0800
From:   kernel test robot <lkp@intel.com>
To:     Haowen Bai <baihaowen@meizu.com>, hca@linux.ibm.com,
        gor@linux.ibm.com, agordeev@linux.ibm.com,
        borntraeger@linux.ibm.com, svens@linux.ibm.com
Cc:     kbuild-all@lists.01.org, linux-s390@vger.kernel.org,
        linux-kernel@vger.kernel.org, Haowen Bai <baihaowen@meizu.com>
Subject: Re: [PATCH] s390: Simplify the calculation of variables
Message-ID: <202203281418.KxPHz4Ek-lkp@intel.com>
References: <1648434982-28862-1-git-send-email-baihaowen@meizu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1648434982-28862-1-git-send-email-baihaowen@meizu.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

Hi Haowen,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on s390/features]
[also build test ERROR on v5.17 next-20220325]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Haowen-Bai/s390-Simplify-the-calculation-of-variables/20220328-103807
base:   https://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git features
config: s390-randconfig-r044-20220327 (https://download.01.org/0day-ci/archive/20220328/202203281418.KxPHz4Ek-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/7356660d5a4a5dc70f5e18b63125c43d218885f3
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Haowen-Bai/s390-Simplify-the-calculation-of-variables/20220328-103807
        git checkout 7356660d5a4a5dc70f5e18b63125c43d218885f3
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=s390 SHELL=/bin/bash drivers/iio/accel/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from arch/s390/include/asm/cio.h:18,
                    from arch/s390/include/asm/chpid.h:10,
                    from arch/s390/include/asm/sclp.h:20,
                    from arch/s390/include/asm/pci.h:12,
                    from include/linux/pci.h:1901,
                    from arch/s390/include/asm/hw_irq.h:6,
                    from include/linux/irq.h:592,
                    from include/linux/iio/trigger.h:6,
                    from drivers/iio/accel/adxl355_core.c:14:
   arch/s390/include/asm/scsw.h: In function 'scsw_tm_is_valid_pno':
>> arch/s390/include/asm/scsw.h:695:54: error: expected ';' before '}' token
     695 |                (scsw->tm.actl & SCSW_ACTL_SUSPENDED))
         |                                                      ^
         |                                                      ;
     696 | }
         | ~                                                     
--
   In file included from arch/s390/include/asm/cio.h:18,
                    from arch/s390/include/asm/chpid.h:10,
                    from arch/s390/include/asm/sclp.h:20,
                    from arch/s390/include/asm/pci.h:12,
                    from include/linux/pci.h:1901,
                    from arch/s390/include/asm/hw_irq.h:6,
                    from include/linux/irq.h:592,
                    from include/linux/iio/trigger.h:6,
                    from drivers/iio/accel/kxcjk-1013.c:21:
   arch/s390/include/asm/scsw.h: In function 'scsw_tm_is_valid_pno':
>> arch/s390/include/asm/scsw.h:695:54: error: expected ';' before '}' token
     695 |                (scsw->tm.actl & SCSW_ACTL_SUSPENDED))
         |                                                      ^
         |                                                      ;
     696 | }
         | ~                                                     
   At top level:
   drivers/iio/accel/kxcjk-1013.c:1709:36: warning: 'kx_acpi_match' defined but not used [-Wunused-const-variable=]
    1709 | static const struct acpi_device_id kx_acpi_match[] = {
         |                                    ^~~~~~~~~~~~~
--
   In file included from arch/s390/include/asm/cio.h:18,
                    from arch/s390/include/asm/chpid.h:10,
                    from arch/s390/include/asm/sclp.h:20,
                    from arch/s390/include/asm/pci.h:12,
                    from include/linux/pci.h:1901,
                    from arch/s390/include/asm/hw_irq.h:6,
                    from include/linux/irq.h:592,
                    from include/linux/iio/trigger.h:6,
                    from drivers/iio/accel/mxc4005.c:14:
   arch/s390/include/asm/scsw.h: In function 'scsw_tm_is_valid_pno':
>> arch/s390/include/asm/scsw.h:695:54: error: expected ';' before '}' token
     695 |                (scsw->tm.actl & SCSW_ACTL_SUSPENDED))
         |                                                      ^
         |                                                      ;
     696 | }
         | ~                                                     
   At top level:
   drivers/iio/accel/mxc4005.c:473:36: warning: 'mxc4005_acpi_match' defined but not used [-Wunused-const-variable=]
     473 | static const struct acpi_device_id mxc4005_acpi_match[] = {
         |                                    ^~~~~~~~~~~~~~~~~~
--
   In file included from arch/s390/include/asm/cio.h:18,
                    from arch/s390/include/asm/chpid.h:10,
                    from arch/s390/include/asm/sclp.h:20,
                    from arch/s390/include/asm/pci.h:12,
                    from include/linux/pci.h:1901,
                    from arch/s390/include/asm/hw_irq.h:6,
                    from include/linux/irq.h:592,
                    from include/linux/iio/trigger.h:6,
                    from drivers/iio/accel/stk8ba50.c:18:
   arch/s390/include/asm/scsw.h: In function 'scsw_tm_is_valid_pno':
>> arch/s390/include/asm/scsw.h:695:54: error: expected ';' before '}' token
     695 |                (scsw->tm.actl & SCSW_ACTL_SUSPENDED))
         |                                                      ^
         |                                                      ;
     696 | }
         | ~                                                     
   At top level:
   drivers/iio/accel/stk8ba50.c:539:36: warning: 'stk8ba50_acpi_id' defined but not used [-Wunused-const-variable=]
     539 | static const struct acpi_device_id stk8ba50_acpi_id[] = {
         |                                    ^~~~~~~~~~~~~~~~


vim +695 arch/s390/include/asm/scsw.h

   682	
   683	/**
   684	 * scsw_tm_is_valid_pno - check pno field validity
   685	 * @scsw: pointer to scsw
   686	 *
   687	 * Return non-zero if the pno field of the specified transport mode scsw is
   688	 * valid, zero otherwise.
   689	 */
   690	static inline int scsw_tm_is_valid_pno(union scsw *scsw)
   691	{
   692		return (scsw->tm.fctl != 0) &&
   693		       (scsw->tm.stctl & SCSW_STCTL_STATUS_PEND) &&
   694		       (!(scsw->tm.stctl & SCSW_STCTL_INTER_STATUS) ||
 > 695		       (scsw->tm.actl & SCSW_ACTL_SUSPENDED))
   696	}
   697	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp